fix: make spinner a pure loading indicator (#172)

Author: felipefreitag

src/commands/api-keys/create.ts

@@ -97,19 +97,15 @@ Permissions:
 
     await runCreate(
       {
-        spinner: {
-          loading: 'Creating API key...',
-          success: 'API key created',
-          fail: 'Failed to create API key',
-        },
+        loading: 'Creating API key...',
         sdkCall: (resend) =>
           resend.apiKeys.create({
             name,
             ...(permission && { permission }),
             ...(domainId && { domain_id: domainId }),
           }),
         onInteractive: (d) => {
-          console.log(`\n  ${pc.gray('Name:')}    ${name}`);
+          console.log(`  ${pc.gray('Name:')}    ${name}`);
           console.log(`  ${pc.gray('ID:')}      ${d.id}`);
           console.log(`  ${pc.gray('Token:')}   ${d.token}`);
           console.log(

src/commands/api-keys/delete.ts

@@ -36,13 +36,9 @@ can delete itself — the API does not prevent self-deletion.`,
       !!opts.yes,
       {
         confirmMessage: `Delete API key ${id}?\nAny services using this key will stop working.`,
-        spinner: {
-          loading: 'Deleting API key...',
-          success: 'API key deleted',
-          fail: 'Failed to delete API key',
-        },
+        loading: 'Deleting API key...',
         object: 'api-key',
-        successMsg: 'API key deleted.',
+        successMsg: 'API key deleted',
         sdkCall: (resend) => resend.apiKeys.remove(id),
       },
       globalOpts,

src/commands/api-keys/list.ts

@@ -22,11 +22,7 @@ export const listApiKeysCommand = new Command('list')
     const globalOpts = cmd.optsWithGlobals() as GlobalOpts;
     await runList(
       {
-        spinner: {
-          loading: 'Fetching API keys...',
-          success: 'API keys fetched',
-          fail: 'Failed to list API keys',
-        },
+        loading: 'Fetching API keys...',
         sdkCall: (resend) => resend.apiKeys.list(),
         onInteractive: (list) => console.log(renderApiKeysTable(list.data)),
       },

src/commands/broadcasts/create.ts

@@ -225,15 +225,7 @@ Scheduling:
 
     await runCreate(
       {
-        spinner: {
-          loading: 'Creating broadcast...',
-          success: opts.send
-            ? opts.scheduledAt
-              ? 'Broadcast scheduled'
-              : 'Broadcast sent'
-            : 'Broadcast created',
-          fail: 'Failed to create broadcast',
-        },
+        loading: 'Creating broadcast...',
         sdkCall: (resend) =>
           resend.broadcasts.create({
             from,
@@ -252,14 +244,14 @@ Scheduling:
         onInteractive: (d) => {
           if (opts.send) {
             if (opts.scheduledAt) {
-              console.log(`\nBroadcast scheduled: ${d.id}`);
+              console.log(`Broadcast scheduled: ${d.id}`);
             } else {
-              console.log(`\nBroadcast sent: ${d.id}`);
+              console.log(`Broadcast sent: ${d.id}`);
             }
           } else {
-            console.log(`\nBroadcast created: ${d.id}`);
+            console.log(`Broadcast created: ${d.id}`);
             console.log('Status: draft');
-            console.log(`\nSend it with: resend broadcasts send ${d.id}`);
+            console.log(`Send it with: resend broadcasts send ${d.id}`);
           }
         },
       },

src/commands/broadcasts/delete.ts

@@ -35,13 +35,9 @@ Non-interactive: --yes is required to confirm deletion when stdin/stdout is not
       !!opts.yes,
       {
         confirmMessage: `Delete broadcast ${id}?\nIf scheduled, delivery will be cancelled.`,
-        spinner: {
-          loading: 'Deleting broadcast...',
-          success: 'Broadcast deleted',
-          fail: 'Failed to delete broadcast',
-        },
+        loading: 'Deleting broadcast...',
         object: 'broadcast',
-        successMsg: 'Broadcast deleted.',
+        successMsg: 'Broadcast deleted',
         sdkCall: (resend) => resend.broadcasts.remove(id),
       },
       globalOpts,

src/commands/broadcasts/get.ts

@@ -28,14 +28,10 @@ Use this command to retrieve the full broadcast payload.`,
     const id = await pickId(idArg, broadcastPickerConfig, globalOpts);
     await runGet(
       {
-        spinner: {
-          loading: 'Fetching broadcast...',
-          success: 'Broadcast fetched',
-          fail: 'Failed to fetch broadcast',
-        },
+        loading: 'Fetching broadcast...',
         sdkCall: (resend) => resend.broadcasts.get(id),
         onInteractive: (b) => {
-          console.log(`\nBroadcast: ${b.id}`);
+          console.log(`Broadcast: ${b.id}`);
           console.log(`  Status:      ${broadcastStatusIndicator(b.status)}`);
           console.log(`  Name:        ${b.name ?? '(untitled)'}`);
           console.log(`  From:        ${b.from ?? '—'}`);

src/commands/broadcasts/list.ts

@@ -49,11 +49,7 @@ To retrieve full details (html, from, subject), use: resend broadcasts get <id>`
     );
     await runList(
       {
-        spinner: {
-          loading: 'Fetching broadcasts...',
-          success: 'Broadcasts fetched',
-          fail: 'Failed to list broadcasts',
-        },
+        loading: 'Fetching broadcasts...',
         sdkCall: (resend) => resend.broadcasts.list(paginationOpts),
         onInteractive: (list) => {
           console.log(renderBroadcastsTable(list.data));

src/commands/broadcasts/send.ts

@@ -36,25 +36,17 @@ Scheduling:
     const globalOpts = cmd.optsWithGlobals() as GlobalOpts;
     const id = await pickId(idArg, sendBroadcastPickerConfig, globalOpts);
 
-    const successMsg = opts.scheduledAt
-      ? `\nBroadcast scheduled: ${id}`
-      : `\nBroadcast sent: ${id}`;
-
     await runWrite(
       {
-        spinner: {
-          loading: opts.scheduledAt
-            ? 'Scheduling broadcast...'
-            : 'Sending broadcast...',
-          success: opts.scheduledAt ? 'Broadcast scheduled' : 'Broadcast sent',
-          fail: 'Failed to send broadcast',
-        },
+        loading: opts.scheduledAt
+          ? 'Scheduling broadcast...'
+          : 'Sending broadcast...',
         sdkCall: (resend) =>
           resend.broadcasts.send(id, {
             ...(opts.scheduledAt && { scheduledAt: opts.scheduledAt }),
           }),
         errorCode: 'send_error',
-        successMsg,
+        successMsg: opts.scheduledAt ? 'Broadcast scheduled' : 'Broadcast sent',
         permission: 'sending_access',
       },
       globalOpts,

src/commands/broadcasts/update.ts

@@ -137,11 +137,7 @@ Variable interpolation:
 
     await runWrite(
       {
-        spinner: {
-          loading: 'Updating broadcast...',
-          success: 'Broadcast updated',
-          fail: 'Failed to update broadcast',
-        },
+        loading: 'Updating broadcast...',
         sdkCall: (resend) =>
           resend.broadcasts.update(id, {
             ...(opts.from != null && { from: opts.from }),
@@ -151,7 +147,7 @@ Variable interpolation:
             ...(opts.name != null && { name: opts.name }),
           }),
         errorCode: 'update_error',
-        successMsg: `\nBroadcast updated: ${id}`,
+        successMsg: `Broadcast updated: ${id}`,
       },
       globalOpts,
     );

src/commands/contact-properties/create.ts

@@ -103,14 +103,10 @@ built-in contact fields and may cause unexpected behavior in broadcasts.`,
 
     await runCreate(
       {
-        spinner: {
-          loading: 'Creating contact property...',
-          success: 'Contact property created',
-          fail: 'Failed to create contact property',
-        },
+        loading: 'Creating contact property...',
         sdkCall: (resend) => resend.contactProperties.create(payload),
         onInteractive: (data) => {
-          console.log(`\nContact property created: ${data.id}`);
+          console.log(`Contact property created: ${data.id}`);
         },
       },
       globalOpts,