Check that cursor is empty before returning parsed ids

Checking that the cursor is empty before returning parsed ids
ensure that the parser consumes the whole input and does not generate
an id from a prefix of the input.

Author: tillrohrmann

crates/types/src/identifiers.rs

@@ -385,6 +385,11 @@ impl FromStr for InvocationUuid {
 
         // ulid (u128)
         let raw_ulid: u128 = decoder.cursor.decode_next()?;
+
+        if decoder.cursor.remaining() != 0 {
+            return Err(IdDecodeError::Length);
+        }
+
         Ok(Self::from(raw_ulid))
     }
 }
@@ -743,6 +748,11 @@ impl FromStr for InvocationId {
         // ulid (u128)
         let raw_ulid: u128 = decoder.cursor.decode_next()?;
         let inner = InvocationUuid::from(raw_ulid);
+
+        if decoder.cursor.remaining() != 0 {
+            return Err(IdDecodeError::Length);
+        }
+
         Ok(Self {
             partition_key,
             inner,

crates/types/src/vqueues/entry_id.rs

@@ -95,11 +95,21 @@ impl FromStr for VQueueEntryId {
             InvocationId::RESOURCE_TYPE => {
                 let partition_key: PartitionKey = decoder.cursor.decode_next()?;
                 let raw: [u8; REMAINDER_LEN] = decoder.cursor.decode_next::<u128>()?.to_be_bytes();
+
+                if decoder.cursor.remaining() != 0 {
+                    return Err(IdDecodeError::Length);
+                }
+
                 Ok(Self::Invocation(partition_key, raw))
             }
             StateMutationId::RESOURCE_TYPE => {
                 let partition_key: PartitionKey = decoder.cursor.decode_next()?;
                 let raw: [u8; REMAINDER_LEN] = decoder.cursor.decode_next::<u128>()?.to_be_bytes();
+
+                if decoder.cursor.remaining() != 0 {
+                    return Err(IdDecodeError::Length);
+                }
+
                 Ok(Self::StateMutation(partition_key, raw))
             }
             _ => Err(IdDecodeError::TypeMismatch),

crates/types/src/vqueues/vqueue_id.rs

@@ -256,6 +256,10 @@ impl FromStr for VQueueId {
             // the version of the encoded string.
             let rest: u128 = decoder.cursor.decode_next()?;
             buf.put_u128(rest);
+
+            if decoder.cursor.remaining() != 0 {
+                return Err(IdDecodeError::Length);
+            }
         }
 
         Ok(Self(buf))