Fix

Author: slinkydeveloper

sdk-core/src/main/java/dev/restate/sdk/core/AsyncResults.java

@@ -121,7 +121,7 @@ public void tryCancel() {
     }
 
     @Override
-    public void tryComplete(NotificationReader reader) {
+    public void tryComplete(NotificationReader reader) {      if (this.isDone()) return;
       reader
           .take(handle)
           .ifPresent(
@@ -173,7 +173,7 @@ public void tryCancel() {
     }
 
     @Override
-    public void tryComplete(NotificationReader reader) {
+    public void tryComplete(NotificationReader reader) {      if (this.isDone()) return;
       asyncResult.tryComplete(reader);
     }
 
@@ -291,7 +291,7 @@ public void tryCancel() {
     }
 
     @Override
-    public void tryComplete(NotificationReader reader) {
+    public void tryComplete(NotificationReader reader) {      if (this.isDone()) return;
       asyncResults.forEach(ar -> ar.tryComplete(reader));
       for (int i = 0; i < asyncResults.size(); i++) {
         if (asyncResults.get(i).isDone()) {
@@ -341,6 +341,7 @@ public void tryCancel() {
 
     @Override
     public void tryComplete(NotificationReader reader) {
+      if (this.isDone()) return;
       asyncResults.forEach(ar -> ar.tryComplete(reader));
       asyncResults.stream()
           .filter(ar -> ar.publicFuture().isCompletedExceptionally())

sdk-core/src/main/java/dev/restate/sdk/core/HandlerContextImpl.java

@@ -423,9 +423,6 @@ private void pollAsyncResultInner(AsyncResultInternal<?> asyncResult) {
         asyncResult.publicFuture().completeExceptionally(AbortedExecutionException.INSTANCE);
         return;
       }
-      if (asyncResult.isDone()) {
-        return;
-      }
 
       // Let's start by trying to complete it
       try {
@@ -436,6 +433,10 @@ private void pollAsyncResultInner(AsyncResultInternal<?> asyncResult) {
         asyncResult.publicFuture().completeExceptionally(AbortedExecutionException.INSTANCE);
         return;
       }
+      // If done, nothing more to do here.
+      if (asyncResult.isDone()) {
+        return;
+      }
 
       // Not ready yet: make progress on what's still uncompleted. doAwait walks the async-result
       // tree directly (asyncResult is the await tree) and returns null when nothing is left to

sdk-core/src/main/java/dev/restate/sdk/core/StateMachine.java

@@ -87,7 +87,7 @@ record CancelSignalReceived() implements AwaitResult {}
    * AbortedExecutionException}, which should be treated as a clean abort of the user code, not a
    * failure to re-report.
    */
-  AwaitResult doAwait(UnresolvedFuture future);
+  @Nullable AwaitResult doAwait(UnresolvedFuture future);
 
   sealed interface NotificationValue {