chore: address warnings on windows targets (#663)

Author: reubeno

.vscode/settings.json

@@ -13,5 +13,8 @@
     "rewrap.wrappingColumn": 90,
     "rust-analyzer.debug.openDebugPane": true,
     "rust-analyzer.testExplorer": true,
-    "rust-analyzer.check.features": "all"
+    "rust-analyzer.check.features": "all",
+    "rust-analyzer.check.allTargets": true,
+    "rust-analyzer.check.workspace": true,
+    "sarif-viewer.connectToGithubCodeScanning": "on",
 }

brush-core/benches/shell.rs

@@ -160,4 +160,4 @@ criterion::criterion_group! {
 criterion::criterion_main!(benches);
 
 #[cfg(not(unix))]
-fn main() -> () {}
+fn main() {}

brush-core/src/processes.rs

@@ -34,6 +34,7 @@ impl ChildProcess {
         #[allow(unused_mut, reason = "only mutated on some platforms")]
         let mut sigchld = sys::signal::chld_signal_listener()?;
 
+        #[allow(clippy::ignored_unit_patterns)]
         loop {
             tokio::select! {
                 output = &mut self.exec_future => {

brush-core/src/sys/stubs.rs

@@ -1,8 +1,10 @@
 #![allow(dead_code)]
+#![allow(clippy::missing_const_for_fn)]
+#![allow(clippy::needless_pass_by_ref_mut)]
 #![allow(clippy::needless_pass_by_value)]
+#![allow(clippy::unnecessary_wraps)]
 #![allow(clippy::unused_async)]
 #![allow(clippy::unused_self)]
-#![allow(clippy::unnecessary_wraps)]
 
 pub(crate) mod fs;
 pub(crate) mod input;

brush-core/src/sys/stubs/pipes.rs

@@ -4,14 +4,14 @@ pub(crate) struct PipeReader {}
 
 impl PipeReader {
     /// Tries to clone the reader.
-    pub fn try_clone(&self) -> std::io::Result<PipeReader> {
+    pub fn try_clone(&self) -> std::io::Result<Self> {
         Ok((*self).clone())
     }
 }
 
 impl From<PipeReader> for std::process::Stdio {
     fn from(_reader: PipeReader) -> Self {
-        std::process::Stdio::null()
+        Self::null()
     }
 }
 
@@ -28,14 +28,14 @@ pub(crate) struct PipeWriter {}
 
 impl PipeWriter {
     /// Tries to clone the writer.
-    pub fn try_clone(&self) -> std::io::Result<PipeWriter> {
+    pub fn try_clone(&self) -> std::io::Result<Self> {
         Ok((*self).clone())
     }
 }
 
 impl From<PipeWriter> for std::process::Stdio {
     fn from(_writer: PipeWriter) -> Self {
-        std::process::Stdio::null()
+        Self::null()
     }
 }
 

brush-core/src/sys/windows/users.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::missing_const_for_fn)]
+
 use crate::error;
 use std::path::PathBuf;
 
@@ -31,6 +33,7 @@ pub(crate) fn get_current_username() -> Result<String, error::Error> {
     Ok(username)
 }
 
+#[allow(clippy::unnecessary_wraps)]
 pub(crate) fn get_user_group_ids() -> Result<Vec<u32>, error::Error> {
     // TODO: implement some version of this for Windows
     Ok(vec![])

brush-parser/benches/parser.rs

@@ -76,4 +76,4 @@ criterion::criterion_group! {
 criterion::criterion_main!(benches);
 
 #[cfg(not(unix))]
-fn main() -> () {}
+fn main() {}

brush-shell/tests/compat_tests.rs

@@ -2,7 +2,7 @@
 
 // Only compile this for Unix-like platforms (Linux, macOS) because they have an oracle to compare
 // against.
-#![cfg(unix)]
+#![cfg(any(unix, windows))]
 
 use anyhow::{Context, Result};
 use assert_fs::fixture::{FileWriteStr, PathChild};
@@ -11,6 +11,7 @@ use colored::Colorize;
 use descape::UnescapeExt;
 use serde::{Deserialize, Serialize};
 use std::fs;
+#[cfg(unix)]
 use std::os::unix::{fs::PermissionsExt, process::ExitStatusExt};
 use std::{
     collections::{HashMap, HashSet},
@@ -932,6 +933,7 @@ impl TestCase {
                 test_file_path.write_str(test_file.contents.as_str())?;
             }
 
+            #[cfg(unix)]
             if test_file.executable {
                 // chmod u+x
                 let mut perms = test_file_path.metadata()?.permissions();
@@ -1094,6 +1096,13 @@ impl TestCase {
     }
 
     #[expect(clippy::unused_async)]
+    #[cfg(not(unix))]
+    async fn run_command_with_pty(&self, _cmd: std::process::Command) -> Result<RunResult> {
+        Err(anyhow::anyhow!("pty test not supported on this platform"))
+    }
+
+    #[expect(clippy::unused_async)]
+    #[cfg(unix)]
     async fn run_command_with_pty(&self, cmd: std::process::Command) -> Result<RunResult> {
         use expectrl::Expect;
 
@@ -1553,6 +1562,7 @@ impl TestOptions {
     }
 }
 
+#[cfg(unix)]
 fn read_expectrl_log(log: Vec<u8>) -> Result<String> {
     let output_str = String::from_utf8(log)?;
     let output: String = output_str