"Expand [Plugin]" generates a single [Image] for steps with both Pre- and Post-Image

[sybaris]

Describe the bug
The "Expand [Plugin] attribute and add [Step] and [Image] attributes" refactoring (Plugin Registration Refactoring Action) silently drops images when a single step has more than one image registered in Dataverse. For a step that has both a Pre-Image and a Post-Image, only one [Image] attribute is generated instead
of two.

Example: a step (Update / PostOperation / Asynchronous) has two images registered on the same sdkmessageprocessingstepid:

• a PreImage (imagetype = 0)
• a PostImage (imagetype = 1)

Only the first image is generated:

[Plugin]
[Step("Update", "account", "field1,field2", Stages.PreOperation, ExecutionMode.Synchronous)]
[Step("Update", "account", "field1,field2", Stages.PostOperation, ExecutionMode.Asynchronous)]
[Image(ImageTypes.PreImage, "field1,field2")]
// <-- the PostImage on the PostOperation step is missing

Likely root cause: In WebApiServiceHelper.GetPluginDefinitionAsync, the plugin definition is retrieved with a hard-coded page size:

var response = await webApi.RetrieveMultipleAsync(odataQuery, 2); // maxPageSize = 2

The query uses a two-level nested $expand (plugintype → step → image). With maxPageSize = 2 and no handling of @odata.nextLink for the nested expanded collections, the Images collection of a step appears to be truncated, so SdkMessageProcessingStep.Images is incomplete before the code generator
(PluginRefactoringProvider.ApplyPluginFixAsync) iterates over it. The generator itself is fine — it emits every image in step.Images — so the data is lost during retrieval, not during generation.

To Reproduce
Steps to reproduce the behavior:

1. In Dataverse, register a plugin step that has two images on the same step (one Pre-Image and one Post-Image), for example on an Update / PostOperation / Asynchronous step.
2. In Visual Studio, on the corresponding plugin class, add the [Plugin] attribute.
3. Select an environment in Xrm Tools, then trigger the light bulb / Ctrl + . → "Expand [Plugin] attribute and add [Step] and [Image] attributes".
4. Observe the generated attributes: only one [Image] is produced for the step, the second image is silently missing.

Expected behavior
Both images should be generated for the step, e.g.:

[Step("Update", "account", "field1,field2", Stages.PostOperation, ExecutionMode.Asynchronous)]
[Image(ImageTypes.PreImage, "field1,field2")]
[Image(ImageTypes.PostImage, "field1,field2,field3")]

More generally, the retrofit should retrieve and generate all steps and all images regardless of count, by following @odata.nextLink on nested expanded collections (or by not constraining maxPageSize so aggressively for this query).

Setup (please complete the following information):

• OS: Win11
• Visual Studio Version 18.7.2
• Xrm Tools Version 1.6.0.95

[ChristianMichna]

Oh interesting this might be what caused an incomplete registration definition for us in the past.

[rezanid]

Thanks for reporting this issue with such good details.

[rezanid]

Apparently it does not happen when you have one plugin step with two images:

Here is the query that's been generated for the expand:

plugintypes?$filter=typenam eq 'BlahBlah.Plugins.PostUpdateOption'&$select=plugintypeid,name,typename,friendlyname,description,workflowactivitygroupname&$expand=plugintype_sdkmessageprocessingstep($select=sdkmessageprocessingstepid,name,stage,asyncautodelete,description,filteringattributes,invocationsource,mode,rank,sdkmessageid,statecode,supporteddeployment%3b$expand=sdkmessageprocessingstepid_sdkmessageprocessingstepimage($select=sdkmessageprocessingstepimageid,name,imagetype,messagepropertyname,attributes,entityalias),sdkmessagefilterid($select=primaryobjecttypecod),sdkmessageid($select=nam))

And the payload in response:

{
  "@odata.context": "https://be-fsi-accelerator-dev.crm4.dynamics.com/api/data/v9.2/$metadata#plugintypes(plugintypeid,name,typename,friendlyname,description,workflowactivitygroupname,plugintype_sdkmessageprocessingstep(sdkmessageprocessingstepid,name,stage,asyncautodelete,description,filteringattributes,invocationsource,mode,rank,sdkmessageid,statecode,supporteddeployment,sdkmessageprocessingstepid_sdkmessageprocessingstepimage(sdkmessageprocessingstepimageid,name,imagetype,messagepropertyname,attributes,entityalias),sdkmessagefilterid(primaryobjecttypecode),sdkmessageid(name)))",
  "value": [
    {
      "@odata.etag": "W/\"6486751\"",
      "workflowactivitygroupname": null,
      "typename": "BlahBlah.Plugins.PostUpdateOption",
      "friendlyname": "{98d24628-da91-453e-83af-778d71394e1f}",
      "name": "BlahBlah.Plugins.PostUpdateOption",
      "plugintypeid": "751c2b24-c46f-f111-ab0d-000d3ab55a6a",
      "description": null,
      "plugintype_sdkmessageprocessingstep": [
        {
          "sdkmessageprocessingstepid": "b11d67ce-80e2-5bc0-b48a-42eb3779951f",
          "invocationsource": 1,
          "mode": 0,
          "supporteddeployment": 0,
          "statecode": 0,
          "name": "BlahBlah.Plugins.PostUpdateOption : PostOperation Update of rn_option",
          "asyncautodelete": false,
          "rank": 1,
          "description": null,
          "stage": 40,
          "filteringattributes": null,
          "sdkmessageprocessingstepid_sdkmessageprocessingstepimage": [
            {
              "sdkmessageprocessingstepimageid": "6e003766-8055-50ac-bfde-96a361c71af6",
              "name": "RnOptionPostImage",
              "imagetype": 1,
              "entityalias": "BeroptionPostImage",
              "messagepropertyname": "Target",
              "attributes": "rn_isdefault"
            },
            {
              "sdkmessageprocessingstepimageid": "a2d0f681-4731-5b3b-8b45-f8bf9e0a3b88",
              "name": "RnOptionPreImage",
              "imagetype": 0,
              "entityalias": "RnOptionPreImage",
              "messagepropertyname": "Target",
              "attributes": "rn_isdefault"
            }
          ],
          "sdkmessagefilterid": {
            "sdkmessagefilterid": "5f6b55b7-2b01-f111-8407-7ced8d48ab20",
            "primaryobjecttypecode": "rn_option"
          },
          "sdkmessageid": {
            "name": "Update",
            "sdkmessageid": "20bebb1b-ea3e-db11-86a7-000a3a5473e8"
          }
        }
      ]
    }
  ]
}

When I increased the number of steps to two however the last image disappeared from the response. In a new version -- to be published tonight I removed the page size to fix this issue. I am not expecting a plugin with thousands of steps and images.