Skip to content

Commit 986e7b7

Browse files
committed
fix(templates): address review follow-ups
Remove duplicate PageIntro spacing and switch template children types to ReactNode imports.
1 parent 21c38e9 commit 986e7b7

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1+
import type { ReactNode } from "react";
2+
13
export interface BlogPostTemplateProps {
24
title: string;
35
description: string;
46
dateIso: string;
57
dateLabel: string;
68
author: string;
79
tags: readonly string[];
8-
children?: React.ReactNode;
10+
children?: ReactNode;
911
}

src/components/templates/ResourcesDetailTemplate/ResourcesDetailTemplate.types.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import type { ReactNode } from "react";
2+
13
export interface RelatedResourceLink {
24
title: string;
35
href: string;
@@ -17,5 +19,5 @@ export interface ResourcesDetailTemplateProps {
1719
canonicalLabel: string;
1820
relatedResourcesTitle: string;
1921
relatedResources: readonly RelatedResourceLink[];
20-
children?: React.ReactNode;
22+
children?: ReactNode;
2123
}

src/components/templates/ResourcesIndexTemplate/ResourcesIndexTemplate.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const ResourcesIndexTemplate = ({
1414
resources,
1515
}: ResourcesIndexTemplateProps) => (
1616
<div className="mx-auto max-w-7xl px-4 py-12 sm:px-6 lg:px-8">
17-
<PageIntro title={title} description={description} className="mb-8" />
17+
<PageIntro title={title} description={description} />
1818

1919
{resources.length === 0 ? (
2020
<p className="text-secondary-600">{emptyState}</p>

0 commit comments

Comments
 (0)