Merge pull request #138 from Adeyemi-cmd/Add_Campaign_Goal

feat: add campaign goal edit endpoint for creators

Author: ritik4ever

backend/src/index.ts

@@ -7,6 +7,8 @@ import { config, walletIntegrationReady } from "./config";
 import {
   addPledge,
   calculateProgress,
+  CampaignProgress,
+  CampaignRecord,
   CampaignStatus,
   claimCampaign,
   createCampaign,
@@ -19,6 +21,7 @@ import {
   softDeleteCampaign,
   reconcileOnChainPledge,
   refundContributor,
+  updateCampaign,
 } from "./services/campaignStore";
 import { checkDbHealth } from "./services/db";
 import { getCampaignHistory } from "./services/eventHistory";
@@ -34,13 +37,14 @@ import {
   parseCampaignListPaginationQuery,
   reconcilePledgePayloadSchema,
   refundPayloadSchema,
+  updateCampaignPayloadSchema,
   zodIssuesToErrorMessage,
   zodIssuesToValidationIssues,
 } from "./validation/schemas";
 import { logError, logInfo, logRequest } from "./logger";
 
 type RequestWithId = Request & { requestId?: string };
-type CampaignListItem = ReturnType<typeof import("./services/campaignStore").getCampaign> & { progress: ReturnType<typeof import("./services/campaignStore").calculateProgress> };
+
 
 export const app = express();
 
@@ -322,7 +326,7 @@ app.post("/api/campaigns", (req: Request, res: Response) => {
   res.status(201).json({ data: { ...campaign, progress: calculateProgress(campaign) } });
 });
 
-app.post("/api/campaigns/:id/pledges", applyRateLimit(WRITE_RATE_LIMIT_MAX_REQUESTS), (req: Request, res: Response) => {
+
   const parsedId = parseCampaignId(req.params.id);
   if (!parsedId.ok) {
     sendValidationError(parsedId.issues);

backend/src/services/campaignStore.test.ts

@@ -19,6 +19,7 @@ let createCampaign: CampaignStoreModule["createCampaign"];
 let initCampaignStore: CampaignStoreModule["initCampaignStore"];
 let listCampaigns: CampaignStoreModule["listCampaigns"];
 let reconcileOnChainPledge: CampaignStoreModule["reconcileOnChainPledge"];
+let updateCampaign: CampaignStoreModule["updateCampaign"];
 let getCampaign: CampaignStoreModule["getCampaign"];
 let getPledges: CampaignStoreModule["getPledges"];
 let getGlobalStats: CampaignStoreModule["getGlobalStats"];
@@ -40,6 +41,7 @@ beforeAll(async () => {
     initCampaignStore,
     listCampaigns,
     reconcileOnChainPledge,
+    updateCampaign,
     getCampaign,
     getPledges,
 
@@ -165,4 +167,3 @@ describe("on-chain pledge reconciliation", () => {
   });
 });
 
-

backend/src/services/campaignStore.ts

@@ -425,23 +425,7 @@ export function createCampaign(input: CampaignInput): CampaignRecord {
   return campaign;
 }
 
-function checkContributorLimit(
-  campaign: CampaignRecord,
-  contributor: string,
-  amount: number,
-): void {
-  if (campaign.maxPerContributor === undefined) {
-    return;
-  }
 
-  const alreadyPledged = getContributorPledgedTotal(campaign.id, contributor);
-  if (alreadyPledged + amount > campaign.maxPerContributor) {
-    throw toServiceError(
-      `Contributor limit exceeded. Max: ${campaign.maxPerContributor}, Already pledged: ${alreadyPledged}, Attempted: ${amount}`,
-      400,
-      "CONTRIBUTOR_LIMIT_EXCEEDED",
-    );
-  }
 }
 
 export function addPledge(campaignId: string, input: PledgeInput): CampaignRecord {

backend/src/services/eventHistory.ts

@@ -1,6 +1,6 @@
 import { getDb } from "./db";
 
-export type CampaignEventType = "created" | "pledged" | "claimed" | "refunded";
+export type CampaignEventType = "created" | "pledged" | "claimed" | "refunded" | "updated";
 
 export interface BlockchainMetadata {
   txHash?: string;

backend/src/validation/schemas.ts

@@ -110,76 +110,6 @@ export const refundPayloadSchema = z.object({
   soroban: sorobanRefundMetadataSchema,
 });
 
-function singleCampaignListQueryParam(value: unknown): string | undefined {
-  if (value === undefined || value === null) {
-    return undefined;
-  }
-  const raw = Array.isArray(value) ? value[0] : value;
-  if (typeof raw !== "string" && typeof raw !== "number") {
-    return undefined;
-  }
-  const s = String(raw).trim();
-  return s === "" ? undefined : s;
-}
-
-/**
- * Parses optional `page` and `limit` for GET /api/campaigns.
- * Omitting both means no pagination (caller lists the full filtered set).
- * Supplying only one is invalid (400).
- */
-export function parseCampaignListPaginationQuery(query: {
-  page?: unknown;
-  limit?: unknown;
-}): { ok: true; page?: number; limit?: number } | { ok: false; issues: z.core.$ZodIssue[] } {
-  const pageStr = singleCampaignListQueryParam(query.page);
-  const limitStr = singleCampaignListQueryParam(query.limit);
-
-  if (pageStr === undefined && limitStr === undefined) {
-    return { ok: true };
-  }
-  if (pageStr === undefined || limitStr === undefined) {
-    return {
-      ok: false,
-      issues: [
-        {
-          code: "custom",
-          message: "Pagination requires both page and limit query parameters.",
-          path: pageStr === undefined ? ["page"] : ["limit"],
-        },
-      ],
-    };
-  }
-
-  const pageNum = Number(pageStr);
-  const limitNum = Number(limitStr);
-  const issues: z.core.$ZodIssue[] = [];
-
-  if (!Number.isFinite(pageNum) || !Number.isInteger(pageNum) || pageNum < 1) {
-    issues.push({
-      code: "custom",
-      message: "page must be a positive integer.",
-      path: ["page"],
-    });
-  }
-  if (
-    !Number.isFinite(limitNum) ||
-    !Number.isInteger(limitNum) ||
-    limitNum < 1 ||
-    limitNum > 100
-  ) {
-    issues.push({
-      code: "custom",
-      message: "limit must be an integer from 1 to 100.",
-      path: ["limit"],
-    });
-  }
-
-  if (issues.length > 0) {
-    return { ok: false, issues };
-  }
-
-  return { ok: true, page: pageNum, limit: limitNum };
-}
 
 
 export type ValidationIssue = {