feat(core): add resilient fetch with timeout and retry across all clients (#189)

* feat(core): add resilient fetch with timeout and retry across all clients

Closes #179

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor(clients): centralize configureRawClient in base class

Move the repeated setConfig({ baseUrl, headers, fetch }) call from each
subclass into ServarrBaseClient. Subclasses now just pass their generated
client to super() instead of duplicating the configuration logic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: preserve timeout semantics and retry request bodies

* fix: align biome schema with CI

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: robbeverhelst

biome.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.4.6/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.4.12/schema.json",
   "vcs": {
     "enabled": true,
     "clientKind": "git",

src/clients/base.ts

@@ -72,23 +72,31 @@ export interface ServarrOps {
   updateUiConfig: ApiCall;
 }
 
+interface RawClient {
+  setConfig(config: Record<string, unknown>): unknown;
+}
+
 export abstract class ServarrBaseClient {
   protected clientConfig: ReturnType<typeof createServarrClient>;
+  protected readonly rawClient: RawClient;
 
   protected abstract readonly ops: ServarrOps;
 
-  constructor(config: ServarrClientConfig) {
+  constructor(config: ServarrClientConfig, rawClient: RawClient) {
+    this.rawClient = rawClient;
     this.clientConfig = createServarrClient(config);
     this.configureRawClient();
   }
 
-  protected abstract configureRawClient(): void;
+  protected configureRawClient(): void {
+    this.rawClient.setConfig(this.getClientConfig());
+  }
 
   protected getClientConfig() {
     return {
       baseUrl: this.clientConfig.getBaseUrl(),
       headers: this.clientConfig.getHeaders(),
-      signal: AbortSignal.timeout(this.clientConfig.getTimeout()),
+      fetch: this.clientConfig.getFetch(),
     };
   }
 

src/clients/bazarr.ts

@@ -40,7 +40,7 @@ export class BazarrClient {
       baseUrl: getBazarrApiBaseUrl(this.clientConfig.getBaseUrl()),
       headers: getBazarrHeaders(this.clientConfig),
       auth: this.clientConfig.config.apiKey,
-      signal: AbortSignal.timeout(this.clientConfig.getTimeout()),
+      fetch: this.clientConfig.getFetch(),
     });
   }
 
@@ -700,7 +700,7 @@ export class BazarrClient {
       baseUrl: getBazarrApiBaseUrl(this.clientConfig.getBaseUrl()),
       headers: getBazarrHeaders(this.clientConfig),
       auth: this.clientConfig.config.apiKey,
-      signal: AbortSignal.timeout(this.clientConfig.getTimeout()),
+      fetch: this.clientConfig.getFetch(),
     });
 
     return this.clientConfig.config;

src/clients/lidarr.ts

@@ -1,4 +1,5 @@
 import { ServarrBaseClient, type ServarrOps } from '../clients/base';
+import type { ServarrClientConfig } from '../core/types';
 import { client as lidarrClient } from '../generated/lidarr/client.gen';
 import * as LidarrApi from '../generated/lidarr/index';
 import type {
@@ -98,8 +99,8 @@ export class LidarrClient extends ServarrBaseClient {
     updateUiConfig: LidarrApi.putApiV1ConfigUiById,
   };
 
-  protected configureRawClient(): void {
-    lidarrClient.setConfig(this.getClientConfig());
+  constructor(config: ServarrClientConfig) {
+    super(config, lidarrClient);
   }
 
   // Artist APIs

src/clients/prowlarr.ts

@@ -1,4 +1,5 @@
 import { ServarrBaseClient, type ServarrOps } from '../clients/base';
+import type { ServarrClientConfig } from '../core/types';
 import { client as prowlarrClient } from '../generated/prowlarr/client.gen';
 import * as ProwlarrApi from '../generated/prowlarr/index';
 import type {
@@ -89,8 +90,8 @@ export class ProwlarrClient extends ServarrBaseClient {
     updateUiConfig: ProwlarrApi.putApiV1ConfigUiById,
   };
 
-  protected configureRawClient(): void {
-    prowlarrClient.setConfig(this.getClientConfig());
+  constructor(config: ServarrClientConfig) {
+    super(config, prowlarrClient);
   }
 
   // Prowlarr-specific APIs

src/clients/qbittorrent.ts

@@ -1,4 +1,5 @@
 import { ConnectionError } from '../core/errors';
+import { createResilientFetch } from '../core/fetch';
 import type { QBittorrentClientConfig } from '../core/types';
 import { client as qbittorrentClient } from '../generated/qbittorrent/client.gen';
 import * as QBittorrentApi from '../generated/qbittorrent/index';
@@ -33,7 +34,7 @@ export class QBittorrentClient {
   private username: string;
   private password: string;
   private sid: string | null = null;
-  private timeoutMs: number;
+  private fetch: typeof globalThis.fetch;
 
   constructor(config: QBittorrentClientConfig) {
     if (!config.baseUrl) {
@@ -43,12 +44,15 @@ export class QBittorrentClient {
     this.baseUrl = config.baseUrl.replace(/\/$/, '');
     this.username = config.username;
     this.password = config.password;
-    this.timeoutMs = config.timeout ?? DEFAULT_TIMEOUT_MS;
+    this.fetch = createResilientFetch({
+      timeout: config.timeout ?? DEFAULT_TIMEOUT_MS,
+      retry: config.retry,
+    });
 
     qbittorrentClient.setConfig({
       baseUrl: `${this.baseUrl}/api/v2`,
       auth: () => this.ensureAuth(),
-      signal: AbortSignal.timeout(this.timeoutMs),
+      fetch: this.fetch,
     });
   }
 
@@ -60,7 +64,7 @@ export class QBittorrentClient {
   }
 
   private async login(): Promise<void> {
-    const response = await fetch(`${this.baseUrl}/api/v2/auth/login`, {
+    const response = await this.fetch(`${this.baseUrl}/api/v2/auth/login`, {
       method: 'POST',
       headers: {
         'Content-Type': 'application/x-www-form-urlencoded',
@@ -70,7 +74,6 @@ export class QBittorrentClient {
         username: this.username,
         password: this.password,
       }),
-      signal: AbortSignal.timeout(this.timeoutMs),
     });
 
     if (!response.ok) {

src/clients/radarr.ts

@@ -1,4 +1,5 @@
 import { ServarrBaseClient, type ServarrOps } from '../clients/base';
+import type { ServarrClientConfig } from '../core/types';
 import { client as radarrClient } from '../generated/radarr/client.gen';
 import * as RadarrApi from '../generated/radarr/index';
 import type {
@@ -84,8 +85,8 @@ export class RadarrClient extends ServarrBaseClient {
     updateUiConfig: RadarrApi.putApiV3ConfigUiById,
   };
 
-  protected configureRawClient(): void {
-    radarrClient.setConfig(this.getClientConfig());
+  constructor(config: ServarrClientConfig) {
+    super(config, radarrClient);
   }
 
   // Movie APIs

src/clients/readarr.ts

@@ -1,4 +1,5 @@
 import { ServarrBaseClient, type ServarrOps } from '../clients/base';
+import type { ServarrClientConfig } from '../core/types';
 import { client as readarrClient } from '../generated/readarr/client.gen';
 import * as ReadarrApi from '../generated/readarr/index';
 import type {
@@ -98,8 +99,8 @@ export class ReadarrClient extends ServarrBaseClient {
     updateUiConfig: ReadarrApi.putApiV1ConfigUiById,
   };
 
-  protected configureRawClient(): void {
-    readarrClient.setConfig(this.getClientConfig());
+  constructor(config: ServarrClientConfig) {
+    super(config, readarrClient);
   }
 
   // Author APIs

src/clients/seerr.ts

@@ -40,7 +40,7 @@ export class SeerrClient {
         'X-Api-Key': this.clientConfig.config.apiKey,
         ...(this.clientConfig.config.headers ?? {}),
       },
-      signal: AbortSignal.timeout(this.clientConfig.getTimeout()),
+      fetch: this.clientConfig.getFetch(),
     });
   }
 
@@ -140,7 +140,7 @@ export class SeerrClient {
         'X-Api-Key': this.clientConfig.config.apiKey,
         ...(this.clientConfig.config.headers ?? {}),
       },
-      signal: AbortSignal.timeout(this.clientConfig.getTimeout()),
+      fetch: this.clientConfig.getFetch(),
     });
 
     return this.clientConfig.config;

src/clients/sonarr.ts

@@ -1,4 +1,5 @@
 import { ServarrBaseClient, type ServarrOps } from '../clients/base';
+import type { ServarrClientConfig } from '../core/types';
 import { client as sonarrClient } from '../generated/sonarr/client.gen';
 import * as SonarrApi from '../generated/sonarr/index';
 import type {
@@ -98,8 +99,8 @@ export class SonarrClient extends ServarrBaseClient {
     updateUiConfig: SonarrApi.putApiV3ConfigUiById,
   };
 
-  protected configureRawClient(): void {
-    sonarrClient.setConfig(this.getClientConfig());
+  constructor(config: ServarrClientConfig) {
+    super(config, sonarrClient);
   }
 
   // Override since Sonarr doesn't have generated system status endpoints