Not a bug. Just wanted to share the Docker image.

[trip5]

I made a decently-enough working Docker image using this script here: https://registry.hub.docker.com/r/darkpoet78/flac2mp3

I've linked to this Github source, of course.

Thanks Robin. This is exactly the reason I upgraded my NAS to a Synology that works with Docker. Thank you for such an awesome script!

[trip5]

I do have one question. I tried playing around with these arguments and I don't know perl so I can't read your code to figure it out.

--skipfilename   Specify the name of the skip file.
                 Default: flac2mp3.ignore

I assume this reads a file but I've tried all sorts of formats inside the file (from plain text to various forms of regex)... still can't figure it out. Can this be used to ignore an entire folder? For example, I'd like to ignore the folder "Collection" in my flac collection.

And do I understand this argument?

--noskipfile     Ignore any skip files

It seems to pass on every file to the flac decoder, even jpg files. Heh.

[kosli]

@trip5 is the source of your Docker image available? I couldn't find the repo :-( Thanks.

[trip5]

Oh. I made that docker image before I knew what I was doing. Do you mean the dockerfile?

Actually it looks like I haven't done anything significant to it since then... partly because I really didn't know what I was doing at the time, really really. And it worked so when I needed to "adjust" the script, I would literally just mount an edited .pl file to make it work the way I wanted it to without changing the docker image at all...

I haven't tried to reconstruct the image in years, partly because my notes are such a a mess...

Lol my mess of a work folder from 5 years ago contains multiple dockerfiles. I think this is the right one because it seems to match here: https://hub.docker.com/layers/darkpoet78/flac2mp3/1.1/images/sha256-f20f3b7344b38a6dc6e657b7e96c48409dc23649ad7029eeb8bb5f193d4c19fa (except for the entrypoint):

FROM alpine:3.9
ENV PGID 101
ENV PUID 1024
ENV TZ Asia/Seoul
ENV ARGS --copyfiles
ENV SYNCDELETE 0
RUN echo 'http://dl-cdn.alpinelinux.org/alpine/v3.3/main' >> /etc/apk/repositories
RUN apk add --no-cache bash \
    lame \
    flac \
    'perl==5.22.3-r0' \
    shadow \
    tzdata
RUN groupadd --gid "${PGID}" -r app
RUN useradd -u "${PUID}" -r -g app -d /flac2mp3 -s /sbin/nologin -c "Docker Image User" app
COPY flac2mp3.sh /flac2mp3.sh
ADD flac2mp3 /flac2mp3
ENTRYPOINT ["/bin/bash", "/flac2mp3.sh"]

And the entryfile, init.sh which clearly doesn't match the above entrypoint above but I'm pretty sure the one I used:

#!/bin/bash
# Set TimeZone
export TZ='$TZ'
if [ "$SYNCDELETE" == "1" ] ; then
echo SYNCDELETE on.  Removing files from /out/ not found in /in/...
# thanks to roaima here: https://unix.stackexchange.com/questions/559751/
find /out -type f -exec bash -c '
    for mp in "$0" "$@";
    do
        mf="${mp#/out/}";    # Strip /out/ base prefix leaving relative pathname
		[[ "${mf##*.}" == "mp3" ]] && mf="${mf%.mp3}.flac";    # convert filename to flac if it was mp3
        [[ ! -f "/in/$mf" ]] && echo Deleting $mp && rm "$mp";    # remove /out/ file if no match
    done
' {} +
#remove empty directories
find /out/. -depth -type d -exec rmdir {} + 2>/dev/null
fi
#USERID Switch
groupadd -g "${PGID}" -r app
groupmod -g ${PGID} app
useradd -u "${PUID}" -r -g app -d /flac2mp3 -s /bin/bash -c "Docker Image User" app
echo "Switching UID and GID"
chown -R ${PUID}:${PGID} /out
sudo -i -u app bash << EOF
whoami
perl /flac2mp3/flac2mp3.pl $ARGS /in /out
EOF
exit 0

The folder flac2mp3 just contains the entire repo from here, with an edited script. I commented out the line # 'BAND' => 'TPE2', because that tag reacts weirdly to my players.

As you can see, pretty simple . I do remember fiddling with various versions of perl and that's the version that works. Anything higher and you risk errors...

Does that help?

[kosli]

Thanks @trip5 I will adapt my Ubuntu container to a more lightweight version with your alpine and have ea look at the the SYNCDELETE part, as I thought this was covered by flac2mp3 itself. As my source directory contains already some mp3 files, i'll have to see how to adapt your deletion logic accordingly.

[trip5]

I'm looking at it now and I'm wondering why I did the UID and GID switch AFTER doing the Syncdelete stuff. As I said, I really didn't know what I was doing. I probably got away with it by running the container as admin.

I'm curious how you do. I still run this container.