fix(debugger): improve termination handling

fixes: [BUG] OSError: [Errno 22] Invalid argument and No incoming connection from debugger client #389

Author: d-biehl

package.json

@@ -1768,11 +1768,13 @@
                   "string"
                 ],
                 "enum": [
+                  "none",
                   "default",
                   "test",
                   "test-profile"
                 ],
                 "markdownEnumDescriptions": [
+                  "No purpose defined.",
                   "Configuration is uses as default for all other configurations.",
                   "Default configuration for running or debugging tests.",
                   "Defines a test profile that you can select in the test explorer or via the play button during a test. This configuration is used instead of the configuration with the purpose `test`."
@@ -1781,11 +1783,13 @@
                 "description": "Defines what purpose this configuration has.",
                 "items": {
                   "enum": [
+                    "none",
                     "default",
                     "test",
                     "test-profile"
                   ],
                   "markdownEnumDescriptions": [
+                    "No purpose defined.",
                     "Configuration is uses as default for all other configurations.",
                     "Default configuration for running or debugging tests.",
                     "Defines a test profile that you can select in the test explorer or via the play button during a test. This configuration is used instead of the configuration with the purpose `test`."

packages/debugger/src/robotcode/debugger/dap_types.py

@@ -622,6 +622,26 @@ class TerminateResponse(Response):
     pass
 
 
+class RestartArguments(Model):
+    arguments: Union[LaunchRequestArguments | AttachRequestArguments]
+
+
+@dataclass
+class _RestartRequest:
+    arguments: Optional[RestartArguments] = None
+
+
+@dataclass
+class RestartRequest(Request, _RestartRequest):
+    arguments: Optional[RestartArguments] = None
+    command: str = "restart"
+
+
+@dataclass
+class RestartResponse(Response):
+    pass
+
+
 @dataclass
 class StackFrameFormat(Model):
     parameters: Optional[bool] = None

packages/debugger/src/robotcode/debugger/debugger.py

@@ -449,6 +449,10 @@ def check_thread_id(self, thread_id: int) -> None:
         if not self.main_thread_is_alive and thread_id != self.main_thread_id:
             raise InvalidThreadIdError(thread_id, self.main_thread_id)
 
+    def continue_all_if_paused(self) -> None:
+        if self.state == State.Paused:
+            self.continue_all()
+
     def continue_all(self) -> None:
         if self.main_thread_is_alive:
             self.continue_thread(self.main_thread_id)

packages/debugger/src/robotcode/debugger/run.py

@@ -260,12 +260,12 @@ def run_debugger(
                     )
                 )
 
-                server.protocol.exit(exit_code)
     except CancelledError:
         pass
     finally:
         if server.protocol.connected:
             server.protocol.terminate()
+            server.protocol.exit(exit_code)
 
             if not server.protocol.wait_for_disconnected():
                 app.verbose("Timeout to get disconnected from client")

packages/debugger/src/robotcode/debugger/server.py

@@ -189,19 +189,21 @@ def terminate(self) -> None:
     async def _terminate(
         self,
         arguments: Optional[TerminateArguments] = None,
+        restart: Optional[bool] = None,
         *args: Any,
         **kwargs: Any,
     ) -> None:
-        if not self._sigint_signaled:
+        Debugger.instance().terminate()
+
+        if not restart and not self._sigint_signaled:
             self._logger.info("Send SIGINT to process")
             signal.raise_signal(signal.SIGINT)
             self._sigint_signaled = True
-            # Debugger.instance().continue_all()
+
+            Debugger.instance().continue_all_if_paused()
         else:
             await self.send_event_async(Event("terminateRequested"))
 
-            Debugger.instance().terminate()
-
             self._logger.info("Send SIGTERM to process")
             signal.raise_signal(signal.SIGTERM)
 

tests/robotcode/language_server/robotframework/parts/data/.vscode/launch.json

@@ -38,21 +38,18 @@
             "presentation": {
                 "hidden": true
             },
-        },
-        {
-            "name": "RobotCode: Default",
-            "type": "robotcode",
-            "request": "launch",
-            "purpose": "test",
-            "presentation": {
-                "hidden": true
-            },
             // "robotCodeArgs": [
             //     "-v",
             //     "--log",
             //     "--log-level=TRACE",
             //     "--log-calls"
             // ],
+            // "launcherExtraArgs": [
+            //     "-v",
+            //     "--log",
+            //     "--log-level=TRACE",
+            //     "--log-calls"
+            // ],
             "profiles": [
                 "ci*",
                 "firefox",