Fix master CI route-404: remove AppDomain force-load that locks out PluginLoader (#14)

Stop force-loading the SamRockProtocol assembly into the AppDomain from the test fixture ctor. PluginManager scans AppDomain first and registers any plugin it finds with Loader=null, which dedup-locks out the file-based DEBUG_PLUGINS / plugins-folder path that would register a non-null PluginLoader. With Loader=null, mvcBuilder.AddPluginLoader is skipped at PluginManager.cs:255 and the plugin's controllers never make it into MVC ApplicationParts - the plugin shows in DI but all its routes 404.

Removing the force-load lets the file-based path resolve the plugin via PluginLoader.CreateFromAssemblyFile (Loader non-null) and registers the controllers with MVC.

Retry-with-backoff on the OTP create call kept as cheap defense for any residual timing window.

Author: r1ckstardev

SamRockProtocol.Tests/SamRockProtocolHappyPathTest.cs

@@ -62,13 +62,31 @@ public async Task SamRockProtocol_AcceptsAquaDescriptors()
             $"{user.RegisterDetails.Email}:{user.RegisterDetails.Password}"));
         client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Basic", basic);
 
+        // Retry the OTP create call up to ~10s on 404. Background: the plugin's
+        // controllers can race ServerTester boot - the plugin assembly is loaded
+        // and the IBTCPayServerPlugin shows in DI (logged above), but MVC
+        // ApplicationParts may not have registered the plugin's controllers by
+        // the time this request fires. The race rate is low but non-zero on CI;
+        // master run #22 vs. PR-branch run #21 had identical tree SHAs and one
+        // 404'd while the other passed. Retry until the route is reachable or
+        // the warm-up budget elapses.
         var otpReqBody = new { btc = true, btcln = false, lbtc = true };
-        var otpReq = new StringContent(JsonSerializer.Serialize(otpReqBody), Encoding.UTF8, "application/json");
-        var otpResp = await client.PostAsync($"api/v1/stores/{storeId}/samrock/otps", otpReq);
-        var otpRespBody = await otpResp.Content.ReadAsStringAsync();
-        _helper.WriteLine($"OTP create response ({(int)otpResp.StatusCode}): {otpRespBody}");
+        HttpResponseMessage otpResp = null;
+        string otpRespBody = null;
+        const int otpMaxAttempts = 20;
+        const int otpDelayMs = 500;
+        for (var attempt = 1; attempt <= otpMaxAttempts; attempt++)
+        {
+            var otpReq = new StringContent(JsonSerializer.Serialize(otpReqBody), Encoding.UTF8, "application/json");
+            otpResp = await client.PostAsync($"api/v1/stores/{storeId}/samrock/otps", otpReq);
+            otpRespBody = await otpResp.Content.ReadAsStringAsync();
+            _helper.WriteLine($"OTP create attempt {attempt}/{otpMaxAttempts} ({(int)otpResp.StatusCode}): {otpRespBody}");
+            if (otpResp.StatusCode != System.Net.HttpStatusCode.NotFound)
+                break;
+            await Task.Delay(otpDelayMs);
+        }
         Assert.True(otpResp.IsSuccessStatusCode,
-            $"OTP create expected 2xx, got {(int)otpResp.StatusCode}: {otpRespBody}");
+            $"OTP create expected 2xx after {otpMaxAttempts} attempts, got {(int)otpResp.StatusCode}: {otpRespBody}");
 
         using var otpDoc = JsonDocument.Parse(otpRespBody);
         // Property casing depends on the ASP.NET JSON serializer config. Try both.

SamRockProtocol.Tests/SharedPluginTestFixture.cs

@@ -13,10 +13,15 @@ public ConfigurablePluginTestFixture(string testDirName = "SharedPluginTests", b
     {
         _testDirName = testDirName;
         _useNewDb = useNewDb;
-        // Force-load the SamRockProtocol assembly into the AppDomain so
-        // PluginManager.PreloadPluginsFromAssemblies discovers it via
-        // AppDomain.CurrentDomain.GetAssemblies() before BTCPay startup.
-        _ = typeof(SamRockProtocol.SamRockProtocolPlugin);
+        // Do NOT force-load the SamRockProtocol assembly into the AppDomain
+        // here. PluginManager.AddPlugins scans AppDomain assemblies first and
+        // registers any plugin it finds with Loader=null. Plugins loaded via
+        // that path skip mvcBuilder.AddPluginLoader at PluginManager.cs:255,
+        // which means MVC ApplicationParts never includes the plugin's
+        // assembly -> the IBTCPayServerPlugin shows in DI but its controller
+        // routes 404. Let the DEBUG_PLUGINS / plugins-folder path resolve the
+        // plugin via PluginLoader.CreateFromAssemblyFile so the Loader is
+        // non-null and MVC integration happens.
     }
 
     public ServerTester ServerTester { get; private set; }