Skip to content

Commit 0c8bc30

Browse files
authored
Fix Silabs HAL: also send commands to group bindings (#437)
1 parent 44f74ed commit 0c8bc30

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

docs/changelog_fw.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ Please describe what you are working on, under ## Upcoming
5151
- Changing device type breaks Silabs NVM data
5252
- Reset needed 11 presses instead of 10
5353
- ZHA quirk silently failed to apply on relay-less devices with LED indicators (scene remotes), leaving firmware attributes unreachable from the UI
54+
- Silabs: bindings to Zigbee groups ignored when emitting commands
5455
- **New**
5556
- SONOFF ZBMINIL2 version updates broken?
5657

src/silabs/hal/zigbee.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,11 @@ hal_zigbee_status_t hal_zigbee_send_cmd_to_bindings(const hal_zigbee_cmd *cmd) {
305305
fill_cmd(cmd);
306306

307307
sl_zigbee_af_set_command_endpoints(cmd->endpoint, cmd->endpoint);
308-
sl_status_t st = sl_zigbee_af_send_command_unicast_to_bindings();
309-
return (st == SL_STATUS_OK) ? HAL_ZIGBEE_OK : HAL_ZIGBEE_ERR_SEND_FAILED;
308+
sl_status_t st_unicast = sl_zigbee_af_send_command_unicast_to_bindings();
309+
sl_status_t st_multicast = sl_zigbee_af_send_command_multicast_to_bindings();
310+
311+
return (st_unicast == SL_STATUS_OK || st_multicast == SL_STATUS_OK)
312+
? HAL_ZIGBEE_OK : HAL_ZIGBEE_ERR_SEND_FAILED;
310313
}
311314

312315
hal_zigbee_status_t

0 commit comments

Comments
 (0)