Fix: allow deleting alert_source_urgency_rules_attributes on rootly_alerts_source (#360)

The alert_source_urgency_rules_attributes attribute was declared
Optional+Computed. For optional+computed attributes, removing the block
from config makes Terraform reuse the prior state value instead of
planning it to empty, so HasChange never fired and the deletion was
never sent to the API.

The backend supports full deletion via an empty list (it destroys all
existing rules whenever the key is present) — the provider just wasn't
sending it. Unlike alert_source_fields_attributes, urgency rules are
never auto-created server-side, so Computed was both unnecessary and the
cause of the bug.

Removing Computed lets Terraform detect block removal and send an empty
list, which clears the rules.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: dineshpanda

provider/resource_alerts_source.go

@@ -175,7 +175,6 @@ func resourceAlertsSource() *schema.Resource {
 
 			"alert_source_urgency_rules_attributes": &schema.Schema{
 				Type:             schema.TypeList,
-				Computed:         true,
 				Required:         false,
 				Optional:         true,
 				Sensitive:        false,

provider/resource_alerts_source_test.go

@@ -0,0 +1,71 @@
+package provider
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccResourceAlertsSource_UrgencyRulesDeletion(t *testing.T) {
+	rName := acctest.RandomWithPrefix("tf-alert-source")
+
+	resource.UnitTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: providerFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccResourceAlertsSourceWithUrgencyRule(rName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("rootly_alerts_source.test", "name", rName),
+					resource.TestCheckResourceAttr("rootly_alerts_source.test", "alert_source_urgency_rules_attributes.#", "1"),
+					resource.TestCheckResourceAttr("rootly_alerts_source.test", "alert_source_urgency_rules_attributes.0.json_path", "$.severity"),
+				),
+			},
+			{
+				Config: testAccResourceAlertsSourceWithoutUrgencyRule(rName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("rootly_alerts_source.test", "name", rName),
+					resource.TestCheckResourceAttr("rootly_alerts_source.test", "alert_source_urgency_rules_attributes.#", "0"),
+				),
+			},
+		},
+	})
+}
+
+func testAccResourceAlertsSourceWithUrgencyRule(name string) string {
+	return fmt.Sprintf(`
+resource "rootly_alert_urgency" "test" {
+	name        = "%[1]s-urgency"
+	description = "Test urgency"
+}
+
+resource "rootly_alerts_source" "test" {
+	name        = "%[1]s"
+	source_type = "generic_webhook"
+
+	alert_source_urgency_rules_attributes {
+		json_path        = "$.severity"
+		operator         = "is"
+		value            = "critical"
+		kind             = "payload"
+		alert_urgency_id = rootly_alert_urgency.test.id
+	}
+}
+`, name)
+}
+
+func testAccResourceAlertsSourceWithoutUrgencyRule(name string) string {
+	return fmt.Sprintf(`
+resource "rootly_alert_urgency" "test" {
+	name        = "%[1]s-urgency"
+	description = "Test urgency"
+}
+
+resource "rootly_alerts_source" "test" {
+	name        = "%[1]s"
+	source_type = "generic_webhook"
+}
+`, name)
+}