Skip to content

Commit cc82dd5

Browse files
authored
Adds redis tags to fix package issue (#1685)
Fixes #1683 Using `--tags redis` would filter the `include_vars` out and not import the PHP version specific vars leading to an undefined variable for `redis_packages_default` etc. This fixes that by adding the `redis` tag (just like `memcached` and `php`) to the common task.
1 parent 30c6a10 commit cc82dd5

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

roles/common/tasks/main.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
paths:
2525
- "{{ playbook_dir }}/roles/php/vars/"
2626

27-
tags: [memcached, php, sshd]
27+
tags: [memcached, php, redis, sshd]
2828

2929
- name: Verify dict format for package component variables
3030
fail:
@@ -38,10 +38,12 @@
3838
memcached_packages_custom: "{{ memcached_packages_custom }}"
3939
php_extensions_default: "{{ php_extensions_default }}"
4040
php_extensions_custom: "{{ php_extensions_custom }}"
41+
redis_packages_default: "{{ redis_packages_default }}"
42+
redis_packages_custom: "{{ redis_packages_custom }}"
4143
sshd_packages_default: "{{ sshd_packages_default }}"
4244
sshd_packages_custom: "{{ sshd_packages_custom }}"
4345
package_vars_wrong_format: "{{ package_vars | dict2items | rejectattr('value', 'mapping') | map(attribute='key') | list }}"
44-
tags: [memcached, php, sshd]
46+
tags: [memcached, php, redis, sshd]
4547

4648
- name: Verify dict format for package combined variables
4749
fail:
@@ -52,9 +54,10 @@
5254
apt_packages: "{{ apt_packages }}"
5355
memcached_packages: "{{ memcached_packages }}"
5456
php_extensions: "{{ php_extensions }}"
57+
redis_packages: "{{ redis_packages }}"
5558
sshd_packages: "{{ sshd_packages }}"
5659
package_vars_wrong_format: "{{ package_vars | dict2items | rejectattr('value', 'mapping') | map(attribute='key') | list }}"
57-
tags: [memcached, php, sshd]
60+
tags: [memcached, php, redis, sshd]
5861

5962
- name: Clean old APT sources
6063
import_tasks: clean-apt-sources.yml

0 commit comments

Comments
 (0)