Skip to content

Commit 6adf809

Browse files
committed
update NEWS.md
1 parent d7ea5f4 commit 6adf809

3 files changed

Lines changed: 10 additions & 24 deletions

File tree

NEWS.md

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,11 @@
11
# reviser (development version)
22

3-
## Changes since rOpenSci submission
4-
* Nowcasting/Forecasting revisions with Jacobs van Norden model
5-
* Improved estimation methods for Kishor-Koenig model
3+
## Post-review changes
64

7-
## Submission
5+
* Added Jacobs-van Norden nowcasting support via `jvn_nowcast()`.
6+
* Improved estimation methods and solver behavior in `kk_nowcast()`.
7+
* Expanded examples, tests, and documentation.
88

9-
* Initial submission to rOpenSci for peer review (2025-05-28)
9+
## Review milestone
1010

11-
## Features
12-
13-
* Core functionality for working with vintage data (real-time datasets)
14-
* Support for both long and wide format vintage data
15-
* Handles single time series and lists of multiple time series
16-
* Validation and format detection for vintage data structures
17-
* Functions for extracting, comparing, and visualizing vintage data
18-
* Statistical analysis tools for vintage datasets
19-
* Nowcasting/Forecasting revisions with Kishor-Koenig model
20-
21-
## Documentation
22-
23-
* Function documentation with examples
24-
* Vignettes demonstrating package usage
25-
* README with quick start guide
11+
* Submitted to rOpenSci for peer review on 2025-05-28.

R/kk.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#' - "Howrey": Howrey's simplified framework.
1919
#' - "Classical": Classical model without vintage effects.
2020
#' @param method A string specifying the estimation method to use. Options are
21-
#' "SUR" (default), Maximum likelihood ("MLE") and "OLS".
21+
#' "MLE" (Maximum Likelihood, default), "SUR", and "OLS".
2222
#' @param alpha Significance level for confidence intervals (default = 0.05).
2323
#' @param solver_options A named list controlling the SUR and MLE routines.
2424
#' Valid names are `trace`, `maxiter`, `startvals`, `solvtol`, `gradtol`,
@@ -145,7 +145,7 @@ kk_nowcast <- function(
145145
e,
146146
h = 0,
147147
model = "Kishor-Koenig",
148-
method = "SUR",
148+
method = "MLE",
149149
alpha = 0.05,
150150
solver_options = list()
151151
) {

man/kk_nowcast.Rd

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)