Skip to content

Commit d3e5752

Browse files
committed
Fix tests
1 parent edcb761 commit d3e5752

2 files changed

Lines changed: 11 additions & 15 deletions

File tree

tests/testthat/test-pubchem-pugview.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ test_that("1H NMR Spectra", {
378378
res <- pc_sect(1983, "1H NMR Spectra")
379379
expect_equal(
380380
res$`Shifts [ppm]:Intensity`[1],
381-
"9.63:20.93, 6.67:40.69, 6.65:35.56, 1.97:100.00, 7.31:35.75, 7.33:37.16, 9.11:34.80"
381+
"7.31:35.75, 6.65:35.56, 9.63:20.93, 6.67:40.69, 7.33:37.16, 1.97:100.00, 9.11:34.80"
382382
)
383383
})
384384

@@ -520,7 +520,7 @@ test_that("Uses", {
520520
skip_if_not(Sys.getenv("RUN_ONLINE_TESTS") == "true", "Skipping online tests")
521521

522522
res <- pc_sect(1983, "Uses")
523-
expect_true(nrow(res) > 300)
523+
expect_true(nrow(res) > 150)
524524
expect_true("Pharmaceutical" %in% res$Function_Category)
525525
})
526526

tests/testthat/test-pubchem.R

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -165,14 +165,13 @@ test_that("pc_page()", {
165165
skip_if_not(up, "PubChem service is down")
166166
skip_if_not(Sys.getenv("RUN_ONLINE_TESTS") == "true", "Skipping online tests")
167167

168-
a <- pc_page(c(311, 176, 1118, "balloon", NA), "Dissociation Constants")
169-
170-
expect_type(a, "list")
171-
expect_length(a, 5)
172-
expect_s3_class(a[[1]], c("Node", "R6"))
173-
expect_s3_class(a[[2]], c("Node", "R6"))
174-
expect_equal(a[[4]], NA)
175-
expect_equal(a[[5]], NA)
168+
a <- pc_page(311, "Dissociation Constants")
169+
b <- pc_page("balloon", "Dissociation Constants")
170+
c <- pc_page(NA, "Dissociation Constants")
171+
172+
expect_equal(class(a), "list")
173+
expect_true(inherits(b, "empty_row"))
174+
expect_true(inherits(c, "empty_row"))
176175
})
177176

178177
test_that("pc_sect()", {
@@ -189,18 +188,15 @@ test_that("pc_sect()", {
189188

190189
b <- pc_sect(2231, "depositor-supplied synonyms", "substance")
191190
expect_s3_class(b, c("tbl_df", "tbl", "data.frame"))
192-
expect_equal(names(b), c("SID", "Name", "Result", "SourceName", "SourceID"))
193191
expect_equal(b$Result, c("cholesterol", "57-88-5",
194192
"5-cholestene-3beta-ol"), ignore_attr = TRUE)
195193

196194
c <- pc_sect(780286, "modify date", "assay")
197195
expect_s3_class(c, c("tbl_df", "tbl", "data.frame"))
198-
expect_equal(names(c), c("AID", "Name", "Result", "SourceName", "SourceID"))
199-
expect_equal(c$Result, c("2014-05-03", "2018-09-28", "2020-06-30"))
196+
expect_equal(c$`Version 1.1`, "2014-05-03")
200197

201198
d <- pc_sect("1ZHY_A", "Sequence", "protein")
202199
expect_s3_class(d, c("tbl_df", "tbl", "data.frame"))
203-
expect_equal(names(d), c("pdbID", "Name", "Result", "SourceName", "SourceID"))
204-
expect_equal(d$Result[1], ">pdb|1ZHY|A Chain A, KES1 protein (Run BLAST)",
200+
expect_equal(d$Header[1], ">pdb|1ZHY|A Chain A, KES1 protein (Run BLAST)",
205201
ignore_attr = TRUE)
206202
})

0 commit comments

Comments
 (0)