Skip to content

Commit a9c9b65

Browse files
fix Qt API
1 parent 6612e53 commit a9c9b65

1 file changed

Lines changed: 20 additions & 20 deletions

File tree

rqt_controller_manager/rqt_controller_manager/controller_manager.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -102,24 +102,24 @@ def __init__(self, context):
102102

103103
# Controllers display
104104
ctrl_table_view = self._widget.ctrl_table_view
105-
ctrl_table_view.setContextMenuPolicy(Qt.CustomContextMenu)
105+
ctrl_table_view.setContextMenuPolicy(Qt.ContextMenuPolicy.CustomContextMenu)
106106
ctrl_table_view.customContextMenuRequested.connect(self._on_ctrl_menu)
107107
ctrl_table_view.doubleClicked.connect(self._on_ctrl_info)
108108

109109
ctrl_header = ctrl_table_view.horizontalHeader()
110-
ctrl_header.setSectionResizeMode(QHeaderView.ResizeToContents)
111-
ctrl_header.setContextMenuPolicy(Qt.CustomContextMenu)
110+
ctrl_header.setSectionResizeMode(QHeaderView.ResizeMode.ResizeToContents)
111+
ctrl_header.setContextMenuPolicy(Qt.ContextMenuPolicy.CustomContextMenu)
112112
ctrl_header.customContextMenuRequested.connect(self._on_ctrl_header_menu)
113113

114114
# Hardware components display
115115
hw_table_view = self._widget.hw_table_view
116-
hw_table_view.setContextMenuPolicy(Qt.CustomContextMenu)
116+
hw_table_view.setContextMenuPolicy(Qt.ContextMenuPolicy.CustomContextMenu)
117117
hw_table_view.customContextMenuRequested.connect(self._on_hw_menu)
118118
hw_table_view.doubleClicked.connect(self._on_hw_info)
119119

120120
hw_header = hw_table_view.horizontalHeader()
121-
hw_header.setSectionResizeMode(QHeaderView.ResizeToContents)
122-
hw_header.setContextMenuPolicy(Qt.CustomContextMenu)
121+
hw_header.setSectionResizeMode(QHeaderView.ResizeMode.ResizeToContents)
122+
hw_header.setContextMenuPolicy(Qt.ContextMenuPolicy.CustomContextMenu)
123123
hw_header.customContextMenuRequested.connect(self._on_hw_header_menu)
124124

125125
# Timer for controller manager updates
@@ -142,7 +142,7 @@ def __init__(self, context):
142142

143143
# Signal connections
144144
w = self._widget
145-
w.cm_combo.currentIndexChanged[str].connect(self._on_cm_change)
145+
w.cm_combo.currentTextChanged.connect(self._on_cm_change)
146146

147147
def shutdown_plugin(self):
148148
self._update_cm_list_timer.stop()
@@ -246,7 +246,7 @@ def _on_ctrl_menu(self, pos):
246246
# Controller isn't loaded
247247
action_load = menu.addAction(self._icons["unconfigured"], "Load (unconfigured)")
248248

249-
action = menu.exec_(self._widget.ctrl_table_view.mapToGlobal(pos))
249+
action = menu.exec(self._widget.ctrl_table_view.mapToGlobal(pos))
250250

251251
# Evaluate user action
252252
if ctrl.state == "active":
@@ -510,7 +510,7 @@ def columnCount(self, parent):
510510
return 2
511511

512512
def headerData(self, col, orientation, role):
513-
if orientation != Qt.Horizontal or role != Qt.DisplayRole:
513+
if orientation != Qt.Orientation.Horizontal or role != Qt.ItemDataRole.DisplayRole:
514514
return None
515515
if col == 0:
516516
return "controller"
@@ -523,23 +523,23 @@ def data(self, index, role):
523523

524524
ctrl = self._data[index.row()]
525525

526-
if role == Qt.DisplayRole:
526+
if role == Qt.ItemDataRole.DisplayRole:
527527
if index.column() == 0:
528528
return ctrl.name
529529
elif index.column() == 1:
530530
return ctrl.state or "unloaded"
531531

532-
if role == Qt.DecorationRole and index.column() == 0:
532+
if role == Qt.ItemDataRole.DecorationRole and index.column() == 0:
533533
state_key = ctrl.state if ctrl.state else "unloaded"
534534
return self._icons.get(state_key)
535535

536-
if role == Qt.FontRole and index.column() == 0:
536+
if role == Qt.ItemDataRole.FontRole and index.column() == 0:
537537
bf = QFont()
538538
bf.setBold(True)
539539
return bf
540540

541-
if role == Qt.TextAlignmentRole and index.column() == 1:
542-
return Qt.AlignCenter
541+
if role == Qt.ItemDataRole.TextAlignmentRole and index.column() == 1:
542+
return Qt.AlignmentFlag.AlignCenter
543543

544544

545545
class HwComponentTable(QAbstractTableModel):
@@ -562,7 +562,7 @@ def columnCount(self, parent):
562562
return 2
563563

564564
def headerData(self, col, orientation, role):
565-
if orientation != Qt.Horizontal or role != Qt.DisplayRole:
565+
if orientation != Qt.Orientation.Horizontal or role != Qt.ItemDataRole.DisplayRole:
566566
return None
567567
if col == 0:
568568
return "component"
@@ -575,22 +575,22 @@ def data(self, index, role):
575575

576576
hw_component = self._data[index.row()]
577577

578-
if role == Qt.DisplayRole:
578+
if role == Qt.ItemDataRole.DisplayRole:
579579
if index.column() == 0:
580580
return hw_component.name
581581
elif index.column() == 1:
582582
return hw_component.state.label or "unloaded"
583583

584-
if role == Qt.DecorationRole and index.column() == 0:
584+
if role == Qt.ItemDataRole.DecorationRole and index.column() == 0:
585585
return self._icons.get(hw_component.state.label)
586586

587-
if role == Qt.FontRole and index.column() == 0:
587+
if role == Qt.ItemDataRole.FontRole and index.column() == 0:
588588
bf = QFont()
589589
bf.setBold(True)
590590
return bf
591591

592-
if role == Qt.TextAlignmentRole and index.column() == 1:
593-
return Qt.AlignCenter
592+
if role == Qt.ItemDataRole.TextAlignmentRole and index.column() == 1:
593+
return Qt.AlignmentFlag.AlignCenter
594594

595595

596596
class FontDelegate(QStyledItemDelegate):

0 commit comments

Comments
 (0)