Tweaked all calls to nl2br to now spit out <br> instead of <br />

Author: rotimi

src/HtmlErrorRenderer.php

@@ -64,6 +64,6 @@ private function renderExceptionFragment(\Throwable $exception): string {
         $html .= sprintf('<div><strong>Line:</strong> %s</div>', $exception->getLine());
         $html .= '<h2>Trace</h2>';
 
-        return $html . sprintf('<pre>%s</pre>', nl2br(htmlentities($exception->getTraceAsString())) );
+        return $html . sprintf('<pre>%s</pre>', nl2br(htmlentities($exception->getTraceAsString()), false) );
     }
 }

src/controllers/BaseController.php

@@ -739,7 +739,7 @@ public function actionLogin(): ResponseInterface|string {
              */
             if( sMVC_GetCurrentAppEnvironment() !== \SlimMvcTools\AppEnvironments::PRODUCTION ) {
 
-                $msg .= '<br>'.nl2br(sMVC_DumpAuthinfo($auth));
+                $msg .= '<br>'.nl2br(sMVC_DumpAuthinfo($auth), false);
             }
 
             if( $auth->isValid() ) {
@@ -1031,7 +1031,7 @@ public function actionLoginStatus(): string {
          */
         if( sMVC_GetCurrentAppEnvironment() !== \SlimMvcTools\AppEnvironments::PRODUCTION ) {
             /** @psalm-suppress MixedOperand */
-            $msg .= '<br>'.nl2br(sMVC_DumpAuthinfo($auth));
+            $msg .= '<br>'.nl2br(sMVC_DumpAuthinfo($auth), false);
         }
 
         //get the contents of the view first

tests/BaseControllerTest.php

@@ -695,27 +695,27 @@ public function testThat_actionLogin_WithRequestPostMethod_WorksAsExpected() {
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "The 'username' field is empty.<br>The 'password' field is empty.<br>Login Status: ANON<br />", 
+            "The 'username' field is empty.<br>The 'password' field is empty.<br>Login Status: ANON<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Logged in Person's Username: <br />", 
+            "Logged in Person's Username: <br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Logged in User's Data: <br />", 
+            "Logged in User's Data: <br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Array<br />", 
+            "Array<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "(<br />", 
+            "(<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            ")<br />", 
+            ")<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
@@ -778,27 +778,27 @@ public function testThat_actionLogin_WithRequestPostMethod_WorksAsExpected2() {
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "The 'password' field is empty.<br>Login Status: ANON<br />", 
+            "The 'password' field is empty.<br>Login Status: ANON<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Logged in Person's Username: <br />", 
+            "Logged in Person's Username: <br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Logged in User's Data: <br />", 
+            "Logged in User's Data: <br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Array<br />", 
+            "Array<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "(<br />", 
+            "(<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            ")<br />", 
+            ")<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
@@ -861,27 +861,27 @@ public function testThat_actionLogin_WithRequestPostMethod_WorksAsExpected3() {
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "The 'username' field is empty.<br>Login Status: ANON<br />", 
+            "The 'username' field is empty.<br>Login Status: ANON<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Logged in Person's Username: <br />", 
+            "Logged in Person's Username: <br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Logged in User's Data: <br />", 
+            "Logged in User's Data: <br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "Array<br />", 
+            "Array<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            "(<br />", 
+            "(<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
-            ")<br />", 
+            ")<br>", 
             $actionLoginResult
         );
         self::assertStringContainsString(
@@ -1575,7 +1575,7 @@ public function testThat_actionLoginStatus_WorksAsExpected() {
             $auth->getSession()->setStatus($auth_status);
             $action_result = $controller->actionLoginStatus();
             self::assertStringContainsString($status_message_in_rendered_view, $action_result);
-            self::assertStringContainsString('<br>'.nl2br(sMVC_DumpAuthinfo($auth)), $action_result);
+            self::assertStringContainsString('<br>'.nl2br(sMVC_DumpAuthinfo($auth), false), $action_result);
         }
 
         ////////////////////////////////////////////////////////////////////////

tests/HtmlErrorRendererTest.php

@@ -70,7 +70,7 @@ public function testThat___invoke_And_setDefaultErrorTitle_And_setDefaultErrorDe
             $result
         );
         self::assertStringContainsString(
-            sprintf('<pre>%s</pre>', nl2br(htmlentities($http_exception->getTraceAsString())) ), 
+            sprintf('<pre>%s</pre>', nl2br(htmlentities($http_exception->getTraceAsString()), false) ), 
             $result
         );
         //self::assertStringContainsString($needle, $result);