configs: update openEuler 24.03 LTS chroot to SP4 and fix source metalink

Bump the openEuler 24.03 LTS template from SP3 to SP4 (releasever,
description, bootstrap_image). module_platform_id stays platform:oe2403.
SP4 is now registered in the metalink (mirrormanager) endpoint the
chroot relies on: repo=24.03LTS_SP4/OS returns 5 mirrors, the docker
tag 24.03-lts-sp4 is published on Docker Hub.

Also fix the source and update-source metalink repositories across all
openEuler templates (20.03, 22.03, 24.03): the path= metalink form does
not translate the $releasever dnf variable into the full mirror
directory name (only the repo= form does), so path=openeuler/$releasever
resolved to a non-existent path and silently broke mock --sources.  Use
the literal openEuler-<version> directory name instead.

Add an offline test (test_openeuler_configs.py) that loads the shipped
configs and asserts no path= metalink depends on $releasever.

Assisted-By: pi

Author: pkking

mock-core-configs/etc/mock/templates/openeuler-20.03.tpl

@@ -54,9 +54,12 @@ enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker
 
+# metalink path= form does NOT translate $releasever to the full mirror
+# directory name (only the repo= form does), so source repos must use the
+# literal openEuler-<version> directory.
 [source]
 name=source
-metalink=https://mirrors.openeuler.org/metalink?path=openeuler/$releasever/source/repodata/repomd.xml
+metalink=https://mirrors.openeuler.org/metalink?path=openeuler/openEuler-20.03-LTS-SP4/source/repodata/repomd.xml
 enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker

mock-core-configs/etc/mock/templates/openeuler-22.03.tpl

@@ -57,9 +57,12 @@ enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker
 
+# metalink path= form does NOT translate $releasever to the full mirror
+# directory name (only the repo= form does), so source repos must use the
+# literal openEuler-<version> directory.
 [source]
 name=source
-metalink=https://mirrors.openeuler.org/metalink?path=openeuler/$releasever/source/repodata/repomd.xml
+metalink=https://mirrors.openeuler.org/metalink?path=openeuler/openEuler-22.03-LTS-SP4/source/repodata/repomd.xml
 enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker
@@ -73,7 +76,7 @@ gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-E
 
 [update-source]
 name=update-source
-metalink=https://mirrors.openeuler.org/metalink?path=openeuler/$releasever/update/source/repodata/repomd.xml
+metalink=https://mirrors.openeuler.org/metalink?path=openeuler/openEuler-22.03-LTS-SP4/update/source/repodata/repomd.xml
 enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker

mock-core-configs/etc/mock/templates/openeuler-24.03.tpl

@@ -1,10 +1,10 @@
 config_opts['chroot_setup_cmd'] = 'install tar gcc-c++ openEuler-rpm-config openEuler-release which xz sed make bzip2 gzip gcc coreutils unzip diffutils cpio bash gawk rpm-build info patch util-linux findutils grep'
 config_opts['dist'] = 'oe2403'  # only useful for --resultdir variable subst
-config_opts['releasever'] = '24.03LTS_SP3'
+config_opts['releasever'] = '24.03LTS_SP4'
 config_opts['package_manager'] = 'dnf'
-config_opts['description'] = 'openEuler 24.03 LTS SP3'
+config_opts['description'] = 'openEuler 24.03 LTS SP4'
 config_opts['extra_chroot_dirs'] = [ '/run/lock', ]
-config_opts['bootstrap_image'] = 'docker.io/openeuler/openeuler:24.03-lts-sp3'
+config_opts['bootstrap_image'] = 'docker.io/openeuler/openeuler:24.03-lts-sp4'
 
 config_opts['dnf.conf'] = """
 [main]
@@ -57,9 +57,12 @@ enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker
 
+# metalink path= form does NOT translate $releasever to the full mirror
+# directory name (only the repo= form does), so source repos must use the
+# literal openEuler-<version> directory.
 [source]
 name=source
-metalink=https://mirrors.openeuler.org/metalink?path=openeuler/$releasever/source/repodata/repomd.xml
+metalink=https://mirrors.openeuler.org/metalink?path=openeuler/openEuler-24.03-LTS-SP4/source/repodata/repomd.xml
 enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker
@@ -73,7 +76,7 @@ gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-E
 
 [update-source]
 name=update-source
-metalink=https://mirrors.openeuler.org/metalink?path=openeuler/$releasever/update/source/repodata/repomd.xml
+metalink=https://mirrors.openeuler.org/metalink?path=openeuler/openEuler-24.03-LTS-SP4/update/source/repodata/repomd.xml
 enabled=0
 gpgcheck=1
 gpgkey=file:///usr/share/distribution-gpg-keys/openeuler/RPM-GPG-KEY-openEuler-EulerMaker

mock/tests/test_openeuler_configs.py

@@ -0,0 +1,45 @@
+"""
+Tests for the openEuler chroot configs shipped in mock-core-configs.
+
+The openEuler metalink service exposes source repos only via the
+``path=openeuler/<dir>/...`` form.  Unlike the ``repo=`` form, ``path=`` does
+*not* translate the ``$releasever`` dnf variable into the full mirror
+directory name (e.g. ``24.03LTS_SP4`` -> ``openEuler-24.03-LTS-SP4``), so a
+source metalink that relies on ``$releasever`` resolves to a non-existent path
+and silently breaks ``mock --sources``.
+
+These tests load the real shipped configs (no network) and assert that no
+``path=`` metalink depends on ``$releasever``.
+"""
+
+import os
+
+import pytest
+from mockbuild.config import simple_load_config
+
+REPO_ROOT = os.path.dirname(os.path.dirname(os.path.dirname(os.path.realpath(__file__))))
+CONFIG_DIR = os.path.join(REPO_ROOT, "mock-core-configs", "etc", "mock")
+
+OPENEULER_CHROOTS = [
+    f[:-len(".cfg")] for f in os.listdir(CONFIG_DIR)
+    if f.startswith("openeuler-") and f.endswith(".cfg")
+]
+
+
+@pytest.mark.parametrize("chroot", [pytest.param(c, id=c) for c in OPENEULER_CHROOTS])
+def test_path_metalink_does_not_use_releasever(chroot):
+    """``path=`` metalinks must not depend on ``$releasever``.
+
+    The metalink ``path=`` form is taken literally and is never translated,
+    so a ``$releasever`` in it would point at a path that does not exist.
+    """
+    dnf_conf = simple_load_config(chroot, CONFIG_DIR)["dnf.conf"]
+    for line in dnf_conf.splitlines():
+        stripped = line.strip()
+        if not stripped.startswith("metalink=") or "path=" not in stripped:
+            continue
+        assert "$releasever" not in line, (
+            f"{chroot}: source metalink uses the untranslated $releasever in "
+            f"a path= form, which the metalink service does not translate:\n"
+            f"  {line.strip()}"
+        )

releng/release-notes-next/openeuler-2403-sp3.config

@@ -0,0 +1,5 @@
+Update openEuler 24.03 LTS chroot to SP4 and fix the source and
+update-source metalink repositories across all openEuler templates
+(20.03, 22.03, 24.03): the `path=` metalink form does not translate the
+`$releasever` dnf variable into the full mirror directory name, so it
+resolved to a non-existent path and silently broke `mock --sources`.