rpmbuild stage should not inherit the proxy environment if rpmbuild_networking is False

[yaneti]

(http,https,ftp)_proxy can be useful and save unnecessary trafic when building the buildroot, but can actively harm the rpmbuild build phase itself when networking is disabled (the default) and certain build targets execute steps/tests that are trying some networking even if its only to localhost .

Was burned by this when certain python tests in the %check phase are using standard python libs and are actively trying to connect to the proxy even if trying to talk to localhost http.

[yaneti]

Trying locally a hack like this: (updated 13 hours later to something that actually strips the right things, and not the whole env)

diff --git a/mock/py/mockbuild/buildroot.py b/mock/py/mockbuild/buildroot.py
index fb608b19..3ecbd6ca 100644
--- a/mock/py/mockbuild/buildroot.py
+++ b/mock/py/mockbuild/buildroot.py
@@ -432,6 +432,10 @@ class Buildroot(object):
         kargs.setdefault("nspawn_args", [])
         kargs["nspawn_args"].extend(self.config.get("nspawn_args", []))
 
+        private_network = not self.config.get('rpmbuild_networking', False)
+        if filter(lambda x: "rpmbuild" in x, command) and private_network:
+            util.discard_proxy_environment(env)
+
         try:
             result = util.do_with_status(command, chrootPath=self.make_chroot_path(),
                                          env=env, *args, **kargs)
diff --git a/mock/py/mockbuild/util.py b/mock/py/mockbuild/util.py
index 83dd7efe..97b9f5a3 100644
--- a/mock/py/mockbuild/util.py
+++ b/mock/py/mockbuild/util.py
@@ -112,6 +112,13 @@ def get_proxy_environment(config):
     return env
 
 
+@traceLog()
+def discard_proxy_environment(env):
+    for proto in ('http', 'https', 'ftp', 'no'):
+        key = '%s_proxy' % proto
+        env.pop(key, None)
+
+
 def _safe_check_output(*args):
     # this can be done in one call in python3, but python2 requires this hack
     try:

[xsuchy]

The http_proxy propagation was added in commit 56706b9

If you want to disable it, you can edit your local '/etc/consolehelper/mock'. I doubt that we want to make it default.

[yaneti]

Not sure what you mean exactly. I don't want to disable proxy propagation, its useful in the buildroot setup phase. That why I have it the site-defaults config here.
What I am saying is that with networking disabled in the rpmbuild phase having those variables there can be actively harmful.