Skip to content

Commit 938f517

Browse files
authored
Merge pull request #1519 from rpm-software-management/date-checks-warning
BuildRootAndDateCheck: Convert date errs to warning
2 parents ac32ceb + 384dff1 commit 938f517

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

rpmlint/checks/BuildRootAndDateCheck.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ def check_file(self, pkg, filename):
3838
data = pkg.read_with_mmap(filename)
3939
if self.istoday.search(data):
4040
if self.looksliketime.search(data):
41-
self.output.add_info('E', pkg, 'file-contains-date-and-time', filename)
41+
self.output.add_info('W', pkg, 'file-contains-date-and-time', filename)
4242
else:
43-
self.output.add_info('E', pkg, 'file-contains-current-date', filename)
43+
self.output.add_info('W', pkg, 'file-contains-current-date', filename)
4444
if self.lookslikebuildroot.search(data):
4545
self.output.add_info('E', pkg, 'file-contains-buildroot', filename)

test/test_build_date.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ def test_build_date_time(package, builddatecheck):
2323
test.istoday = re.compile('Jan 1 2019')
2424
test.check(package)
2525
out = output.print_results(output.results)
26-
assert 'E: file-contains-date-and-time /bin/with-datetime' in out
27-
assert 'E: file-contains-current-date /bin/with-date' in out
26+
assert 'W: file-contains-date-and-time /bin/with-datetime' in out
27+
assert 'W: file-contains-current-date /bin/with-date' in out
2828

2929

3030
@pytest.mark.parametrize('package', [BashismsPackage])
@@ -33,5 +33,5 @@ def test_build_date_time_correct(package, builddatecheck):
3333
test.istoday = re.compile('Jan 1 2019')
3434
test.check(package)
3535
out = output.print_results(output.results)
36-
assert 'E: file-contains-date-and-time' not in out
37-
assert 'E: file-contains-current-date' not in out
36+
assert 'W: file-contains-date-and-time' not in out
37+
assert 'W: file-contains-current-date' not in out

0 commit comments

Comments
 (0)