Skip to content

Commit 6db3a65

Browse files
committed
Fix Issue #176 so guess_phase() works with genail
- is_phase_known() was returning TRUE - that's because you need to indicate that there's a phase-known version of the cross type in the cross_*.h file. - technically, we need to create a genailpk cross type. I think this is only used in est_map().
1 parent 5f75bf3 commit 6db3a65

3 files changed

Lines changed: 9 additions & 4 deletions

File tree

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: qtl2
2-
Version: 0.23-12
3-
Date: 2020-12-09
2+
Version: 0.23-13
3+
Date: 2020-12-10
44
Title: Quantitative Trait Locus Mapping in Experimental Crosses
55
Description: Provides a set of tools to perform quantitative
66
trait locus (QTL) analysis in experimental crosses. It is a

NEWS.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## qtl2 0.23-12 (2020-12-09)
1+
## qtl2 0.23-13 (2020-12-10)
22

33
### Major changes
44

@@ -57,6 +57,11 @@
5757
- Fixed Issue #146, revising `predict_snpgeno()` so that it works for
5858
homozygous populations, like MAGIC lines or the Collaborative Cross.
5959

60+
- Fixed Issue #176, that `guess_phase()` doesn't work with cross type
61+
`"genail"`. Needed to define `phase_known_crosstype` as `"genailpk"` in
62+
[`cross_genail.h`](https://github.com/rqtl/qtl2/blob/master/src/cross_genail.h)
63+
because otherwise `is_phase_known()` will return TRUE.
64+
6065

6166
## qtl2 0.22-11 (2020-07-09)
6267

src/cross_genail.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class GENAIL : public QTLCross
1313

1414
GENAIL(int nf){
1515
crosstype = "genail";
16-
phase_known_crosstype = "genail";
16+
phase_known_crosstype = "genailpk"; // this actually doesn't exist
1717
if(nf < 2) {
1818
throw std::range_error("general AIL should have >= 2 founders");
1919
}

0 commit comments

Comments
 (0)