Skip to content

Reconsider DEPLOY_MSG #53

@jennybc

Description

@jennybc

My approach to making the DEPLOY_MSG in .travis.yml is not robust to quotes inside the commit message.

https://github.com/rstudio-education/stat545/blob/master/.travis.yml#L19

If the truncation to first n characters happens to catch, say, an opening " but not the closing, it can cause problems:

Happened with 46a81ad

Notice the cryptic error in the deploy stage:

https://travis-ci.org/rstudio-education/stat545/builds/589671690#L900-L903

Deploying application
sh: 1: Syntax error: Unterminated quoted string
Script failed with status 2

Caused by unfortunate truncating of this commit message:

Link to the ellipsis package and "Data, dots, details"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions