Mark PartContract#elements as @api private

Also migrated tests that accessed raw Element objects
to use the public paths API instead.

Author: rubiii

lib/wsdl/contract/part_contract.rb

@@ -14,9 +14,7 @@ def initialize(elements, section:)
 
       # Returns the frozen collection of elements for this part.
       #
-      # The array itself is frozen; individual elements should be treated as
-      # read-only introspection objects.
-      #
+      # @api private
       # @return [Array<WSDL::XML::Element>]
       attr_reader :elements
 

spec/acceptance/schema_patterns_spec.rb

@@ -88,22 +88,24 @@ def roundtrip(operation, hash)
     let(:operation) { client.operation(:GetEvent) }
 
     it 'sets list flag and itemType on list-derived attributes' do
-      elements = operation.contract.response.body.elements
-      tags = elements.first.attributes.find { |a| a.name == 'tags' }
-      scores = elements.first.attributes.find { |a| a.name == 'scores' }
-
-      expect(tags.list?).to be true
-      expect(tags.base_type).to eq 'xsd:string'
-      expect(scores.list?).to be true
-      expect(scores.base_type).to eq 'xsd:int'
+      paths = operation.contract.response.body.paths
+      root = paths.find { |p| p[:path].size == 1 }
+      tags = root[:attributes].find { |a| a[:name] == 'tags' }
+      scores = root[:attributes].find { |a| a[:name] == 'scores' }
+
+      expect(tags[:list]).to be true
+      expect(tags[:type]).to eq 'xsd:string'
+      expect(scores[:list]).to be true
+      expect(scores[:type]).to eq 'xsd:int'
     end
 
     it 'uses first memberType for union-derived attributes' do
-      elements = operation.contract.response.body.elements
-      code = elements.first.attributes.find { |a| a.name == 'code' }
+      paths = operation.contract.response.body.paths
+      root = paths.find { |p| p[:path].size == 1 }
+      code = root[:attributes].find { |a| a[:name] == 'code' }
 
-      expect(code.list?).to be false
-      expect(code.base_type).to eq 'xsd:string'
+      expect(code[:list]).to be false
+      expect(code[:type]).to eq 'xsd:string'
     end
 
     it 'round-trips list attributes with whitespace splitting and type coercion' do
@@ -167,10 +169,10 @@ def roundtrip(operation, hash)
     let(:operation) { client.operation(:GetMeasurement) }
 
     it 'uses first member type as base_type' do
-      elements = operation.contract.response.body.elements
-      value_el = elements.first.children.find { |c| c.name == 'value' }
+      paths = operation.contract.response.body.paths
+      value = paths.find { |p| p[:path].last == 'value' }
 
-      expect(value_el.base_type).to eq 'xsd:string'
+      expect(value[:type]).to eq 'xsd:string'
     end
 
     it 'round-trips response data' do
@@ -188,11 +190,11 @@ def roundtrip(operation, hash)
     let(:operation) { client.operation(:GetTags) }
 
     it 'marks list elements with list flag' do
-      elements = operation.contract.response.body.elements
-      tags = elements.first.children.find { |c| c.name == 'tags' }
+      paths = operation.contract.response.body.paths
+      tags = paths.find { |p| p[:path].last == 'tags' }
 
-      expect(tags.list?).to be true
-      expect(tags.base_type).to eq 'xsd:string'
+      expect(tags[:list]).to be true
+      expect(tags[:type]).to eq 'xsd:string'
     end
 
     it 'round-trips string list values' do

spec/wsdl/client_spec.rb

@@ -498,9 +498,9 @@ def initialize(cache_key)
         client = described_class.new(f.path)
         operation = client.operation('S', 'P', 'Op')
 
-        expect(operation.contract.response.body.elements).to eq([])
-        expect(operation.contract.response.header.elements).to eq([])
-        expect(operation.contract.request.body.elements).not_to be_empty
+        expect(operation.contract.response.body.paths).to eq([])
+        expect(operation.contract.response.header.paths).to eq([])
+        expect(operation.contract.request.body.paths).not_to be_empty
         expect(operation.output_style).to be_nil
       end
     end