Skip to content

rubyzip 3.2: Add type sig for block-form/generic overrides and fix sig top-level config#1023

Merged
github-actions[bot] merged 12 commits intoruby:mainfrom
gonzedge:gonzedge/rubyzip-3-generics
Apr 7, 2026
Merged

rubyzip 3.2: Add type sig for block-form/generic overrides and fix sig top-level config#1023
github-actions[bot] merged 12 commits intoruby:mainfrom
gonzedge:gonzedge/rubyzip-3-generics

Conversation

@gonzedge
Copy link
Copy Markdown
Contributor

@gonzedge gonzedge commented Apr 7, 2026

A few of the block-form + generic methods were mistyped on #1022. The ::Zip methods were added as def self. signatures. These two issues were not caught because there was not enough code to exercise the new types; instead I caught them when trying to use gem_rbs_collection again in gonzedge/rambling-trie#90.

This PR:

  • fix top level ::Zip module config methods (remove self. and add extend Zip at the top)
  • add block-form/generic overrides for Zip::File.open and Zip::File.open_buffer
  • add block-form/generic method overrides for Zip::FileSystem::(Dir|File|ZipFileNameMapper)
  • add block-form/generic method overrides for Zip::(Input|Output)Stream
  • add block-form/generic method overrides for Zip::Streamable*
  • add non-block/generic method overrides for Zip::Entry
  • add test code for all missing block-form return types
  • add more test code to exercise as much code in the library as possible

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

@gonzedge Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

rubyzip

You changed RBS files for an existing gem.
This gem does not have reviewers. So you can merge this PR immediately if the CI passes.
We recommend you add yourself to the reviewers for this gem.

@gonzedge
Copy link
Copy Markdown
Contributor Author

gonzedge commented Apr 7, 2026

/merge

@github-actions github-actions bot merged commit 2912890 into ruby:main Apr 7, 2026
5 checks passed
@gonzedge gonzedge deleted the gonzedge/rubyzip-3-generics branch April 7, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant