Donation Show: Create functionality so user can "unlock" a completed donation

[christine-sm]

Currently, once a user marks a donation as completed, they are no longer able to create, edit, or delete items. In case a user makes an error, they should be able to "unlock" a donation by reverting it to complete: false so the user can make adjustments to prior completed donations.

[tmobaird]

I can take this one 👍

[armahillo]

OK -- I'm poking through this. I've got a basic idea on how to do the reversion but one gotcha I'm seeing is this:

1. Reverting a donation needs to check that there is adequate inventory on hand to revert the donation (since the donation has already been "completed", the Inventory.intake! has already been run)
2. BUT! It's possible that inventory is being held at multiple locations... We would basically have to create a reversion manifest.

I think we want to have "completed" donations be irreversible.

Maybe instead we can add a "Are you sure? This action cannot be reversed!" alert when they click "Complete donation", and add a way to create adjustments to the inventory totals?

I recognize the need to reconcile the app inventories with the real inventories, I'm just not sure that Donation reversion is the best way.

What do you all think?

[cattywampus]

You've identified a lot of serious things to consider in regards to reversing a donation, and here's the thing - we don't know that the customer actually needs to do this yet. I would recommend avoid scope creep and inventing new requirements without direction from the customer on this.

Sometimes it's better to stick with what works and add the simplest change. Using an "Are you sure?" prompt to finalize donations is probably the shortest path to creating donations in a safe workflow for the user.

[armahillo]

Sounds good to me! I think the "Are you sure" should also indicate that it cannot be undone.

[tmobaird]

Did you guys want me to tackle adding this "Are you sure?" alert in at some point today?

[armahillo]

@tmobaird Go for it!