Can't scroll over the sliders to change brightness

[rp1231]

Looks good, It detected my internal monitor and external monitor.
And the ddcci brightness/contrast/volume controls work perfectly for the external one.
Except you can't scroll over the sliders to change the values.

[rp1231]

Also, looking at the source code, I see that you've enabled mica.
That doesn't really seem to be working for me on windows 11.

[ruihe774]

Also, looking at the source code, I see that you've enabled mica. That doesn't really seem to be working for me on windows 11.

Could you provide a screenshot and your OS build (in Settings/System/About)? Mica works fine on my 22631.2715

[rp1231]

I'm on the same build as you.
I've posted a screenshot of both twinkle tray with mica blur enabled and brightness-tray for comparison.

[rp1231]

Also the power button isn't working.
Not that I have a need for it. But just thought I would mention it just in case.

[ruihe774]

you can't scroll over the sliders to change the values.

Done in d6ee080

[rp1231]

Confirmed working.

[ruihe774]

I've posted a screenshot of both twinkle tray with mica blur enabled and brightness-tray for comparison.

Mica is actually working. You can try a dark theme or a vivid wallpaper to see it clearly.

The difference is caused by different implementation. Twinkle Tray is mimicking Mica by itself -- its panel is actually transparent, and it retrieves your wallpaper and blends with it, see https://github.com/xanderfrangos/twinkle-tray/blob/master/src/electron.js#L3455-L3507. On the contrary, my implementation uses the official API DWM_SYSTEMBACKDROP_TYPE which is introduced in Windows 11 22H2 (that is also the reason why we need a very high Windows version). The Mica effect is done by Desktop Window Manager (DWM).

In the custom implementation of Mica in Twinkle Tray, Mica is blended in a more transparent (or more vivid?) way than system default. I don't know whether it is intentional. Maybe we can use HostBackdropBrush to achieve a similar effect, but I think we can do it latter.

[rp1231]

I see.
I'll close this issue in that case.

[ruihe774]

Also the power button isn't working. Not that I have a need for it. But just thought I would mention it just in case.

My implementation will display the power button if it can read the powerstate of your monitor. However, being able to read it does not mean being able to write it. You can have a look at the DevTool to see if it is an error whiling setting the powerstate.

In Twinkle Tray, power button is not displayed by default even the powerstate is detected. You need to enable it in the settings. You can try to enable it and see whether Twinkle Tray is able to control powerstate. We can adopt a similar approach after the settings page is implemented.

[rp1231]

The devtools console doesn't show any error while pressing the power button.
However I get this error when scrolling over any of the controls.

[rp1231]

Also I'm able to turn off my screen via twinkle tray through both the software signal and the ddcci method

[ruihe774]

Ok, I've tweaked the power button in 01a1327. It will not show if the reported powerstate maximum is less than 4, and it will try the maximum state by default. Could you have a try to see whether it works?

[ruihe774]

However I get this error when scrolling over any of the controls.

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#passive

Well, I've learned new knowledge:

If this option is not specified it defaults to false – except that in browsers other than Safari, it defaults to true for wheel, mousewheel, touchstart and touchmove events.

Meanwhile, React has made decision for me: react/react#22794 (comment) 🤣

[ruihe774]

I'm on the same build as you. I've posted a screenshot of both twinkle tray with mica blur enabled and brightness-tray for comparison.

It seems that your BOE0A9B (Display 1) is an internal laptop display and cannot be controlled by DDC/CI but WMI. WMI support is currently not implemented yet. Maybe someday I will get a laptop to implement it.