feat(r559): GetApplicationRelease — filter by release quality (autoloop iter 4)

Author: ryacub

app/src/main/java/eu/kanade/tachiyomi/data/updater/AppUpdateChecker.kt

@@ -25,6 +25,7 @@ class AppUpdateChecker {
                     BuildConfig.VERSION_NAME,
                     GITHUB_REPO,
                     forceCheck,
+                    includePrerelease = isPreviewBuildType,
                 ),
             )
 

domain/src/main/java/tachiyomi/domain/release/interactor/GetApplicationRelease.kt

@@ -30,6 +30,11 @@ class GetApplicationRelease(
 
         val release = service.latest(arguments) ?: return Result.NoNewUpdate
 
+        // Filter by release quality and user preference
+        if (!release.isUsable(arguments.includePrerelease)) {
+            return Result.NoNewUpdate
+        }
+
         lastChecked.set(now.toEpochMilli())
 
         // Check if latest version is different from current version
@@ -81,6 +86,7 @@ class GetApplicationRelease(
         val versionName: String,
         val repository: String,
         val forceCheck: Boolean = false,
+        val includePrerelease: Boolean = false,
     )
 
     sealed interface Result {

domain/src/test/java/tachiyomi/domain/release/interactor/GetApplicationReleaseTest.kt

@@ -11,6 +11,7 @@ import org.junit.jupiter.api.Test
 import tachiyomi.core.common.preference.Preference
 import tachiyomi.core.common.preference.PreferenceStore
 import tachiyomi.domain.release.model.Release
+import tachiyomi.domain.release.model.ReleaseQuality
 import tachiyomi.domain.release.service.ReleaseService
 import java.time.Instant
 
@@ -138,4 +139,170 @@ class GetApplicationReleaseTest {
         coVerify(exactly = 0) { releaseService.latest(any()) }
         result shouldBe GetApplicationRelease.Result.NoNewUpdate
     }
+
+    @Test
+    fun `When release quality is STABLE and includePrerelease false expect new update`() = runTest {
+        every { preference.get() } returns 0
+        every { preference.set(any()) }.answers { }
+
+        val release = Release(
+            "v2.0.0",
+            "info",
+            "http://example.com/release_link",
+            "http://example.com/release_link.apk",
+            quality = ReleaseQuality.STABLE,
+        )
+
+        coEvery { releaseService.latest(any()) } returns release
+
+        val result = getApplicationRelease.await(
+            GetApplicationRelease.Arguments(
+                isPreview = false,
+                commitCount = 0,
+                versionName = "v1.0.0",
+                repository = "test",
+                forceCheck = false,
+                includePrerelease = false,
+            ),
+        )
+
+        (result as GetApplicationRelease.Result.NewUpdate).release shouldBe release
+    }
+
+    @Test
+    fun `When release quality is PRERELEASE and includePrerelease false expect no new update`() = runTest {
+        every { preference.get() } returns 0
+        every { preference.set(any()) }.answers { }
+
+        val release = Release(
+            "v2.0.0-rc1",
+            "info",
+            "http://example.com/release_link",
+            "http://example.com/release_link.apk",
+            quality = ReleaseQuality.PRERELEASE,
+        )
+
+        coEvery { releaseService.latest(any()) } returns release
+
+        val result = getApplicationRelease.await(
+            GetApplicationRelease.Arguments(
+                isPreview = false,
+                commitCount = 0,
+                versionName = "v1.0.0",
+                repository = "test",
+                forceCheck = false,
+                includePrerelease = false,
+            ),
+        )
+
+        result shouldBe GetApplicationRelease.Result.NoNewUpdate
+    }
+
+    @Test
+    fun `When release quality is PRERELEASE and includePrerelease true expect new update`() = runTest {
+        every { preference.get() } returns 0
+        every { preference.set(any()) }.answers { }
+
+        val release = Release(
+            "v2.0.0-rc1",
+            "info",
+            "http://example.com/release_link",
+            "http://example.com/release_link.apk",
+            quality = ReleaseQuality.PRERELEASE,
+        )
+
+        coEvery { releaseService.latest(any()) } returns release
+
+        val result = getApplicationRelease.await(
+            GetApplicationRelease.Arguments(
+                isPreview = false,
+                commitCount = 0,
+                versionName = "v1.0.0",
+                repository = "test",
+                forceCheck = false,
+                includePrerelease = true,
+            ),
+        )
+
+        (result as GetApplicationRelease.Result.NewUpdate).release shouldBe release
+    }
+
+    @Test
+    fun `When release quality is DRAFT and includePrerelease true expect no new update`() = runTest {
+        every { preference.get() } returns 0
+        every { preference.set(any()) }.answers { }
+
+        val release = Release(
+            "v2.0.0",
+            "info",
+            "http://example.com/release_link",
+            "http://example.com/release_link.apk",
+            quality = ReleaseQuality.DRAFT,
+        )
+
+        coEvery { releaseService.latest(any()) } returns release
+
+        val result = getApplicationRelease.await(
+            GetApplicationRelease.Arguments(
+                isPreview = false,
+                commitCount = 0,
+                versionName = "v1.0.0",
+                repository = "test",
+                forceCheck = false,
+                includePrerelease = true,
+            ),
+        )
+
+        result shouldBe GetApplicationRelease.Result.NoNewUpdate
+    }
+
+    @Test
+    fun `When release quality is DEPRECATED and includePrerelease false expect no new update`() = runTest {
+        every { preference.get() } returns 0
+        every { preference.set(any()) }.answers { }
+
+        val release = Release(
+            "v2.0.0",
+            "info",
+            "http://example.com/release_link",
+            "http://example.com/release_link.apk",
+            quality = ReleaseQuality.DEPRECATED,
+        )
+
+        coEvery { releaseService.latest(any()) } returns release
+
+        val result = getApplicationRelease.await(
+            GetApplicationRelease.Arguments(
+                isPreview = false,
+                commitCount = 0,
+                versionName = "v1.0.0",
+                repository = "test",
+                forceCheck = false,
+                includePrerelease = false,
+            ),
+        )
+
+        result shouldBe GetApplicationRelease.Result.NoNewUpdate
+    }
+
+    @Test
+    fun `When service returns null expect no new update`() = runTest {
+        every { preference.get() } returns 0
+        every { preference.set(any()) }.answers { }
+
+        coEvery { releaseService.latest(any()) } returns null
+
+        val result = getApplicationRelease.await(
+            GetApplicationRelease.Arguments(
+                isPreview = false,
+                commitCount = 0,
+                versionName = "v1.0.0",
+                repository = "test",
+                forceCheck = false,
+                includePrerelease = false,
+            ),
+        )
+
+        result shouldBe GetApplicationRelease.Result.NoNewUpdate
+    }
 }