Scroll position lost on pop state (when clicking browser back/forward buttons)

[blimpmason]

Hey @ryanwiemer — I've been using bits of your code from this example to implement page transitions on my Gatsby projects and it works great!

I've noticed in the last few months is that scroll restoration no longer works on popstate, despite this logic:

gatsby-using-page-transitions/gatsby-browser.js

Lines 10 to 24 in c4a5226

	export const shouldUpdateScroll = ({
	routerProps: { location },
	getSavedScrollPosition
	}) => {
	if (location.action === "PUSH") {
	window.setTimeout(() => window.scrollTo(0, 0), transitionDelay);
	} else {
	const savedPosition = getSavedScrollPosition(location);
	window.setTimeout(
	() => window.scrollTo(...(savedPosition || [0, 0])),
	transitionDelay
	);
	}
	return false;
	};

I was wondering if you'd come across that issue and had any thoughts on a workaround.

Possibly related to this issue: gatsbyjs/gatsby#23842 ?

[blimpmason]

When I console.log(savedPosition) within the else statement, I get 0, though I see all the scroll position entries saved in local storage.

[ryanwiemer]

@blimpmason was this ever fixed on Gatsby's side? This seems like an upstream issue that Gatsby needs to resolve.

[blimpmason]

@ryanwiemer you're absolutely right, and I submitted an issue to Gatsby in October along with minimal reproduction demos and repos. The issue been acknowledged and I think there's an outstanding pull request that addresses it: gatsbyjs/gatsby#27349