ci(workflow): add TSV validation step and improve error handling

Adds qsv installation and TSV validation to CI workflow to catch data format issues early. Refactors tsv-check script to fail fast on first error and include schema validation.

Author: PaulRBerg

.github/workflows/update-price-data.yml

@@ -11,21 +11,17 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v5
-
-      - name: Get app installation token
-        id: app-token
-        uses: actions/create-github-app-token@v2
-        with:
-          app-id: ${{ vars.APP_ID }}
-          owner: ${{ github.repository_owner }}
-          private-key: ${{ secrets.APP_PRIVATE_KEY }}
-          repositories: price-data,indexers,accounting
-
       - name: Set up devkit
         uses: sablier-labs/devkit/actions/setup@main
         with:
           package-manager: bun
 
+      - name: Install qsv
+        uses: cargo-bins/cargo-binstall@main
+
+      - name: Install qsv binary
+        run: cargo binstall --no-confirm qsv
+
       - name: Fetch cryptocurrency prices
         env:
           COINGECKO_API_KEY_1: ${{ secrets.COINGECKO_API_KEY_1 }}
@@ -37,6 +33,9 @@ jobs:
           CURRENCY_FREAKS_API_KEY: ${{ secrets.CURRENCY_FREAKS_API_KEY }}
         run: just fetch-forex
 
+      - name: Validate TSV files
+        run: just tsv-check
+
       - name: Verify changes
         run: | #shell
           if ! git diff --quiet -- crypto/ forex/; then
@@ -47,6 +46,15 @@ jobs:
             exit 1
           fi
 
+      - name: Get app installation token
+        id: app-token
+        uses: actions/create-github-app-token@v2
+        with:
+          app-id: ${{ vars.APP_ID }}
+          owner: ${{ github.repository_owner }}
+          private-key: ${{ secrets.APP_PRIVATE_KEY }}
+          repositories: price-data,indexers,accounting
+
       - name: Generate timestamp
         id: timestamp
         run: echo "human=$(date '+%B %d, %Y at %H:%M UTC')" >> $GITHUB_OUTPUT

justfile

@@ -35,7 +35,6 @@ YEAR := ```
 # ---------------------------------------------------------------------------- #
 
 # Fetch cryptocurrency prices from CoinGecko
-[group("scripts")]
 @fetch-crypto currency year=YEAR month=MONTH *args:
     na tsx src/cli/fetch-crypto.ts \
         --currency {{ currency }} \
@@ -44,19 +43,17 @@ YEAR := ```
         {{ args }}
 
 # Fetch daily GBP/USD forex rates from CurrencyFreaks
-[group("scripts")]
 @fetch-forex year=YEAR month=MONTH *args:
     na tsx src/cli/fetch-forex.ts \
         --year {{ year }} \
         --month {{ month }} \
         {{ args }}
 
 # Check TSV files
-[group("lint")]
+[group("checks")]
 [script]
 tsv-check:
     echo "Validating TSV files..."
-    has_error=0
     for file in data/transactions/*/*.tsv; do
         # Skip validation artifact files
         case "$file" in
@@ -68,13 +65,10 @@ tsv-check:
         # Skip if no files match the pattern
         [ -e "$file" ] || continue
 
-        if ! qsv validate "$file" &>/dev/null; then
-            echo "❌ $file is invalid"
+        if ! qsv validate "$file" data/transactions/schema.json > /dev/null 2>&1; then
+            echo "❌ Validation failed for: $file"
             echo "See $file.validation-errors.tsv for details"
-            has_error=1
+            exit 1
         fi
     done
-    if [ $has_error -eq 1 ]; then
-        exit 1
-    fi
     echo "✅ All TSV files are valid"