fix(readers): support windows-style exclude patterns (#710)

Signed-off-by: gigel <gigel@users.noreply.github.com>
Co-authored-by: gigel <gigel@users.noreply.github.com>

Author: Carla232

pkg/readers/common.go

@@ -2,6 +2,7 @@ package readers
 
 import (
 	"path/filepath"
+	"strings"
 
 	"github.com/bmatcuk/doublestar/v4"
 
@@ -14,23 +15,31 @@ type exclusionMatcher struct {
 	Exclusions []string
 }
 
+func normalizeGlobCandidate(value string) string {
+	return strings.ReplaceAll(value, "\\", "/")
+}
+
 func newPathExclusionMatcher(exclusions []string) *exclusionMatcher {
 	return &exclusionMatcher{
 		Exclusions: exclusions,
 	}
 }
 
 func (ex *exclusionMatcher) Match(term string) bool {
+	normalizedTerm := normalizeGlobCandidate(term)
+
 	for _, exclusionPattern := range ex.Exclusions {
+		normalizedPattern := normalizeGlobCandidate(exclusionPattern)
+
 		// Try matching in current form first
-		if m, err := doublestar.Match(exclusionPattern, term); err == nil && m {
+		if m, err := doublestar.Match(normalizedPattern, normalizedTerm); err == nil && m {
 			return true
 		}
 
 		// If term is relative and pattern is absolute, convert term to absolute
 		if !filepath.IsAbs(term) && filepath.IsAbs(exclusionPattern) {
 			if abs, err := filepath.Abs(term); err == nil {
-				if m, err := doublestar.Match(exclusionPattern, abs); err == nil && m {
+				if m, err := doublestar.Match(normalizedPattern, normalizeGlobCandidate(abs)); err == nil && m {
 					return true
 				}
 			}
@@ -39,7 +48,7 @@ func (ex *exclusionMatcher) Match(term string) bool {
 		// If term is absolute and pattern is relative, convert pattern to absolute
 		if filepath.IsAbs(term) && !filepath.IsAbs(exclusionPattern) {
 			if abs, err := filepath.Abs(exclusionPattern); err == nil {
-				if m, err := doublestar.Match(abs, term); err == nil && m {
+				if m, err := doublestar.Match(normalizeGlobCandidate(abs), normalizedTerm); err == nil && m {
 					return true
 				}
 			}

pkg/readers/common_test.go

@@ -1,6 +1,7 @@
 package readers
 
 import (
+	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -117,3 +118,18 @@ func TestExcludedPath(t *testing.T) {
 		})
 	}
 }
+
+func TestExcludedPathWindowsStylePatternAgainstAbsolutePath(t *testing.T) {
+	absPath, err := filepath.Abs(filepath.Join("pkg", "readers"))
+	assert.NoError(t, err)
+
+	matcher := newPathExclusionMatcher([]string{`pkg\*`})
+	assert.True(t, matcher.Match(absPath))
+}
+
+func TestExcludedPathWindowsStyleSeparators(t *testing.T) {
+	matcher := newPathExclusionMatcher([]string{`pkg\readers\**`})
+
+	assert.True(t, matcher.Match(`pkg\readers\fixtures\requirements.txt`))
+	assert.False(t, matcher.Match(`cmd\vet\main.go`))
+}