Skip to content

Commit 9694049

Browse files
authored
skips analytics init for root or help cmd/flags (#603)
* skips analytics init for root or help cmd/flags * fix analytics init only on non-help cmds
1 parent e9d3da0 commit 9694049

2 files changed

Lines changed: 14 additions & 5 deletions

File tree

internal/analytics/analytics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ var (
2424
globalDistinctId string
2525
)
2626

27-
func init() {
27+
func Init() {
2828
if isTelemetryDisabled() {
2929
return
3030
}

main.go

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,19 @@ func main() {
6565
Use: "vet [OPTIONS] COMMAND [ARG...]",
6666
Short: "[ Establish trust in open source software supply chain ]",
6767
TraverseChildren: true,
68+
PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
69+
// Skip analytics for bare `vet` (no subcommand selected)
70+
if cmd == cmd.Root() && len(args) == 0 {
71+
return nil
72+
}
73+
74+
// Initialize analytics for non-help commands
75+
analytics.Init()
76+
analytics.TrackCommandRun()
77+
analytics.TrackCI()
78+
79+
return nil
80+
},
6881
RunE: func(cmd *cobra.Command, args []string) error {
6982
if len(args) == 0 {
7083
return cmd.Help()
@@ -73,7 +86,6 @@ func main() {
7386
return fmt.Errorf("vet: %s is not a valid command", args[0])
7487
},
7588
}
76-
7789
cmd.PersistentFlags().BoolVarP(&verbose, "verbose", "v", false, "Show verbose logs")
7890
cmd.PersistentFlags().BoolVarP(&debug, "debug", "d", false, "Show debug logs")
7991
cmd.PersistentFlags().BoolVarP(&noBanner, "no-banner", "", false, "Do not display the vet banner")
@@ -106,9 +118,6 @@ func main() {
106118

107119
defer analytics.Close()
108120

109-
analytics.TrackCommandRun()
110-
analytics.TrackCI()
111-
112121
if err := cmd.Execute(); err != nil {
113122
os.Exit(1)
114123
}

0 commit comments

Comments
 (0)