Skip to content

Commit d272234

Browse files
committed
fix(reporter): remove broken --report-console reporter
The interactive console table reporter was broken and redundant with --report-summary. Per maintainer feedback on #612, remove the flag, implementation, and documentation references. Fixes #612 Signed-off-by: syf2211 <syf2211@users.noreply.github.com>
1 parent 7993641 commit d272234

4 files changed

Lines changed: 0 additions & 162 deletions

File tree

docs/reporting.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ vet query --from ./scan-data \
109109
Run `vet scan -h` to see the complete list of reporters and options:
110110

111111
- `--report-summary` - Console summary (default)
112-
- `--report-console` - Interactive table output
113112
- `--report-sarif` - SARIF format
114113
- `--report-json` - JSON format
115114
- `--report-markdown` - Detailed markdown

pkg/reporter/console.go

Lines changed: 0 additions & 137 deletions
This file was deleted.

query.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ var (
2424
queryPolicyExpression string
2525
queryPolicySuiteFile string
2626
queryLoadDirectory string
27-
queryEnableConsoleReport bool
2827
queryEnableSummaryReport bool
2928
querySummaryReportMaxAdvice int
3029
querySummaryReportGroupByDirectDeps bool
@@ -82,8 +81,6 @@ func newQueryCommand() *cobra.Command {
8281
"Generated exceptions are valid till")
8382
cmd.Flags().StringVarP(&queryExceptionsFilter, "exceptions-filter", "", "",
8483
"Generate exception records for packages matching filter")
85-
cmd.Flags().BoolVarP(&queryEnableConsoleReport, "report-console", "", false,
86-
"Minimal summary of package manifest")
8784
cmd.Flags().BoolVarP(&queryEnableSummaryReport, "report-summary", "", false,
8885
"Show an actionable summary based on scan data")
8986
cmd.Flags().IntVarP(&querySummaryReportMaxAdvice, "report-summary-max-advice", "", 5,
@@ -230,15 +227,6 @@ func internalStartQuery() error {
230227
analyzers = append(analyzers, task)
231228
}
232229

233-
if queryEnableConsoleReport {
234-
rp, err := reporter.NewConsoleReporter()
235-
if err != nil {
236-
return err
237-
}
238-
239-
reporters = append(reporters, rp)
240-
}
241-
242230
if queryEnableSummaryReport {
243231
rp, err := reporter.NewSummaryReporter(reporter.SummaryReporterConfig{
244232
MaxAdvice: querySummaryReportMaxAdvice,

scan.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ var (
7070
markdownReportPath string
7171
markdownSummaryReportPath string
7272
jsonReportPath string
73-
consoleReport bool
7473
summaryReport bool
7574
summaryReportMaxAdvice int
7675
summaryReportGroupByDirectDeps bool
@@ -203,8 +202,6 @@ func newScanCommand() *cobra.Command {
203202
"Generate consolidated markdown report to file")
204203
cmd.Flags().StringVarP(&markdownSummaryReportPath, "report-markdown-summary", "", "",
205204
"Generate consolidate summary in markdown")
206-
cmd.Flags().BoolVarP(&consoleReport, "report-console", "", false,
207-
"Print a report to the console")
208205
cmd.Flags().BoolVarP(&summaryReport, "report-summary", "", true,
209206
"Print a summary report with actionable advice")
210207
cmd.Flags().IntVarP(&summaryReportMaxAdvice, "report-summary-max-advice", "", 5,
@@ -618,15 +615,6 @@ func internalStartScan() error {
618615
}
619616

620617
reporters := []reporter.Reporter{}
621-
if consoleReport {
622-
rp, err := reporter.NewConsoleReporter()
623-
if err != nil {
624-
return err
625-
}
626-
627-
reporters = append(reporters, rp)
628-
}
629-
630618
if summaryReport {
631619
rp, err := reporter.NewSummaryReporter(reporter.SummaryReporterConfig{
632620
MaxAdvice: summaryReportMaxAdvice,

0 commit comments

Comments
 (0)