You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[envpool] Fix Linux test workflow compatibility (#330)
## Summary
- Problem: the Linux Bazel test workflow regressed on modern toolchains
because the repo was picking up unsupported Bazel/Python/JAX/compiler
combinations and a few third-party assumptions no longer held.
- Scope: pin the Bazel test path back to a compatible Bazel 6 plus
Python 3.10 toolchain, add small compiler and third-party compatibility
fixes, and treat Atari XLA tests as optional when the current JAX build
no longer exposes the legacy translation API.
- Outcome: the full Linux remote test workflow passes on `dev-0`; no
GitHub workflow changes are included in this PR.
This keeps the fix surface narrow while restoring the repo's Linux test
workflow on a modern Linux environment.
## Technical Details
- Approach: restore the known-good Bazel/Python toolchain shape for
Bazel builds, patch a few compile and runtime incompatibilities, and
fail soft only for the legacy optional XLA test path.
- Code pointers:
- `Makefile`: routes Bazel commands through Bazelisk pinned to Bazel 6
and adds the checked-in `.bazelversion`.
- `envpool/workspace1.bzl` and `envpool/pip.bzl`: register and use a
Python 3.10 Bazel toolchain and avoid the conflicting foreign-cc
pkg-config toolchain.
- `envpool/core/spec.h` and `third_party/ale/ale.BUILD`: fix newer GCC
and C++ compilation breakages.
- `envpool/python/xla_template.py` and
`envpool/atari/atari_envpool_test.py`: convert the removed JAX legacy
translation API into an explicit runtime error and skip only the
affected Atari XLA tests.
- `envpool/vizdoom/vizdoom_pretrain_test.py` and
`envpool/minigrid/minigrid_align_test.py`: fix Linux test regressions
exposed by the updated dependency set.
- Notes: release and GitHub workflow changes are intentionally left out
of this PR.
## Test Plan
### Automated
- `brix ssh dev-0 -C -- 'bash -il -c "/tmp/envpool_dev_bazel_test.sh"'`:
`Executed 18 out of 30 tests: 30 tests pass.`
### Suggested Manual
- `brix ssh dev-0 -C -- 'bash -il -c "cd /tmp/envpool-bazel-compat &&
USE_BAZEL_VERSION=6.0.0 bazelisk test --test_output=all
--distdir=/tmp/bazel-dist //envpool/atari:atari_envpool_test
--config=test --spawn_strategy=local --color=yes"'`: verify the optional
XLA path still skips cleanly with the current JAX version.
0 commit comments