Skip to content

Commit 8b8d973

Browse files
hobostayTest User
andauthored
fix(setup): correct has_ext_modules method parameter name (#417)
## Summary Fix the method parameter name from to in class. ## Root Cause In line 33: The parameter should be to follow Python method conventions. This is inconsistent with defined just above it on line 29, and with the parent class . While functionally equivalent (Python doesn't enforce parameter naming), this: - Confuses linters and type checkers (pylint R0201, mypy) - Is inconsistent with the rest of the codebase - Makes the code harder to read ## Test plan - [x] Verify still works - [x] Verify wheel build process is unaffected Co-authored-by: Test User <test@example.com>
1 parent c033950 commit 8b8d973

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def is_pure(self) -> bool:
3030
"""Return `False` because EnvPool ships extension modules."""
3131
return False
3232

33-
def has_ext_modules(foo) -> bool:
33+
def has_ext_modules(self) -> bool:
3434
"""Report that EnvPool has extension modules."""
3535
return True
3636

0 commit comments

Comments
 (0)