Skip to content

Commit 402b9bc

Browse files
authored
Merge branch 'main' into lkostrowski/drop-legacy-deps
2 parents bf748ae + d58c9dd commit 402b9bc

16 files changed

Lines changed: 78 additions & 89 deletions

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
"@saleor/macaw-ui-next": "npm:@saleor/macaw-ui@1.4.2",
9595
"@sentry/react": "^8.55.0",
9696
"@sentry/vite-plugin": "^2.23.1",
97-
"@types/faker": "^5.5.9",
9897
"@uiw/react-color-hue": "0.0.34",
9998
"@uiw/react-color-saturation": "0.0.34",
10099
"apollo-upload-client": "^17.0.0",
@@ -107,7 +106,6 @@
107106
"dompurify": "^3.4.8",
108107
"downshift": "^6.1.12",
109108
"editorjs-inline-tool": "^0.4.0",
110-
"faker": "^5.5.3",
111109
"fast-array-diff": "^0.2.0",
112110
"fuse.js": "^6.6.2",
113111
"graphiql": "^2.4.7",
@@ -150,6 +148,7 @@
150148
"@changesets/cli": "2.31.0",
151149
"@editorjs/embed": "2.7.6",
152150
"@eslint/js": "^9.39.1",
151+
"@faker-js/faker": "^10.5.0",
153152
"@formatjs/cli": "^4.8.4",
154153
"@graphql-codegen/cli": "5.0.7",
155154
"@graphql-codegen/fragment-matcher": "5.1.0",

playwright/data/addresses.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import faker from "faker";
1+
import { faker } from "@faker-js/faker";
22

33
export type AddressType = {
44
addressUK: AddressFieldsType;
@@ -21,21 +21,21 @@ export type AddressFieldsType = {
2121

2222
export const ADDRESS: AddressType = {
2323
addressUS: {
24-
firstName: faker.name.firstName(),
25-
lastName: faker.name.lastName(),
26-
companyName: faker.company.companyName(),
24+
firstName: faker.person.firstName(),
25+
lastName: faker.person.lastName(),
26+
companyName: faker.company.name(),
2727
phone: "+12125771133",
2828
addressLine1: "69 W 9th Street",
29-
addressLine2: faker.address.county(),
29+
addressLine2: faker.location.county(),
3030
city: "New York",
3131
zip: "10001",
3232
country: "United States of America",
3333
countryArea: "New York",
3434
},
3535
addressPL: {
36-
firstName: faker.name.firstName(),
37-
lastName: faker.name.lastName(),
38-
companyName: faker.company.companyName(),
36+
firstName: faker.person.firstName(),
37+
lastName: faker.person.lastName(),
38+
companyName: faker.company.name(),
3939
phone: "+48225042123",
4040
addressLine1: "Teczowa",
4141
addressLine2: "7",
@@ -45,9 +45,9 @@ export const ADDRESS: AddressType = {
4545
countryArea: "",
4646
},
4747
addressUK: {
48-
firstName: faker.name.firstName(),
49-
lastName: faker.name.lastName(),
50-
companyName: faker.company.companyName(),
48+
firstName: faker.person.firstName(),
49+
lastName: faker.person.lastName(),
50+
companyName: faker.company.name(),
5151
phone: "+445556667777",
5252
addressLine1: "Albert Street",
5353
addressLine2: "78/2",

playwright/pages/dialogs/editAttributeValueDialog.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { Page } from "@playwright/test";
2-
import faker from "faker";
2+
import { faker } from "@faker-js/faker";
33

44
export class EditAttributeValueDialog {
55
readonly page: Page;

playwright/pages/discountsPage.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { DeleteRuleDialog } from "@dialogs/deleteRuleDialog";
44
import { BasePage } from "@pages/basePage";
55
import { PromotionRuleDialog } from "@pages/dialogs/promotionRuleDialog";
66
import type { Page } from "@playwright/test";
7-
import { date } from "faker";
7+
import { faker } from "@faker-js/faker";
88

99
export class DiscountsPage extends BasePage {
1010
deleteDiscountDialog: DeleteDiscountDialog;
@@ -66,7 +66,7 @@ export class DiscountsPage extends BasePage {
6666
}
6767

6868
async typeStartDate() {
69-
await this.startDateInput.fill(date.recent().toISOString().split("T")[0]);
69+
await this.startDateInput.fill(faker.date.recent().toISOString().split("T")[0]);
7070
}
7171

7272
async typeStartHour() {
@@ -78,7 +78,7 @@ export class DiscountsPage extends BasePage {
7878
}
7979

8080
async typeEndDate() {
81-
await this.endDateInput.fill(date.future().toISOString().split("T")[0]);
81+
await this.endDateInput.fill(faker.date.future().toISOString().split("T")[0]);
8282
}
8383

8484
async typeEndHour() {

playwright/pages/pageElements/metadataSeoPage.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import type { Page } from "@playwright/test";
2-
import * as faker from "faker";
2+
import { faker } from "@faker-js/faker";
33

4-
const metaDataName = `e2e-metaDataName-${faker.datatype.number()}`;
5-
const metaDataValue = `e2e-metaDataValue-${faker.datatype.number()}`;
6-
const privateMetaDataName = `e2e-privateMetaDataName-${faker.datatype.number()}`;
7-
const privateMetaDataValue = `e2e-privateMetaDataValue-${faker.datatype.number()}`;
8-
const seoEngineTitle = `e2e-seoSlugTitle-${faker.datatype.number()}`;
9-
const seoDescriptionText = `e2e-seoSlugDescription-${faker.datatype.number()}`;
4+
const metaDataName = `e2e-metaDataName-${faker.number.int(99999)}`;
5+
const metaDataValue = `e2e-metaDataValue-${faker.number.int(99999)}`;
6+
const privateMetaDataName = `e2e-privateMetaDataName-${faker.number.int(99999)}`;
7+
const privateMetaDataValue = `e2e-privateMetaDataValue-${faker.number.int(99999)}`;
8+
const seoEngineTitle = `e2e-seoSlugTitle-${faker.number.int(99999)}`;
9+
const seoDescriptionText = `e2e-seoSlugDescription-${faker.number.int(99999)}`;
1010

1111
export class MetadataSeoPage {
1212
readonly page: Page;

playwright/pages/productPage.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ import { ExportProductsDialog } from "@pages/dialogs/exportProductsDialog";
77
import { MetadataSeoPage } from "@pages/pageElements/metadataSeoPage";
88
import { RightSideDetailsPage } from "@pages/pageElements/rightSideDetailsSection";
99
import { type Page } from "@playwright/test";
10-
import * as faker from "faker";
10+
import { faker } from "@faker-js/faker";
1111
import path from "path";
1212

13-
const productName = `e2e-productName-${faker.datatype.number()}`;
14-
const productDescription = `e2e-productDescription-${faker.datatype.number()}`;
13+
const productName = `e2e-productName-${faker.number.int(99999)}`;
14+
const productDescription = `e2e-productDescription-${faker.number.int(99999)}`;
1515

1616
export class ProductPage extends BasePage {
1717
readonly metadataSeoPage: MetadataSeoPage;

playwright/tests/attributes.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ATTRIBUTES } from "@data/e2eTestData";
22
import { AttributesPage } from "@pages/attributesPage";
33
import { ConfigurationPage } from "@pages/configurationPage";
44
import { expect } from "@playwright/test";
5-
import faker from "faker";
5+
import { faker } from "@faker-js/faker";
66
import { test } from "utils/testWithPermission";
77

88
test.use({ permissionName: "admin" });
@@ -15,7 +15,7 @@ test.beforeEach(({ page }) => {
1515
configurationPage = new ConfigurationPage(page);
1616
});
1717

18-
const SALEOR_124_uuid = faker.datatype.uuid();
18+
const SALEOR_124_uuid = faker.string.uuid();
1919
const attributeClasses: ("PRODUCT_TYPE" | "PAGE_TYPE")[] = ["PRODUCT_TYPE", "PAGE_TYPE"];
2020

2121
for (const attr of attributeClasses) {
@@ -53,7 +53,7 @@ for (const attr of attributeClasses) {
5353
}
5454
}
5555

56-
const SALEOR_125_uuid = faker.datatype.uuid();
56+
const SALEOR_125_uuid = faker.string.uuid();
5757

5858
for (const attr of attributeClasses) {
5959
for (const type of ATTRIBUTES.attributeTypesWithoutAbilityToAddValues.names) {
@@ -91,7 +91,7 @@ for (const attr of attributeClasses) {
9191
}
9292
}
9393

94-
const SALEOR_126_uuid = faker.datatype.uuid();
94+
const SALEOR_126_uuid = faker.string.uuid();
9595

9696
for (const attr of attributeClasses) {
9797
for (const entity of ATTRIBUTES.attributeReferencesEntities.names) {

playwright/tests/customers.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { DeleteAddressDialog } from "@pages/dialogs/deleteAddressDialog";
77
import { AddressForm } from "@pages/forms/addressForm";
88
import { GiftCardsPage } from "@pages/giftCardsPage";
99
import { expect } from "@playwright/test";
10-
import faker from "faker";
10+
import { faker } from "@faker-js/faker";
1111
import { test } from "utils/testWithPermission";
1212

1313
test.use({ permissionName: "admin" });
@@ -29,8 +29,8 @@ test.beforeEach(({ page }) => {
2929
});
3030

3131
test("TC: SALEOR_199 Create customer #e2e #customer", async () => {
32-
const firstName = faker.name.firstName();
33-
const lastName = faker.name.lastName();
32+
const firstName = faker.person.firstName();
33+
const lastName = faker.person.lastName();
3434
const note = faker.lorem.sentence();
3535
const email = faker.internet.email();
3636

@@ -57,8 +57,8 @@ test("TC: SALEOR_199 Create customer #e2e #customer", async () => {
5757
});
5858

5959
test("TC: SALEOR_200 As an admin I should not be able to create customer with duplicated email #e2e #customer", async () => {
60-
const firstName = faker.name.firstName();
61-
const lastName = faker.name.lastName();
60+
const firstName = faker.person.firstName();
61+
const lastName = faker.person.lastName();
6262
const note = faker.lorem.sentence();
6363

6464
await customersPage.goToCustomersListView();
@@ -79,8 +79,8 @@ test("TC: SALEOR_200 As an admin I should not be able to create customer with du
7979
});
8080

8181
test("TC: SALEOR_201 Update customer account info #e2e #customer", async () => {
82-
const firstName = faker.name.firstName();
83-
const lastName = faker.name.lastName();
82+
const firstName = faker.person.firstName();
83+
const lastName = faker.person.lastName();
8484
const email = faker.internet.email();
8585
const note = faker.lorem.sentence();
8686

@@ -212,7 +212,7 @@ test("TC: SALEOR_210 Delete customer's address #e2e #customer", async () => {
212212
});
213213

214214
test("TC: SALEOR_207 Issue a new gift card for the customer #e2e #customer", async () => {
215-
const amount = faker.datatype.number(1000).toPrecision(2).toString();
215+
const amount = faker.number.int(1000).toPrecision(2).toString();
216216

217217
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
218218
await customersPage.clickIssueNewGiftCard();

playwright/tests/discounts.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { CATEGORIES, CHANNELS, COLLECTIONS, DISCOUNTS, PRODUCTS } from "@data/e2eTestData";
22
import { DiscountsPage } from "@pages/discountsPage";
33
import { expect } from "@playwright/test";
4-
import faker from "faker";
4+
import { faker } from "@faker-js/faker";
55
import { test } from "utils/testWithPermission";
66

77
test.use({ permissionName: "admin" });

playwright/tests/navigation.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { AddNavigationMenuItemDialog } from "@pages/dialogs/addNavigationMenuIte
33
import { NavigationDetailsPage } from "@pages/navigationDetailsPage";
44
import { NavigationPage } from "@pages/navigationPage";
55
import { expect } from "@playwright/test";
6-
import faker from "faker";
6+
import { faker } from "@faker-js/faker";
77
import { test } from "utils/testWithPermission";
88

99
test.use({ permissionName: "admin" });
@@ -24,14 +24,14 @@ test("TC: SALEOR_194 Should create a new menu navigation with menu item #navigat
2424
await navigation.createMenuButton.click();
2525
await expect(navigation.createMenuDialogTitle).toBeVisible();
2626

27-
const menuName = faker.random.word();
27+
const menuName = faker.lorem.word();
2828

2929
await navigation.addNavigationMenuDialog.typeNewMenuName(menuName);
3030
await navigation.addNavigationMenuDialog.clickSaveButton();
3131
await navigationDetailsPage.clickCreateNewMenuItem();
3232
await expect(navigationDetailsPage.addMenuItemDialog).toBeVisible();
3333

34-
const menuItemName = faker.random.word();
34+
const menuItemName = faker.lorem.word();
3535

3636
await addNavigationMenuItemDialog.typeMenuItemName(menuItemName);
3737
await addNavigationMenuItemDialog.selectLinkTypeOption("Categories");
@@ -49,7 +49,7 @@ test.skip("TC: SALEOR_198 Should update existing menu #navigation #e2e", async (
4949

5050
const menuItemToBeUpdated = NAVIGATION_ITEMS.navigationMenuToBeUpdated.menuItems[0];
5151
const menuItemToBeDeleted = NAVIGATION_ITEMS.navigationMenuToBeUpdated.menuItems[1];
52-
const newItemName = faker.random.word();
52+
const newItemName = faker.lorem.word();
5353

5454
await navigationDetailsPage.clickEditMenuItemButton(menuItemToBeUpdated.name);
5555
await addNavigationMenuItemDialog.typeMenuItemName(newItemName);
@@ -61,7 +61,7 @@ test.skip("TC: SALEOR_198 Should update existing menu #navigation #e2e", async (
6161
await navigationDetailsPage.clickCreateNewMenuItem();
6262
await expect(navigationDetailsPage.addMenuItemDialog).toBeVisible();
6363

64-
const menuItemName = faker.random.word();
64+
const menuItemName = faker.lorem.word();
6565

6666
await addNavigationMenuItemDialog.typeMenuItemName(menuItemName);
6767
await addNavigationMenuItemDialog.selectLinkTypeOption("Categories");
@@ -75,7 +75,7 @@ test.skip("TC: SALEOR_198 Should update existing menu #navigation #e2e", async (
7575
await expect(navigationDetailsPage.menuItemList).toContainText(newItemName);
7676
await expect(navigationDetailsPage.menuItemList).not.toContainText(menuItemToBeDeleted.name);
7777

78-
const newName = faker.random.word();
78+
const newName = faker.lorem.word();
7979

8080
await navigationDetailsPage.fillName(newName);
8181
await navigationDetailsPage.clickSaveButton();

0 commit comments

Comments
 (0)