refactor: migrate Button and Accordion to macaw-ui-next, delete legacy filter ui (#6922)

* refactor: migrate Button and Accordion to macaw-ui-next

Replace the last Material-UI / legacy macaw-ui `Button`, `Accordion` and
`AccordionSummary` usages with their macaw-ui-next equivalents.

Legacy macaw `Button` defaulted to `variant="tertiary"`; macaw-ui-next
defaults to `primary`, so bare `<Button>` call sites now pass the variant
explicitly to keep their appearance.

`components/Button/Button` existed only to turn `href` into a react-router
`Link`. Its single consumer (NotFoundPage) always received internal URLs,
so the wrapper is dropped in favour of `as={Link}`.

FilterContent's accordion now relies on Radix single+collapsible behaviour,
which removes the manual open/close handler and the two makeStyles blocks
that only existed to strip Material-UI's default styling.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: use secondary variant for migrated legacy Buttons

Screenshot comparison against main showed legacy macaw's default
variant ("tertiary") renders as a bordered button, not a borderless one.
macaw-ui-next's "tertiary" has no border, so the first pass silently
flattened Remove/Unassign/Edit/Discard into bare text. "secondary" is
the bordered equivalent.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor: remove the legacy filter-select UI

Every <ListFilters> call site passes type="expression-filter", so the
"old-filter-select" branch — FiltersSelect and the FilterContent tree
below it — has been unreachable since the expression filters rollout
finished. Last functional change to it was #1995 (Apr 2022); everything
after that was sweeping refactors.

knip does not flag this on its own: .knip.json sets storybook and jest as
entry points, so the tree's own stories and tests kept it alive in the
graph. Deleting those first and re-running knip to convergence yields the
24 files removed here, including Alert/InlineAlert whose only consumer
was FilterErrorsList.

Filter/types.ts and Filter/utils.ts stay: list views still build a
filterStructure and pass filterDependency into their datagrids.
FilterProps loses its export for the same reason — nothing imports it now
that ListFilters is single-shape, but FilterPageProps still extends it.

Verified: tsc clean, knip clean, and all nine list pages render their
filter bar with no page errors.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore: extract messages, drop orphaned filter types, add changeset

Removing the legacy filter UI orphaned 12 translation messages (key-value
field labels, filter range separators, filter validation errors) — dropped
by re-running extract-messages. The live Filters button keeps its own id
(FNpv6K) and is unaffected.

ValidationErrorCode and InvalidFilters only surfaced as unused once the
commit hook stripped the now-dead imports from Filter/utils.ts, so knip
caught them a round late.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: lkostrowski

.changeset/macaw-next-button-accordion.md

@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Buttons and accordions across the dashboard now use the current design system instead of the legacy one. The change is visual only — some buttons are slightly smaller with rounder corners, and their labels are a touch bolder. Affected surfaces: the 404 page, translation field rows, list toolbars (Remove/Unassign), and the product export dialog.

locale/defaultMessages.json

@@ -1308,10 +1308,6 @@
     "context": "price or ordered products",
     "string": "Price"
   },
-  "34F7Jk": {
-    "context": "filter range separator",
-    "string": "and"
-  },
   "34QbG4": {
     "context": "hint under returns and refunds card on order settings",
     "string": "Choose model types used as refund and return reason references."
@@ -5238,10 +5234,6 @@
   "HlEpii": {
     "string": "Search Engine Title"
   },
-  "HnVtSS": {
-    "context": "search",
-    "string": "No results"
-  },
   "HnZCl7": {
     "context": "search input placeholder",
     "string": "Search tax countries"
@@ -5296,10 +5288,6 @@
     "context": "tab name",
     "string": "All attributes"
   },
-  "I+UwqI": {
-    "context": "is filter range or value",
-    "string": "equal to"
-  },
   "I+XcO2": {
     "context": "voucher save composition segment for staged country assignments",
     "string": "Countries"
@@ -5415,10 +5403,6 @@
     "context": "Amount error message",
     "string": "Amount must be bigger than 0"
   },
-  "ILgbKN": {
-    "context": "key-value field button add more key-value pairs",
-    "string": "Add more"
-  },
   "ILhY5I": {
     "context": "voucher save composition segment for start/end availability window",
     "string": "Schedule"
@@ -7255,10 +7239,6 @@
   "PKjitS": {
     "string": "{count, plural, one {Warehouse assigned} other {# warehouses assigned}}"
   },
-  "PLCwT/": {
-    "context": "search results",
-    "string": "Show more"
-  },
   "PLX6FH": {
     "context": "sum of all manual refunds for transaction",
     "string": "Manual refund"
@@ -7359,10 +7339,6 @@
     "context": "Button to remove all staged generator creates",
     "string": "Clear all"
   },
-  "Pnj+JH": {
-    "context": "key-value field input",
-    "string": "Value"
-  },
   "Pp/7T7": {
     "string": "{counter,plural,one{Are you sure you want to delete this category?} other{Are you sure you want to delete {displayQuantity} categories?}}"
   },
@@ -7511,10 +7487,6 @@
     "context": "link label in usage empty state",
     "string": "model type"
   },
-  "QBxN6z": {
-    "context": "is filter range or value",
-    "string": "between"
-  },
   "QDxJib": {
     "string": "Fulfill"
   },
@@ -8606,10 +8578,6 @@
   "US3IPU": {
     "string": "Search Engine Description"
   },
-  "USS3Q7": {
-    "context": "filters error messages unknown error",
-    "string": "Unknown error occurred"
-  },
   "UVDfTs": {
     "context": "discount type shipping",
     "string": "Shipping"
@@ -9516,10 +9484,6 @@
     "context": "PDP schematic full-bleed legend section header",
     "string": "Where attributes show"
   },
-  "XkX56I": {
-    "context": "filters error messages value required",
-    "string": "Choose a value"
-  },
   "XkqRxe": {
     "context": "Save composition segment for a pending customer type change",
     "string": "customer type"
@@ -11396,10 +11360,6 @@
     "context": "customer types section name",
     "string": "Customer Types"
   },
-  "erC44f": {
-    "context": "filters error messages dependencies missing",
-    "string": "Filter requires other filters: {dependencies}"
-  },
   "erZXUi": {
     "context": "channel order setting label",
     "string": "Confirm new orders automatically"
@@ -14529,10 +14489,6 @@
     "context": "no countries found in assign countries dialog",
     "string": "No countries found"
   },
-  "q1shey": {
-    "context": "key-value field input",
-    "string": "Key"
-  },
   "q3IT3J": {
     "context": "extensions list has been removed",
     "string": "Extension removed"
@@ -17270,9 +17226,6 @@
   "zSDfq0": {
     "string": "Use flat tax rate"
   },
-  "zSOvI0": {
-    "string": "Filters"
-  },
   "zT1CvH": {
     "string": "Learn more about {extendingSaleor}"
   },

src/attributes/components/AttributeListPage/AttributeListPage.tsx

@@ -159,8 +159,7 @@ const AttributeListPage = ({
       </TopNav>
       <Box display="flex" flexDirection="column" __minWidth={0} __minHeight={0}>
         <Box paddingTop={4}>
-          <ListFilters<AttributeFilterKeys>
-            type="expression-filter"
+          <ListFilters
             initialSearch={initialSearch}
             onSearchChange={onSearchChange}
             searchPlaceholder={intl.formatMessage({

src/collections/components/CollectionListPage/CollectionListPage.tsx

@@ -144,7 +144,6 @@ const CollectionListPage = ({
       <DashboardCard>
         {
           <ListFilters
-            type="expression-filter"
             initialSearch={initialSearch}
             onSearchChange={onSearchChange}
             searchPlaceholder={intl.formatMessage({

src/components/Alert/InlineAlert.tsx

@@ -1,77 +1,46 @@
-import { type FilterErrorMessages, type IFilter } from "@dashboard/components/Filter/types";
-import { type FilterProps, type SearchPageProps } from "@dashboard/types";
+import { type SearchPageProps } from "@dashboard/types";
 import { Box } from "@saleor/macaw-ui-next";
 import { type ReactNode } from "react";
 
 import { ExpressionFilterPanel, ExpressionFilters } from "./components/ExpressionFilters";
-import { FiltersSelect } from "./components/FiltersSelect";
 import { LegacyFiltersPresetsAlert } from "./components/LegacyFiltersPresetsAlert";
 import SearchInput from "./components/SearchInput";
 
-interface NewFilterProps extends SearchPageProps {
-  type: "expression-filter";
+interface ListFiltersProps extends SearchPageProps {
   searchPlaceholder: string;
   actions?: ReactNode;
   showSearchTooltip?: boolean;
 }
 
-interface OldFiltersProps<TKeys extends string = string>
-  extends FilterProps<TKeys>,
-    SearchPageProps {
-  type?: "old-filter-select";
-  searchPlaceholder: string;
-  actions?: ReactNode;
-  showSearchTooltip?: boolean;
-  filterStructure?: IFilter<TKeys>;
-  errorMessages?: FilterErrorMessages<TKeys>;
-}
-
-type ListFiltersProps<TKeys extends string = string> = NewFilterProps | OldFiltersProps<TKeys>;
-
-export const ListFilters = <TFilterKeys extends string = string>({
+export const ListFilters = ({
   initialSearch,
   searchPlaceholder,
   onSearchChange,
   actions,
   showSearchTooltip,
-  ...props
-}: ListFiltersProps<TFilterKeys>) => {
-  const isExpressionFilter = props.type === "expression-filter";
-
-  return (
-    <>
-      {isExpressionFilter && <LegacyFiltersPresetsAlert />}
-      <Box display="flex" flexDirection="column" gap={3} paddingBottom={2} paddingX={6}>
-        <Box display="grid" __gridTemplateColumns="auto 1fr" gap={4}>
-          <Box display="flex" alignItems="center" gap={4}>
-            {isExpressionFilter ? (
-              <ExpressionFilters />
-            ) : (
-              <FiltersSelect<TFilterKeys>
-                errorMessages={props.errorMessages}
-                menu={props.filterStructure!}
-                currencySymbol={props.currencySymbol}
-                onFilterAdd={props.onFilterChange!}
-                onFilterAttributeFocus={props.onFilterAttributeFocus}
-              />
-            )}
-            <Box __width="360px">
-              <SearchInput
-                initialSearch={initialSearch}
-                placeholder={searchPlaceholder}
-                onSearchChange={onSearchChange}
-                showSearchTooltip={showSearchTooltip}
-              />
-            </Box>
-          </Box>
-          <Box display="flex" justifyContent="flex-end" alignItems="center">
-            {actions}
+}: ListFiltersProps) => (
+  <>
+    <LegacyFiltersPresetsAlert />
+    <Box display="flex" flexDirection="column" gap={3} paddingBottom={2} paddingX={6}>
+      <Box display="grid" __gridTemplateColumns="auto 1fr" gap={4}>
+        <Box display="flex" alignItems="center" gap={4}>
+          <ExpressionFilters />
+          <Box __width="360px">
+            <SearchInput
+              initialSearch={initialSearch}
+              placeholder={searchPlaceholder}
+              onSearchChange={onSearchChange}
+              showSearchTooltip={showSearchTooltip}
+            />
           </Box>
         </Box>
-        {isExpressionFilter ? <ExpressionFilterPanel /> : null}
+        <Box display="flex" justifyContent="flex-end" alignItems="center">
+          {actions}
+        </Box>
       </Box>
-    </>
-  );
-};
+      <ExpressionFilterPanel />
+    </Box>
+  </>
+);
 
 ListFilters.displayName = "FilterBar";