Apply code review suggestions

Author: IKarbowiak

src/auth/views/Login.tsx

@@ -112,18 +112,16 @@ const LoginView = ({ params }: LoginViewProps) => {
     };
   }, []);
 
+  const isMain = isMainSchema();
+  const passwordLoginMode = externalAuthenticationsStaging?.shop?.passwordLoginMode;
+  const passwordLoginEnabled = isMain || passwordLoginMode === PasswordLoginModeEnum.ENABLED;
+
   return (
     <LoginPage
       errors={errors}
       disabled={authenticating}
       externalAuthentications={externalAuthentications?.shop?.availableExternalAuthentications}
-      passwordLoginEnabled={
-        isMainSchema() ||
-        (externalAuthenticationsStaging?.shop?.passwordLoginMode !==
-          PasswordLoginModeEnum.DISABLED &&
-          externalAuthenticationsStaging?.shop?.passwordLoginMode !==
-            PasswordLoginModeEnum.CUSTOMERS_ONLY)
-      }
+      passwordLoginEnabled={passwordLoginEnabled}
       loading={externalAuthenticationsLoading || authenticating}
       onExternalAuthentication={handleRequestExternalAuthentication}
       onSubmit={handleSubmit}

src/fragments/shop.staging.ts

@@ -2,27 +2,7 @@ import { gql } from "@apollo/client";
 
 export const shopFragment = gql`
   fragment ShopStaging on Shop {
-    companyAddress {
-      ...Address
-    }
-    countries {
-      code
-      country
-    }
-    customerSetPasswordUrl
-    defaultMailSenderAddress
-    defaultMailSenderName
-    description
-    domain {
-      host
-    }
-    name
-    reserveStockDurationAnonymousUser
-    reserveStockDurationAuthenticatedUser
-    limitQuantityPerCheckout
-    enableAccountConfirmationByEmail
-    useLegacyUpdateWebhookEmission
-    preserveAllAddressFields
+    ...Shop
     passwordLoginMode
   }
 `;

src/siteSettings/components/SiteSettingsPage/SiteSettingsPage.tsx

@@ -100,6 +100,7 @@ const SiteSettingsPage = (props: SiteSettingsPageProps) => {
     emailConfirmation: shop?.enableAccountConfirmationByEmail ?? false,
     useLegacyUpdateWebhookEmission: shop?.useLegacyUpdateWebhookEmission ?? true,
     preserveAllAddressFields: shop?.preserveAllAddressFields ?? false,
+    // Force staging type to access the new field. Once field is available in main schema, casting should be removed.
     passwordLoginMode:
       (isStagingSchema() && (shop as SiteSettingsStagingQuery["shop"])?.passwordLoginMode) ||
       PasswordLoginModeEnum.ENABLED,