Address code review

Author: mirekm

src/orders/components/OrderDiscountModal/messages.ts

@@ -16,12 +16,12 @@ export const messages = defineMessages({
     defaultMessage: "Invalid value",
     description: "value input helper text",
   },
-  valueBiggerThatPrice: {
+  valueBiggerThanPrice: {
     defaultMessage: "Cannot be higher than the price",
     id: "VIdXPy",
     description: "value input helper text",
   },
-  valueBiggerThat100: {
+  valueBiggerThan100: {
     defaultMessage: "Cannot be higher than 100%",
     id: "zHx85l",
     description: "value input helper text",

src/orders/components/OrderDiscountModal/useDiscountForm.ts

@@ -114,8 +114,8 @@ export const useDiscountForm = ({ maxPrice, existingDiscount, isOpen }: UseDisco
 
     if (parsedValue > topAmount) {
       return isPercentage
-        ? intl.formatMessage(messages.valueBiggerThat100)
-        : intl.formatMessage(messages.valueBiggerThatPrice);
+        ? intl.formatMessage(messages.valueBiggerThan100)
+        : intl.formatMessage(messages.valueBiggerThanPrice);
     }
 
     return null;

src/orders/components/OrderLineMetadataDialog/OrderLineMetadataDialog.test.tsx

@@ -107,9 +107,12 @@ describe("OrderLineMetadataDialog", () => {
     );
 
     // Assert
-    expect(screen.getByText(new RegExp(mockData.quantity.toString()))).toBeInTheDocument();
-    expect(screen.getByText(new RegExp(mockData.variant.name))).toBeInTheDocument();
-    expect(screen.getByText(new RegExp(mockData.productSku))).toBeInTheDocument();
+    expect(
+      screen.getByText(`${mockData.productName} · ${mockData.variant.name}`),
+    ).toBeInTheDocument();
+    expect(
+      screen.getByText(`SKU: ${mockData.productSku} · Qty: ${mockData.quantity}`),
+    ).toBeInTheDocument();
   });
 
   it("renders product thumbnail correctly", () => {