Skip to content

Commit 4077ae4

Browse files
marcelmamulamarcelmamula
authored
Merge pull request #162 from sap-linuxlab/dev
Merge dev to main for release 1.4.0
2 parents 9225637 + 9a19ab9 commit 4077ae4

139 files changed

Lines changed: 10045 additions & 8657 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.ansible-lint‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,17 @@ skip_list:
3333
- schema
3434
# Allow templating inside name because it creates more detailed output:
3535
- name[template]
36-
# Allow command tasks without defining changed_when
37-
- no-changed-when
38-
# Allow tasks that could be replaced by handlers
39-
- no-handler
40-
# Disable jinja formatting check
41-
- jinja[spacing]
42-
# Removing these skips would require refactoring of most roles
43-
- yaml[comments]
44-
- yaml[line-length]
45-
- no-tabs
46-
# - var-naming[no-jinja]
47-
# Rule for variable naming is required because of stricter linting requirements.
48-
- var-naming[no-role-prefix]
36+
37+
# # Allow command tasks without defining changed_when
38+
# - no-changed-when
39+
# # Allow tasks that could be replaced by handlers
40+
# - no-handler
41+
# # Disable jinja formatting check
42+
# - jinja[spacing]
43+
# # Removing these skips would require refactoring of most roles
44+
# - yaml[comments]
45+
# - yaml[line-length]
46+
# - no-tabs
47+
# # - var-naming[no-jinja]
48+
# # Rule for variable naming is required because of stricter linting requirements.
49+
# - var-naming[no-role-prefix]

‎.yamllint.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# SPDX-License-Identifier: Apache-2.0
12
---
23
# Based on ansible-lint config
34
extends: default
@@ -7,7 +8,9 @@ rules:
78
brackets: {max-spaces-inside: 1, level: error}
89
# colons: {max-spaces-after: -1, level: error}
910
# commas: {max-spaces-after: -1, level: error}
10-
comments: disable
11+
comments:
12+
require-starting-space: false
13+
min-spaces-from-content: 1
1114
comments-indentation: disable
1215
# document-start: disable
1316
# empty-lines: {max: 3, level: error}
@@ -19,3 +22,6 @@ rules:
1922
# new-lines: {type: unix}
2023
# trailing-spaces: disable
2124
truthy: disable
25+
octal-values:
26+
forbid-implicit-octal: true
27+
forbid-explicit-octal: true

‎CHANGELOG.rst‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,29 @@ community.sap\_infrastructure Release Notes
44

55
.. contents:: Topics
66

7+
v1.4.0
8+
======
9+
10+
Release Summary
11+
---------------
12+
13+
Refactored all roles following best practices, complete linting and compatibility with ansible-core 2.20.
14+
15+
Minor Changes
16+
--------
17+
- sap_vm_provision - Rework role with best practices to align with project (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/155)
18+
- sap_vm_provision - Update ibmcloud PowerVS image dictionaries (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/152)
19+
- sap_vm_provision - Add MS Azure disclaimer about reliability of azure collection (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/159)
20+
- sap_hypervisor_node_preconfigure - Refactor role and conform to linting (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/156)
21+
- sap_vm_temp_vip - Refactor variables and improve logic for skipping hosts (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/157)
22+
23+
Bugfixes
24+
--------
25+
- sap_vm_provision - Fix deprecated network parameter for amazon.aws.ec2_instance (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/153)
26+
- sap_vm_provision - Fix adding /etc/hosts for all in play not just itself (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/160)
27+
- sap_vm_temp_vip - Fix NoneType broadcast variable (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/154)
28+
29+
730
v1.3.1
831
======
932

‎CONTRIBUTORS.md‎

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,53 +25,55 @@ For specific role maintainers, see the `README.md` file in the corresponding rol
2525
| Name | Commits | Lines Changed | Last Commit |
2626
| ---- | ------- | ------------- | ----------- |
2727
| [Sean Freeman](https://github.com/sean-freeman) | 100 | 27358 | 2025-06-20 |
28-
| [Marcel Mamula](https://github.com/marcelmamula) | 60 | 6100 | 2026-01-07 |
28+
| [Marcel Mamula](https://github.com/marcelmamula) | 82 | 26609 | 2026-03-20 |
2929
| [Nils Koenig](https://github.com/newkit) | 59 | 3971 | 2026-01-12 |
3030
| [Bernd Finger](https://github.com/berndfinger) | 7 | 285 | 2025-02-25 |
3131
| [Geetika Kapoor](https://github.com/geetikakay) | 6 | 124 | 2025-11-14 |
32+
| Edmund Häfele | 1 | 7 | 2026-01-13 |
3233
| [Janine Fuchs](https://github.com/ja9fuchs) | 1 | 2 | 2024-09-03 |
3334
| [Markus Koch](https://github.com/rhmk) | 1 | 35 | 2024-08-27 |
3435

3536
## Contributions by Role
3637

37-
### Role: sap_vm_verify
38+
### Role: sap_hypervisor_node_preconfigure
3839

3940
| Name | Commits | Lines Changed | Last Commit |
4041
| ---- | ------- | ------------- | ----------- |
41-
| [Sean Freeman](https://github.com/sean-freeman) | 2 | 504 | 2025-02-13 |
42-
| [Marcel Mamula](https://github.com/marcelmamula) | 1 | 1 | 2025-08-01 |
42+
| [Nils Koenig](https://github.com/newkit) | 31 | 1847 | 2025-12-23 |
43+
| [Marcel Mamula](https://github.com/marcelmamula) | 6 | 1583 | 2026-03-16 |
44+
| [Geetika Kapoor](https://github.com/geetikakay) | 6 | 123 | 2025-11-14 |
45+
| [Sean Freeman](https://github.com/sean-freeman) | 2 | 1870 | 2024-05-07 |
4346

44-
### Role: sap_vm_temp_vip
47+
### Role: sap_vm_preconfigure
4548

4649
| Name | Commits | Lines Changed | Last Commit |
4750
| ---- | ------- | ------------- | ----------- |
48-
| [Marcel Mamula](https://github.com/marcelmamula) | 13 | 1149 | 2025-08-15 |
49-
| [Sean Freeman](https://github.com/sean-freeman) | 6 | 607 | 2024-08-30 |
51+
| [Marcel Mamula](https://github.com/marcelmamula) | 2 | 17 | 2025-09-30 |
52+
| [Sean Freeman](https://github.com/sean-freeman) | 1 | 594 | 2024-02-01 |
5053

5154
### Role: sap_vm_provision
5255

5356
| Name | Commits | Lines Changed | Last Commit |
5457
| ---- | ------- | ------------- | ----------- |
5558
| [Sean Freeman](https://github.com/sean-freeman) | 85 | 22396 | 2025-05-26 |
56-
| [Marcel Mamula](https://github.com/marcelmamula) | 34 | 3496 | 2026-01-07 |
59+
| [Marcel Mamula](https://github.com/marcelmamula) | 49 | 22264 | 2026-03-20 |
5760
| [Nils Koenig](https://github.com/newkit) | 23 | 1136 | 2026-01-12 |
5861
| [Bernd Finger](https://github.com/berndfinger) | 3 | 5 | 2025-02-19 |
62+
| Edmund Häfele | 1 | 7 | 2026-01-13 |
5963
| [Janine Fuchs](https://github.com/ja9fuchs) | 1 | 2 | 2024-09-03 |
6064
| [Markus Koch](https://github.com/rhmk) | 1 | 35 | 2024-08-27 |
6165

62-
### Role: sap_hypervisor_node_preconfigure
66+
### Role: sap_vm_temp_vip
6367

6468
| Name | Commits | Lines Changed | Last Commit |
6569
| ---- | ------- | ------------- | ----------- |
66-
| [Nils Koenig](https://github.com/newkit) | 31 | 1847 | 2025-12-23 |
67-
| [Geetika Kapoor](https://github.com/geetikakay) | 6 | 123 | 2025-11-14 |
68-
| [Marcel Mamula](https://github.com/marcelmamula) | 3 | 455 | 2025-08-20 |
69-
| [Sean Freeman](https://github.com/sean-freeman) | 2 | 1870 | 2024-05-07 |
70+
| [Marcel Mamula](https://github.com/marcelmamula) | 15 | 1637 | 2026-02-19 |
71+
| [Sean Freeman](https://github.com/sean-freeman) | 6 | 607 | 2024-08-30 |
7072

71-
### Role: sap_vm_preconfigure
73+
### Role: sap_vm_verify
7274

7375
| Name | Commits | Lines Changed | Last Commit |
7476
| ---- | ------- | ------------- | ----------- |
75-
| [Marcel Mamula](https://github.com/marcelmamula) | 2 | 17 | 2025-09-30 |
76-
| [Sean Freeman](https://github.com/sean-freeman) | 1 | 594 | 2024-02-01 |
77+
| [Sean Freeman](https://github.com/sean-freeman) | 2 | 504 | 2025-02-13 |
78+
| [Marcel Mamula](https://github.com/marcelmamula) | 1 | 1 | 2025-08-01 |
7779

‎changelogs/changelog.yaml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,3 +132,18 @@ releases:
132132
- sap_hypervisor_node_preconfigure - Add check for webhook endpoint availability (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/142)
133133
bugfixes:
134134
- sap_hypervisor_node_preconfigure/kubevirt_vm - Fix installation of CNV operator (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/148)
135+
136+
1.4.0:
137+
release_date: '2026-03-24'
138+
changes:
139+
release_summary: Refactored all roles following best practices, complete linting and compatibility with ansible-core 2.20
140+
minor_changes:
141+
- sap_vm_provision - Rework role with best practices to align with project (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/155)
142+
- sap_vm_provision - Update ibmcloud PowerVS image dictionaries (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/152)
143+
- sap_vm_provision - Add MS Azure disclaimer about reliability of azure collection (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/159)
144+
- sap_hypervisor_node_preconfigure - Refactor role and conform to linting (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/156)
145+
- sap_vm_temp_vip - Refactor variables and improve logic for skipping hosts (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/157)
146+
bugfixes:
147+
- sap_vm_provision - Fix deprecated network parameter for amazon.aws.ec2_instance (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/153)
148+
- sap_vm_provision - Fix adding /etc/hosts for all in play not just itself (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/160)
149+
- sap_vm_temp_vip - Fix NoneType broadcast variable (https://github.com/sap-linuxlab/community.sap_infrastructure/pull/154)

‎galaxy.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace: community
1010
name: sap_infrastructure
1111

1212
# The version of the collection. Must be compatible with semantic versioning
13-
version: 1.3.1
13+
version: 1.4.0
1414

1515
# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
1616
readme: README.md

‎playbooks/sample-sap-hypervisor-redhat-ocp-virt-preconfigure.yml‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,16 @@
66
sap_hypervisor_node_preconfigure_platform: redhat_ocp_virt
77
tasks:
88

9-
- name: Use kubeconfig file specified in environment variable K8S_AUTH_KUBECONFIG | KUBECONFIG if sap_hypervisor_node_preconfigure_ocp_kubeconfig_path is not defined.
9+
# Use kubeconfig file specified in environment variable K8S_AUTH_KUBECONFIG | KUBECONFIG
10+
# if sap_hypervisor_node_preconfigure_ocp_kubeconfig_path is not defined.
11+
- name: Use kubeconfig file specified in environment variable if sap_hypervisor_node_preconfigure_ocp_kubeconfig_path is not defined.
12+
ansible.builtin.set_fact:
13+
sap_hypervisor_node_preconfigure_kubeconfig:
14+
"{{ lookup('env', 'K8S_AUTH_KUBECONFIG') | default(lookup('env', 'KUBECONFIG'), true) }}"
1015
when: >
1116
sap_hypervisor_node_preconfigure_kubeconfig is not defined or
1217
sap_hypervisor_node_preconfigure_kubeconfig == None or
1318
sap_hypervisor_node_preconfigure_kubeconfig == ''
14-
ansible.builtin.set_fact:
15-
sap_hypervisor_node_preconfigure_kubeconfig: "{{ lookup('env', 'K8S_AUTH_KUBECONFIG') | default(lookup('env', 'KUBECONFIG'), true) }}"
1619
1720
- name: Ensure that kubeconfig is set
1821
ansible.builtin.assert:

‎playbooks/sample-sap-vm-provision-redhat-ocpv.yml‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,24 @@
1919

2020
- name: Save ansible_user as execution_host user
2121
ansible.builtin.set_fact:
22-
__sap_vm_provision_kubevirt_vm_register_execution_host_user: "{{ ansible_user | default(lookup('env', 'USER')) }}"
22+
sap_vm_provision_kubevirt_vm_execution_host_user: "{{ ansible_user | default(lookup('env', 'USER')) }}"
2323

2424
- name: Create Tempdir
2525
ansible.builtin.tempfile:
2626
state: directory
2727
suffix: "_sap_vm_provision_kubevirt_vm"
28-
register: __sap_vm_provision_kubevirt_vm_register_tmpdir
28+
register: __sap_vm_provision_register_kubevirt_vm_tmpdir
2929

30-
- name: Use kubeconfig file specified in environment variable K8S_AUTH_KUBECONFIG | KUBECONFIG if sap_vm_provision_kubevirt_vm_kubeconfig_path is not defined
30+
# Use kubeconfig file specified in environment variable K8S_AUTH_KUBECONFIG | KUBECONFIG
31+
# if sap_hypervisor_node_preconfigure_ocp_kubeconfig_path is not defined.
32+
- name: Use kubeconfig file specified in environment variable if sap_hypervisor_node_preconfigure_ocp_kubeconfig_path is not defined.
33+
ansible.builtin.set_fact:
34+
sap_vm_provision_kubevirt_vm_kubeconfig:
35+
"{{ lookup('env', 'K8S_AUTH_KUBECONFIG') | default(lookup('env', 'KUBECONFIG'), true) }}"
3136
when: >
3237
sap_vm_provision_kubevirt_vm_kubeconfig is not defined or
3338
sap_vm_provision_kubevirt_vm_kubeconfig == None or
3439
sap_vm_provision_kubevirt_vm_kubeconfig == ''
35-
ansible.builtin.set_fact:
36-
sap_vm_provision_kubevirt_vm_kubeconfig: "{{ lookup('env', 'K8S_AUTH_KUBECONFIG') | default(lookup('env', 'KUBECONFIG'), true) }}"
3740
3841
- name: Ensure that kubeconfig is set
3942
ansible.builtin.assert:
@@ -50,8 +53,8 @@
5053
sap_vm_provision_iac_type: ansible
5154
sap_vm_provision_iac_platform: kubevirt_vm
5255
sap_vm_provision_execution_host: "{{ sap_vm_provision_execution_host }}"
53-
__sap_vm_provision_kubevirt_vm_register_execution_host_user: "{{ __sap_vm_provision_kubevirt_vm_register_execution_host_user }}"
54-
__sap_vm_provision_kubevirt_vm_register_tmpdir: "{{ __sap_vm_provision_kubevirt_vm_register_tmpdir }}"
56+
sap_vm_provision_kubevirt_vm_execution_host_user: "{{ sap_vm_provision_kubevirt_vm_execution_host_user }}"
57+
__sap_vm_provision_register_kubevirt_vm_tmpdir: "{{ __sap_vm_provision_register_kubevirt_vm_tmpdir }}"
5558
sap_vm_provision_kubevirt_vm_kubeconfig: "{{ sap_vm_provision_kubevirt_vm_kubeconfig }}"
5659
loop: "{{ sap_vm_provision_kubevirt_vm_host_specifications_dictionary[sap_vm_provision_host_specification_plan].keys() }}"
5760

@@ -75,4 +78,4 @@
7578
delegate_to: "{{ sap_vm_provision_execution_host }}"
7679
ansible.builtin.file:
7780
state: absent
78-
path: "{{ __sap_vm_provision_kubevirt_vm_register_tmpdir.path }}"
81+
path: "{{ __sap_vm_provision_register_kubevirt_vm_tmpdir.path }}"

‎roles/sap_hypervisor_node_preconfigure/.yamllint.yml‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎roles/sap_hypervisor_node_preconfigure/defaults/main.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1+
# SPDX-License-Identifier: Apache-2.0
12
---
23

34
# Define which hypervisor platform to use (String).
45
# Available options: redhat_ocp_virt, redhat_rhel_kvm
56
sap_hypervisor_node_preconfigure_platform: ''
7+
8+
# TODO: Add more platforms like: ibmpower_phyp, vmware_vsphere

0 commit comments

Comments
 (0)