Merge pull request #1119 from marcelmamula/linting_ha

sap_ha_pacemaker_cluster:: Fix linting errors

Author: marcelmamula

roles/sap_ha_pacemaker_cluster/tasks/construct_final_hacluster_vars.yml

@@ -29,6 +29,8 @@
 # __sap_ha_pacemaker_cluster_resource_primitives    ha_cluster_resource_primitives
 # __sap_ha_pacemaker_cluster_corosync_totem                  ha_cluster_totem
 
+# NOTE: noqa var-naming[no-role-prefix] is required when setting variable names for other roles.
+
 # Combines SBD stonith options with ha_cluster if it was not imported as extra var.
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Include SBD config into 'ha_cluster'"  # noqa jinja[spacing]
   when:
@@ -43,102 +45,102 @@
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster'"
   when: __sap_ha_pacemaker_cluster_ha_cluster is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster: "{{ __sap_ha_pacemaker_cluster_ha_cluster }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_cluster_name'"
   when: __sap_ha_pacemaker_cluster_cluster_name is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_cluster_name: "{{ __sap_ha_pacemaker_cluster_cluster_name }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_cluster_properties'"
   when: __sap_ha_pacemaker_cluster_cluster_properties is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_cluster_properties: "{{ __sap_ha_pacemaker_cluster_cluster_properties }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_resource_defaults'"
   when: __sap_ha_pacemaker_cluster_resource_defaults is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_resource_defaults: "{{ __sap_ha_pacemaker_cluster_resource_defaults }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_resource_operation_defaults'"
   when: __sap_ha_pacemaker_cluster_resource_operation_defaults is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_resource_operation_defaults: "{{ __sap_ha_pacemaker_cluster_resource_operation_defaults }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_constraints_colocation'"
   when: __sap_ha_pacemaker_cluster_constraints_colocation is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_constraints_colocation: "{{ __sap_ha_pacemaker_cluster_constraints_colocation }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_constraints_location'"
   when: __sap_ha_pacemaker_cluster_constraints_location is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_constraints_location: "{{ __sap_ha_pacemaker_cluster_constraints_location }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_constraints_order'"
   when: __sap_ha_pacemaker_cluster_constraints_order is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_constraints_order: "{{ __sap_ha_pacemaker_cluster_constraints_order }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_extra_packages'"
   when: __sap_ha_pacemaker_cluster_extra_packages is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_extra_packages: "{{ __sap_ha_pacemaker_cluster_extra_packages }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_zypper_patterns'"
   when: __sap_ha_pacemaker_cluster_zypper_patterns is defined and ansible_os_family == 'Suse'
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_zypper_patterns: "{{ __sap_ha_pacemaker_cluster_zypper_patterns }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_fence_agent_packages'"
   when: __sap_ha_pacemaker_cluster_fence_agent_packages is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_fence_agent_packages: "{{ __sap_ha_pacemaker_cluster_fence_agent_packages }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_hacluster_password'"
   when: __sap_ha_pacemaker_cluster_hacluster_user_password is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_hacluster_password: "{{ __sap_ha_pacemaker_cluster_hacluster_user_password }}"
   no_log: true  # secure the credential
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_repos'"
   when: __sap_ha_pacemaker_cluster_repos is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     __ha_cluster_repos: "{{ __sap_ha_pacemaker_cluster_repos }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_resource_clones'"
   when: __sap_ha_pacemaker_cluster_resource_clones is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_resource_clones: "{{ __sap_ha_pacemaker_cluster_resource_clones }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_resource_groups'"
   when: __sap_ha_pacemaker_cluster_resource_groups is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_resource_groups: "{{ __sap_ha_pacemaker_cluster_resource_groups }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_resource_primitives'"
   when: __sap_ha_pacemaker_cluster_resource_primitives is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_resource_primitives: "{{ __sap_ha_pacemaker_cluster_resource_primitives }}"
   no_log: true  # be paranoid, there could be credentials in it
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_totem'"
   when: __sap_ha_pacemaker_cluster_corosync_totem is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_totem: "{{ __sap_ha_pacemaker_cluster_corosync_totem }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_transport'"
   when: __sap_ha_pacemaker_cluster_corosync_transport is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_transport: "{{ __sap_ha_pacemaker_cluster_corosync_transport }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_sbd_options'"
   when: __sap_ha_pacemaker_cluster_sbd_options is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_sbd_options: "{{ __sap_ha_pacemaker_cluster_sbd_options }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_sbd_enabled'"
   when: __sap_ha_pacemaker_cluster_sbd_enabled is defined
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_sbd_enabled: "{{ __sap_ha_pacemaker_cluster_sbd_enabled }}"

roles/sap_ha_pacemaker_cluster/tasks/pre_steps_nwas_cs_ers.yml

@@ -64,7 +64,7 @@
   ansible.builtin.set_fact:
     sap_ha_pacemaker_cluster_instance_service_all_fact: "{{
       (sap_ha_pacemaker_cluster_instance_service_all_fact | d([])
-      + hostvars[task_host_item].sap_ha_pacemaker_cluster_instance_service_node_fact)
+      + hostvars[task_host_item].sap_ha_pacemaker_cluster_instance_service_node_fact | d([]))
       | unique
       }}"
   loop: "{{ ansible_play_hosts }}"