add default deduplicate to download role

Author: marcelmamula

roles/sap_software_download/README.md

@@ -323,11 +323,14 @@ If set to `false`, the role will execute dry run to validate S-User credentials.
 
 ### sap_software_download_deduplicate
 - _Type:_ `string`<br>
+- _Default:_ `last`<br>
 
 Specifies how to handle duplicate file results when using `sap_software_download_files`.<br>
 If multiple files with the same name are found, this setting determines which one to download.<br>
+
 - `first`: Download the first file found<br>
 - `last`: Download the last file found.<br>
+- `''`: No deduplication, will cause an error if multiple files with the same name are found.<br> 
 
 ### sap_software_download_validate_checksum
 - _Type:_ `bool`<br>

roles/sap_software_download/defaults/main.yml

@@ -85,9 +85,10 @@ sap_software_download_ignore_validate_credentials: false
 
 # Specifies how to handle duplicate file results when using `sap_software_download_files`.
 # If multiple files with the same name are found, this setting determines which one to download.
-#   `first`: Download the first file found.
-#   `last`: Download the last file found.
-# sap_software_download_deduplicate: first
+# - `first`: Download the first file found.
+# - `last`: Download the last file found.
+# - `''`: No deduplication, will cause an error if multiple files with the same name are found.
+sap_software_download_deduplicate: last
 
 # Enables checksum validation of existing files present in `sap_software_download_directory`.
 # This does not affect automatic checksum validation of downloaded files.

roles/sap_software_download/meta/argument_spec.yml

@@ -157,8 +157,8 @@ argument_specs:
       sap_software_download_deduplicate:
         type: str
         required: false
-        default: "first"
-        choices: ["first", "last"]
+        default: "last"
+        choices: ["first", "last", ""]
         description:
           - Specifies how to handle duplicate file results when using `sap_software_download_files`.
           - If multiple files with the same name are found, this setting determines which one to download.

roles/sap_software_download/tasks/download_files.yml

@@ -8,7 +8,7 @@
     search_query: "{{ item }}"
     dest: "{{ sap_software_download_directory }}"
     search_alternatives: "{{ sap_software_download_find_alternatives | d(true) }}"
-    deduplicate: "{{ sap_software_download_deduplicate | d('') }}"
+    deduplicate: "{{ sap_software_download_deduplicate }}"
     validate_checksum: "{{ sap_software_download_validate_checksum | d(false) }}"
   # Loop condition acts as when conditional
   loop: "{{ sap_software_download_files if sap_software_download_use_venv | d(true) else [] }}"
@@ -31,7 +31,7 @@
     search_query: "{{ item }}"
     dest: "{{ sap_software_download_directory }}"
     search_alternatives: "{{ sap_software_download_find_alternatives | d(true) }}"
-    deduplicate: "{{ sap_software_download_deduplicate | d('') }}"
+    deduplicate: "{{ sap_software_download_deduplicate }}"
     validate_checksum: "{{ sap_software_download_validate_checksum | d(false) }}"
   # Loop condition acts as when conditional
   loop: "{{ sap_software_download_files if not sap_software_download_use_venv | d(true) else [] }}"
@@ -52,8 +52,16 @@
   ansible.builtin.fail:
     msg: |
       Download failed for following files: {{ __failed_items | map(attribute='item') | list | join(', ') }}
+
+      {% if not sap_software_download_find_alternatives | d(false) %}
       Either set `sap_software_download_find_alternatives` to `true` to search for alternative files
       or ignore this error with `sap_software_download_ignore_file_not_found` set to `true`.
+
+      {% endif %}
+      {% for failed_item in __failed_items %}
+      {{ failed_item.item }}: {{ failed_item.msg | d('') }}
+
+      {% endfor %}
   vars:
     __failed_items: "{{ __sap_software_download_files_results.results
       | selectattr('failed', 'defined') | selectattr('failed', 'true') }}"

roles/sap_software_download/tasks/pre_steps/01_include_variables.yml

@@ -116,8 +116,10 @@
 - name: "Pre-Steps - Verify variable: sap_software_download_deduplicate"
   ansible.builtin.assert:
     that:
-      - sap_software_download_deduplicate in ['first', 'last']
+      - sap_software_download_deduplicate is defined
+      - sap_software_download_deduplicate is string
+      - sap_software_download_deduplicate in ['first', 'last', '']
     fail_msg: |
       Enter valid option for `sap_software_download_deduplicate` variable.
-      Options: first, last
-  when: sap_software_download_deduplicate is defined
+      Options: first, last or empty string ''.
+      NOTE: Empty string will cause an error if multiple files with the same name are found.

roles/sap_software_download/tasks/pre_steps/05_validate_relations.yml

@@ -12,7 +12,7 @@
         search_query: "{{ item }}"
         dest: "{{ sap_software_download_directory }}"
         search_alternatives: "{{ sap_software_download_find_alternatives | d(true) }}"
-        deduplicate: "{{ sap_software_download_deduplicate | d('') }}"
+        deduplicate: "{{ sap_software_download_deduplicate }}"
         dry_run: true
       # Loop condition acts as when conditional
       loop: "{{ sap_software_download_files if sap_software_download_use_venv | d(true) else [] }}"
@@ -37,7 +37,7 @@
         search_query: "{{ item }}"
         dest: "{{ sap_software_download_directory }}"
         search_alternatives: "{{ sap_software_download_find_alternatives | d(true) }}"
-        deduplicate: "{{ sap_software_download_deduplicate | d('') }}"
+        deduplicate: "{{ sap_software_download_deduplicate }}"
         dry_run: true
       # Loop condition acts as when conditional
       loop: "{{ sap_software_download_files if not sap_software_download_use_venv | d(true) else [] }}"