replace tearDown with addCleanup to fix Exception: No serialization profile was specified

Author: marcelmamula

tests/unit/plugins/modules/test_sap_company.py

@@ -14,19 +14,13 @@ def setUp(self):
             'pyrfc': MagicMock(),
             'pyrfc.Connection': MagicMock()
         }
-        self.patcher = patch.dict('sys.modules', self.pyrfc_mock)
-        self.patcher.start()
+        patcher = patch.dict('sys.modules', self.pyrfc_mock)
+        patcher.start()
+        self.addCleanup(patcher.stop)
         super(TestSAPRfcModule, self).setUp()
         from ansible_collections.community.sap_libs.plugins.modules import sap_company
         self.module = sap_company
 
-    def tearDown(self):
-        self.patcher.stop()
-        super(TestSAPRfcModule, self).tearDown()
-
-    def define_rfc_connect(self, mocker):
-        return mocker.patch(self.module.call_rfc_method)
-
     def test_without_required_parameters(self):
         """Failure must occurs when all parameters are missing"""
         with self.assertRaises(AnsibleFailJson):

tests/unit/plugins/modules/test_sap_control_exec.py

@@ -15,19 +15,13 @@ def setUp(self):
             'suds.sudsobject': MagicMock(),
             'suds': MagicMock()
         }
-        self.patcher = patch.dict('sys.modules', self.suds_mock)
-        self.patcher.start()
+        patcher = patch.dict('sys.modules', self.suds_mock)
+        patcher.start()
+        self.addCleanup(patcher.stop)
         super(TestSapcontrolModule, self).setUp()
         from ansible_collections.community.sap_libs.plugins.modules import sap_control_exec
         self.module = sap_control_exec
 
-    def tearDown(self):
-        self.patcher.stop()
-        super(TestSapcontrolModule, self).tearDown()
-
-    def define_rfc_connect(self, mocker):
-        return mocker.patch(self.module.call_rfc_method)
-
     def test_without_required_parameters(self):
         """Failure must occurs when all parameters are missing"""
         with self.assertRaises(AnsibleFailJson):

tests/unit/plugins/modules/test_sap_pyrfc.py

@@ -23,16 +23,13 @@ def setUp(self):
             'pyrfc': MagicMock(),
             'pyrfc.Connection': MagicMock()
         }
-        self.patcher = patch.dict('sys.modules', self.pyrfc_mock)
-        self.patcher.start()
+        patcher = patch.dict('sys.modules', self.pyrfc_mock)
+        patcher.start()
+        self.addCleanup(patcher.stop)
         super(TestSAPRfcModule, self).setUp()
         from ansible_collections.community.sap_libs.plugins.modules import sap_pyrfc
         self.module = sap_pyrfc
 
-    def tearDown(self):
-        self.patcher.stop()
-        super(TestSAPRfcModule, self).tearDown()
-
     def test_without_required_parameters(self):
         """Failure must occurs when all parameters are missing"""
         with self.assertRaises(AnsibleFailJson):

tests/unit/plugins/modules/test_sap_snote.py

@@ -14,19 +14,13 @@ def setUp(self):
             'pyrfc': MagicMock(),
             'pyrfc.Connection': MagicMock()
         }
-        self.patcher = patch.dict('sys.modules', self.pyrfc_mock)
-        self.patcher.start()
+        patcher = patch.dict('sys.modules', self.pyrfc_mock)
+        patcher.start()
+        self.addCleanup(patcher.stop)
         super(TestSAPRfcModule, self).setUp()
         from ansible_collections.community.sap_libs.plugins.modules import sap_snote
         self.module = sap_snote
 
-    def tearDown(self):
-        self.patcher.stop()
-        super(TestSAPRfcModule, self).tearDown()
-
-    def define_rfc_connect(self, mocker):
-        return mocker.patch(self.module.call_rfc_method)
-
     def test_without_required_parameters(self):
         """Failure must occurs when all parameters are missing"""
         with self.assertRaises(AnsibleFailJson):

tests/unit/plugins/modules/test_sap_task_list_execute.py

@@ -16,19 +16,13 @@ def setUp(self):
             'xmltodict': MagicMock(),
             'xmltodict.parse': MagicMock()
         }
-        self.patcher = patch.dict('sys.modules', self.mock_modules)
-        self.patcher.start()
+        patcher = patch.dict('sys.modules', self.mock_modules)
+        patcher.start()
+        self.addCleanup(patcher.stop)
         super(TestSAPRfcModule, self).setUp()
         from ansible_collections.community.sap_libs.plugins.modules import sap_task_list_execute
         self.module = sap_task_list_execute
 
-    def tearDown(self):
-        self.patcher.stop()
-        super(TestSAPRfcModule, self).tearDown()
-
-    def define_rfc_connect(self, mocker):
-        return mocker.patch(self.module.call_rfc_method)
-
     def test_without_required_parameters(self):
         """Failure must occurs when all parameters are missing"""
         with self.assertRaises(AnsibleFailJson):

tests/unit/plugins/modules/test_sap_user.py

@@ -14,19 +14,13 @@ def setUp(self):
             'pyrfc': MagicMock(),
             'pyrfc.Connection': MagicMock()
         }
-        self.patcher = patch.dict('sys.modules', self.pyrfc_mock)
-        self.patcher.start()
+        patcher = patch.dict('sys.modules', self.pyrfc_mock)
+        patcher.start()
+        self.addCleanup(patcher.stop)
         super(TestSAPRfcModule, self).setUp()
         from ansible_collections.community.sap_libs.plugins.modules import sap_user
         self.module = sap_user
 
-    def tearDown(self):
-        self.patcher.stop()
-        super(TestSAPRfcModule, self).tearDown()
-
-    def define_rfc_connect(self, mocker):
-        return mocker.patch(self.module.call_rfc_method)
-
     def test_without_required_parameters(self):
         """Failure must occurs when all parameters are missing"""
         with self.assertRaises(AnsibleFailJson):