Support @forward rules with --migrate-deps (#299)

Author: jathak

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.5.7
+
+* Fix a bug where the `--migrate-deps` flag would not apply to dependencies
+  via `@forward` rules.
+
 ## 2.5.6
 
 * No user-visible changes.

lib/src/migration_visitor.dart

@@ -190,6 +190,16 @@ abstract class MigrationVisitor extends ScopedAstVisitor {
     }
   }
 
+  /// If [migrateDependencies] is enabled, this dependency will be
+  /// migrated before continuing.
+  @override
+  visitForwardRule(ForwardRule node) {
+    super.visitForwardRule(node);
+    if (migrateDependencies) {
+      visitDependency(node.url, node.span);
+    }
+  }
+
   /// Asserts that [value] is not `null` and returns it.
   ///
   /// This is used for fields that are set whenever the migrator is visiting

pubspec.yaml

@@ -1,5 +1,5 @@
 name: sass_migrator
-version: 2.5.6
+version: 2.5.7
 description: A tool for running migrations on Sass files
 homepage: https://github.com/sass/migrator
 

test/migrators/if_function/migrate_deps/README.md

@@ -0,0 +1,5 @@
+These tests are not specific to the `if-function` migrator, and instead designed
+to test the `--migrate-deps` flag.
+
+When the `if-function` migrator is obsoleted and removed, these tests should
+be duplicated for a different migrator.

test/migrators/if_function/migrate_deps/through_forward.hrx

@@ -0,0 +1,15 @@
+<==> arguments
+--migrate-deps
+
+<==> input/entrypoint.scss
+@forward "library";
+
+<==> input/_library.scss
+a {
+  b: if(true, c, d);
+}
+
+<==> output/_library.scss
+a {
+  b: if(sass(true): c; else: d);
+}

test/migrators/if_function/migrate_deps/through_import.hrx

@@ -0,0 +1,15 @@
+<==> arguments
+--migrate-deps
+
+<==> input/entrypoint.scss
+@import "library";
+
+<==> input/_library.scss
+a {
+  b: if(true, c, d);
+}
+
+<==> output/_library.scss
+a {
+  b: if(sass(true): c; else: d);
+}

test/migrators/if_function/migrate_deps/through_use.hrx

@@ -0,0 +1,15 @@
+<==> arguments
+--migrate-deps
+
+<==> input/entrypoint.scss
+@use "library";
+
+<==> input/_library.scss
+a {
+  b: if(true, c, d);
+}
+
+<==> output/_library.scss
+a {
+  b: if(sass(true): c; else: d);
+}