fix: route boot-complete through greenboot-success.target

Healthcheck no longer directly triggers boot-complete.target. Instead:
healthcheck passes -> OnSuccess activates greenboot-success.target ->
success target Requires=boot-complete.target.

This ensures boot-complete.target is only reached through the greenboot
success chain, and greenboot-success.target has no [Install] section.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: say-paul

greenboot-rs.spec

@@ -103,17 +103,14 @@ install -DpZm 0644 usr/lib/systemd/system/greenboot-healthcheck.service.d/10-net
 %post -n %{pkgname}
 %systemd_post greenboot-healthcheck.service
 %systemd_post greenboot-set-rollback-trigger.service
-%systemd_post greenboot-success.target
 
 %preun -n %{pkgname}
 %systemd_preun greenboot-healthcheck.service
 %systemd_preun greenboot-set-rollback-trigger.service
-%systemd_preun greenboot-success.target
 
 %postun -n %{pkgname}
 %systemd_postun greenboot-healthcheck.service
 %systemd_postun greenboot-set-rollback-trigger.service
-%systemd_postun greenboot-success.target
 
 %files -n %{pkgname}
 %license LICENSE LICENSE.dependencies

usr/lib/systemd/system/greenboot-healthcheck.service

@@ -1,19 +1,19 @@
 [Unit]
 Description=Greenboot Health Checks Runner
 Before=boot-complete.target
+OnSuccess=greenboot-success.target
 OnFailureJobMode=fail
 RequiresMountsFor=/boot
 RequiresMountsFor=/etc
 RefuseManualStart=yes
 
 [Service]
 Type=oneshot
-RemainAfterExit=yes
+RemainAfterExit=no
 ExecStart=/usr/libexec/greenboot/greenboot health-check
 Restart=no
 PrivateMounts=yes
 
 [Install]
-RequiredBy=boot-complete.target
 WantedBy=multi-user.target
-Also=greenboot-success.target greenboot-set-rollback-trigger.service
+Also=greenboot-set-rollback-trigger.service

usr/lib/systemd/system/greenboot-success.target

@@ -1,7 +1,3 @@
 [Unit]
 Description=GreenBoot Healthcheck Success Target
-After=greenboot-healthcheck.service
 Requires=boot-complete.target
-
-[Install]
-WantedBy=multi-user.target