ARSN-613: Fix lint and convert createBucket tests to async/await

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: benzekrimaha

lib/storage/metadata/mongoclient/MongoClientInterface.ts

@@ -362,7 +362,7 @@ class MongoClientInterface {
            usersBucket attributes here (see bucketCreation.js line
            36)*/
         const log = this.logger;
-        return this.getBucketAttributes(constants.usersBucket, log, (err, bucket?) => {
+        return this.getBucketAttributes(constants.usersBucket, log, err => {
             if (!err) {
                 return cb();
             }

tests/unit/storage/metadata/mongoclient/MongoClientInterface.spec.js

@@ -398,74 +398,75 @@ describe('MongoClientInterface::createBucket', () => {
         client.client = {};
     }
 
-    it('should return BucketAlreadyExists when metastore entry already exists', done => {
+    function createBucketPromised(bucketName, bucketMD = baseBucket) {
+        return new Promise((resolve, reject) => {
+            client.createBucket(bucketName, bucketMD, logger, err => {
+                if (err) {
+                    return reject(err);
+                }
+                return resolve();
+            });
+        });
+    }
+
+    it('should return BucketAlreadyExists when metastore entry already exists', async () => {
         setupMockClient(false, {
             matchedCount: 1,
             modifiedCount: 1,
             upsertedCount: 0,
         });
-        client.createBucket('test-bucket', baseBucket, logger, err => {
-            assert(err);
-            assert(err.is.BucketAlreadyExists);
-            assert.strictEqual(createCollectionStub.called, false);
-            done();
-        });
+        await assert.rejects(
+            () => createBucketPromised('test-bucket'),
+            err => err?.is?.BucketAlreadyExists,
+        );
+        assert.strictEqual(createCollectionStub.called, false);
     });
 
-    it('should return BucketAlreadyExists when the collection already exists (NamespaceExists)', done => {
+    it('should return BucketAlreadyExists when the collection already exists (NamespaceExists)', async () => {
         setupMockClient(false);
         createCollectionStub.rejects(makeMongoError('NamespaceExists', 48));
-        client.createBucket('test-bucket', baseBucket, logger, err => {
-            assert(err);
-            assert(err.is.BucketAlreadyExists);
-            assert(createCollectionStub.calledOnceWith('test-bucket'));
-            assert.strictEqual(commandStub.called, false);
-            done();
-        });
+        await assert.rejects(
+            () => createBucketPromised('test-bucket'),
+            err => err?.is?.BucketAlreadyExists,
+        );
+        assert(createCollectionStub.calledOnceWith('test-bucket'));
+        assert.strictEqual(commandStub.called, false);
     });
 
-    it('should return InternalError on other createCollection errors', done => {
+    it('should return InternalError on other createCollection errors', async () => {
         setupMockClient(false);
         createCollectionStub.rejects(makeMongoError('HostUnreachable', 6));
-        client.createBucket('test-bucket', baseBucket, logger, err => {
-            assert(err);
-            assert(err.is.InternalError);
-            done();
-        });
+        await assert.rejects(
+            () => createBucketPromised('test-bucket'),
+            err => err?.is?.InternalError,
+        );
     });
 
-    it('should shard the collection after a successful createCollection', done => {
+    it('should shard the collection after a successful createCollection', async () => {
         setupMockClient(true);
-        client.createBucket('test-bucket', baseBucket, logger, err => {
-            assert.ifError(err);
-            assert(createCollectionStub.calledOnceWith('test-bucket'));
-            assert(
-                commandStub.calledOnceWith({
-                    shardCollection: 'test.test-bucket',
-                    key: { _id: 1 },
-                }),
-            );
-            done();
-        });
+        await createBucketPromised('test-bucket');
+        assert(createCollectionStub.calledOnceWith('test-bucket'));
+        assert(
+            commandStub.calledOnceWith({
+                shardCollection: 'test.test-bucket',
+                key: { _id: 1 },
+            }),
+        );
     });
 
-    it('should succeed when the collection is already sharded (AlreadyInitialized)', done => {
+    it('should succeed when the collection is already sharded (AlreadyInitialized)', async () => {
         setupMockClient(true);
         commandStub.rejects(makeMongoError('AlreadyInitialized', 23));
-        client.createBucket('test-bucket', baseBucket, logger, err => {
-            assert.ifError(err);
-            done();
-        });
+        await createBucketPromised('test-bucket');
     });
 
-    it('should return InternalError on other shardCollection errors', done => {
+    it('should return InternalError on other shardCollection errors', async () => {
         setupMockClient(true);
         commandStub.rejects(makeMongoError('HostUnreachable', 6));
-        client.createBucket('test-bucket', baseBucket, logger, err => {
-            assert(err);
-            assert(err.is.InternalError);
-            done();
-        });
+        await assert.rejects(
+            () => createBucketPromised('test-bucket'),
+            err => err?.is?.InternalError,
+        );
     });
 });