fix limits tests v2

Author: tmacro

lib/IAMClient.js

@@ -367,7 +367,7 @@ class VaultClient {
         };
 
         assert(!this.parameterValidation || typeof accountName === 'string',
-            'the account name, should be a string');
+            'the account name should be a string');
         data.AccountName = accountName;
         this.request('POST', '/', true, callback, data);
     }

tests/unit/deleteAccountLimits.js

@@ -31,25 +31,19 @@ describe('IAMClient - deleteAccountLimits', () => {
         });
     });
 
-    it('should call the request method with the correct parameters when accountName is not provided', () => {
+    it('should throw an error when accountName is not provided', () => {
         client = createClient(true);
-        client.deleteAccountLimits(undefined, () => {});
-
-        assert.strictEqual(lastRequestData.method, 'POST');
-        assert.strictEqual(lastRequestData.path, '/');
-        assert.strictEqual(lastRequestData.iamAuthenticate, true);
-        assert.deepStrictEqual(lastRequestData.data, {
-            Action: 'DeleteAccountLimits',
-            Version: '2010-05-08',
-        });
+        assert.throws(() => {
+            client.deleteAccountLimits(undefined, () => {});
+        }, /the account name should be a string/);
     });
 
     it('should throw an error if accountName is not a string', () => {
         client = createClient(true);
         const accountName = 123;
         assert.throws(() => {
             client.deleteAccountLimits(accountName, () => {});
-        }, /the account name, if set, should be a string/);
+        }, /the account name should be a string/);
     });
 
     it('should call the request method when wrong options are provided and parameterValidation is false', () => {

tests/unit/getAccountLimits.js

@@ -32,18 +32,12 @@ describe('GetAccountLimits', () => {
         assert.deepStrictEqual(lastRequestData.data, expectedData);
     });
 
-    it('should call the request method with default parameters when accountName is not provided', () => {
+    it('should throw an error when accountName is not provided', () => {
         client = createClient(true);
         const callback = () => {};
-        client.getAccountLimits(undefined, callback);
-        const expectedData = {
-            Action: 'GetAccountLimits',
-            Version: '2010-05-08',
-        };
-        assert.strictEqual(lastRequestData.method, 'POST');
-        assert.strictEqual(lastRequestData.path, '/');
-        assert.strictEqual(lastRequestData.iamAuthenticate, true);
-        assert.deepStrictEqual(lastRequestData.data, expectedData);
+        assert.throws(() => {
+            client.getAccountLimits(undefined, callback);
+        }, /the account name should be a string/);
     });
 
     it('should throw an error if accountName is not a string', () => {
@@ -52,7 +46,7 @@ describe('GetAccountLimits', () => {
         const callback = () => {};
         assert.throws(() => {
             client.getAccountLimits(accountName, callback);
-        }, /the account name, if set, should be a string/);
+        }, /the account name should be a string/);
     });
 
     it('should not throw an error if accountName is not a string and parameterValidation is false', () => {

tests/unit/getAccountLimitsByCanonicalId.js

@@ -27,12 +27,12 @@ describe('getAccountLimitsByCanonicalIds', () => {
     afterEach('reset spyArg', () => { spyArg = null; });
 
     it('should send request with correct arguments', () => {
-        client.getAccountLimitsByCanonicalIds(canonicalIds, { reqUid});
+        client.getAccountLimitsByCanonicalIds(canonicalIds, opt, mockCB);
         const [method, path, auth, cb, data, reqUid, contentType] = spyArg;
         assert.strictEqual(method, 'GET');
         assert.strictEqual(path, '/');
         assert.strictEqual(auth, false);
-        assert.strictEqual(cb, mockCB);
+        assert.strictEqual(typeof cb, 'function');
         assert.strictEqual(reqUid, opt.reqUid);
         assert.strictEqual(contentType, null);
         assert.deepStrictEqual(