Skip to content

Commit 548e3c7

Browse files
committed
Merge branch 'bugfix/webmcp-explicit-navigation' into q/4
2 parents 7a15c4a + b3fc93b commit 548e3c7

2 files changed

Lines changed: 5 additions & 13 deletions

File tree

CLAUDE.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,8 @@ This is the **Zenko UI**, a React-based web frontend for the Scality Zenko multi
1919
- **Biome** for linting/formatting
2020
- **Jest** + React Testing Library for tests
2121
- **Scality internal deps**: `@scality/core-ui`, `@scality/module-federation`, `@scality/data-browser-library`, `zenkoclient`
22+
23+
## Branch naming
24+
25+
Always prefix branches (and PRs) with `bugfix/` instead of `fix/` — some of our tooling
26+
only picks up the PR when the branch uses that prefix.

src/react/mcpTools/createZenkoS3Tools.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -199,18 +199,6 @@ export function createZenkoS3Tools(
199199
'mcp-s3',
200200
);
201201

202-
// basePath is needed by `autoNavigateAfterOperation` (in the lib's
203-
// generated S3 tools) to land the post-success navigation on the
204-
// host's mounted route — without this it pushes `/buckets/...` raw
205-
// and shell-ui's catch-all redirects to `/data/accounts`. We resolve
206-
// accountName from the cached getAssumableRoles result keyed by the
207-
// roleArn the LLM passed, so this works even when the user is on
208-
// `/` or `/data/accounts` (no account in URL).
209-
const basePath = deriveHostBasePath(
210-
(ctx.selfConfiguration.basePath as string | undefined) ?? '',
211-
{ roleArn },
212-
);
213-
214202
// queryKeyPrefix mirrors what zenko-ui's chat-side DataBrowserProvider
215203
// computes via `computeS3ConfigIdentifier` — the same `cacheKey=roleArn`
216204
// + external zenkoEndpoint + DEFAULT_REGION the panel queries are
@@ -251,7 +239,6 @@ export function createZenkoS3Tools(
251239
},
252240
}),
253241
navigate,
254-
basePath,
255242
// Intentionally omit queryClient: the chat-side data-browser
256243
// panels mount their `useQuery` observers against the library's
257244
// own @tanstack/react-query v5 QueryClient (defaultQueryClient),

0 commit comments

Comments
 (0)