Improve clarity and linting

Author: schemen

manifest.json

@@ -2,7 +2,7 @@
 	"id": "embed-metadata",
 	"name": "Embed Metadata",
 	"version": "0.5.2",
-	"minAppVersion": "0.15.0",
+	"minAppVersion": "1.0.0",
 	"description": "Render frontmatter metadata (Properties) inside your notes with a lightweight inline syntax.",
 	"author": "Schemen",
 	"authorUrl": "https://github.com/schemen",

src/editor-metadata.ts

@@ -506,7 +506,7 @@ function shouldRebuildForChanges(update: ViewUpdate, plugin: EmbedMetadataPlugin
 	const nextFrontmatter = getFrontmatterRange(nextDoc);
 	let needsRebuild = false;
 
-	update.changes.iterChanges((fromA, toA, fromB, toB, inserted) => {
+	update.changes.iterChanges((fromA, toA, fromB, toB, _inserted) => {
 		if (needsRebuild) {
 			return;
 		}
@@ -668,31 +668,23 @@ class MetadataWidget extends WidgetType {
 
 	// Render the replacement widget node for a single syntax marker.
 	toDOM(): HTMLElement {
-		const span = document.createElement("span");
+		const span = window.activeDocument.createElement("span");
 		applyValueStyles(span, this.plugin.settings);
 		let container = span;
 		if (this.markdownStyle.highlight) {
-			const mark = document.createElement("mark");
-			mark.classList.add("cm-highlight");
-			container.appendChild(mark);
+			const mark = container.createEl("mark", {cls: "cm-highlight"});
 			container = mark;
 		}
 		if (this.markdownStyle.strike) {
-			const del = document.createElement("del");
-			del.classList.add("cm-strikethrough");
-			container.appendChild(del);
+			const del = container.createEl("del", {cls: "cm-strikethrough"});
 			container = del;
 		}
 		if (this.markdownStyle.bold) {
-			const strong = document.createElement("strong");
-			strong.classList.add("cm-strong");
-			container.appendChild(strong);
+			const strong = container.createEl("strong", {cls: "cm-strong"});
 			container = strong;
 		}
 		if (this.markdownStyle.italic) {
-			const em = document.createElement("em");
-			em.classList.add("cm-em");
-			container.appendChild(em);
+			const em = container.createEl("em", {cls: "cm-em"});
 			container = em;
 		}
 		renderInlineMarkdown(this.plugin.app, this.sourcePath, container, this.value, this.plugin);

src/markdown-render.ts

@@ -18,8 +18,7 @@ export function renderInlineMarkdown(
 
 	el.textContent = "";
 
-	const temp = document.createElement("span");
-	el.appendChild(temp);
+	const temp = el.createSpan();
 
 	void MarkdownRenderer.render(app, value, temp, sourcePath, component).then(() => {
 		if (!temp.parentElement) {
@@ -57,8 +56,7 @@ export function renderInlineMarkdownText(
 	}
 
 	el.textContent = "";
-	const temp = document.createElement("span");
-	el.appendChild(temp);
+	const temp = el.createSpan();
 
 	void MarkdownRenderer.render(app, value, temp, sourcePath, component).then(() => {
 		if (!temp.parentElement) {

src/metadata-suggest.ts

@@ -62,7 +62,7 @@ export class MetadataSuggest extends EditorSuggest<string> {
 	}
 
 	// Insert the selected key and close the syntax marker if needed.
-	selectSuggestion(value: string, evt: MouseEvent | KeyboardEvent): void {
+	selectSuggestion(value: string, _evt: MouseEvent | KeyboardEvent): void {
 		if (!this.context) {
 			return;
 		}

src/migration-modal.ts

@@ -98,7 +98,7 @@ export class MigrationModal extends Modal {
 				entry.selected = checkbox.checked;
 			});
 
-			row.createEl("span", {
+			row.createSpan({
 				text: `${entry.file.path} (${entry.count})`,
 			});
 		}

versions.json

@@ -7,5 +7,5 @@
 	"0.4.1": "0.15.0",
 	"0.5.0": "0.15.0",
 	"0.5.1": "0.15.0",
-	"0.5.2": "0.15.0"
+	"0.5.2": "1.0.0"
 }