Removed dead endpoint and de-duplicated exam/plugin-version logic (#212)

Author: PianoNic

src/Schuly.API/Controllers/AppController.cs

@@ -31,12 +31,5 @@ public async Task<IActionResult> GetSchoolSystems(CancellationToken cancellation
             var result = await mediator.Send(new GetSchoolSystemsQuery(), cancellationToken);
             return result.ToActionResult();
         }
-
-        [HttpGet("test", Name = "TestEndpointWithAuth")]
-        [ProducesResponseType(StatusCodes.Status200OK)]
-        public IActionResult Test()
-        {
-            return Ok();
-        }
     }
 }

src/Schuly.API/Plugins/PluginManager.cs

@@ -96,20 +96,7 @@ public async Task RemoveAsync(string name, CancellationToken ct = default)
         private static RegistryPlugin? Resolve(IReadOnlyList<RegistryPlugin> index, string name, string? version)
         {
             var entry = index.FirstOrDefault(p => p.Name.Equals(name, StringComparison.OrdinalIgnoreCase));
-            if (entry is null) return null;
-
-            if (!string.IsNullOrWhiteSpace(version) &&
-                !version.Equals("latest", StringComparison.OrdinalIgnoreCase) &&
-                !version.Equals(entry.Version, StringComparison.OrdinalIgnoreCase))
-            {
-                return entry with
-                {
-                    Version = version,
-                    Dll = $"{entry.Name}-v{version}.dll",
-                    Deps = $"{entry.Name}-v{version}-deps.zip",
-                };
-            }
-            return entry;
+            return entry?.WithPinnedVersion(version);
         }
     }
 }

src/Schuly.API/Plugins/PluginRegistry.cs

@@ -13,6 +13,23 @@ public sealed record RegistryPlugin
         [JsonPropertyName("version")] public string Version { get; init; } = "";
         [JsonPropertyName("description")] public string? Description { get; init; }
         [JsonPropertyName("authors")] public string? Authors { get; init; }
+
+        // A pinned version that differs from the index's current one: the registry
+        // keeps every build under dll/<name>-v<ver>.dll, so synthesize the filenames.
+        public RegistryPlugin WithPinnedVersion(string? version)
+        {
+            if (string.IsNullOrWhiteSpace(version) ||
+                version.Equals("latest", StringComparison.OrdinalIgnoreCase) ||
+                version.Equals(Version, StringComparison.OrdinalIgnoreCase))
+                return this;
+
+            return this with
+            {
+                Version = version,
+                Dll = $"{Name}-v{version}.dll",
+                Deps = $"{Name}-v{version}-deps.zip",
+            };
+        }
     }
 
     /// <summary>
@@ -39,24 +56,7 @@ public async Task<IReadOnlyList<RegistryPlugin>> FetchIndexAsync(CancellationTok
         {
             var index = await FetchIndexAsync(ct);
             var entry = index.FirstOrDefault(p => p.Name.Equals(name, StringComparison.OrdinalIgnoreCase));
-            if (entry is null)
-                return null;
-
-            // A pinned version that differs from the index's current one: the registry
-            // keeps every build under dll/<name>-v<ver>.dll, so synthesize the filenames.
-            if (!string.IsNullOrWhiteSpace(version) &&
-                !version.Equals("latest", StringComparison.OrdinalIgnoreCase) &&
-                !version.Equals(entry.Version, StringComparison.OrdinalIgnoreCase))
-            {
-                return entry with
-                {
-                    Version = version,
-                    Dll = $"{entry.Name}-v{version}.dll",
-                    Deps = $"{entry.Name}-v{version}-deps.zip",
-                };
-            }
-
-            return entry;
+            return entry?.WithPinnedVersion(version);
         }
 
         public Task<byte[]> DownloadArtifactAsync(string file, CancellationToken ct = default) =>

src/Schuly.Application/Queries/Exam/ExamQueryExtensions.cs

@@ -0,0 +1,19 @@
+using Microsoft.EntityFrameworkCore;
+
+namespace Schuly.Application.Queries.Exam
+{
+    internal static class ExamQueryExtensions
+    {
+        // Student visibility: only exams for a class the user is enrolled in, with
+        // only the user's own grades projected - never a classmate's. Admins see all.
+        public static IQueryable<Domain.Exam> ApplyVisibility(this IQueryable<Domain.Exam> exams, bool isAdmin, IReadOnlyList<Guid> myIds)
+        {
+            IQueryable<Domain.Exam> scoped = exams.AsNoTracking().Include(e => e.Class);
+
+            if (!isAdmin)
+                scoped = scoped.Where(e => e.Class!.Students.Any(su => myIds.Contains(su.Id)));
+
+            return scoped.Include(e => e.Grades.Where(g => isAdmin || myIds.Contains(g.SchoolUserId)));
+        }
+    }
+}

src/Schuly.Application/Queries/Exam/GetExamQuery.cs

@@ -21,13 +21,8 @@ public async ValueTask<Result<ExamDto>> Handle(GetExamQuery query, CancellationT
             var isAdmin = userService.IsCurrentUserAdmin();
             IReadOnlyList<Guid> myIds = isAdmin ? [] : await userService.GetCurrentUserSchoolUserIdsAsync(cancellationToken);
 
-            IQueryable<Domain.Exam> dbQuery = dbContext.Exams.AsNoTracking().Include(e => e.Class);
-
-            if (!isAdmin)
-                dbQuery = dbQuery.Where(e => e.Class!.Students.Any(su => myIds.Contains(su.Id)));
-
-            var exam = await dbQuery
-                .Include(e => e.Grades.Where(g => isAdmin || myIds.Contains(g.SchoolUserId)))
+            var exam = await dbContext.Exams
+                .ApplyVisibility(isAdmin, myIds)
                 .SingleOrDefaultAsync(e => e.Id == query.ExamId, cancellationToken);
 
             if (exam == null)

src/Schuly.Application/Queries/Exam/GetExamsQuery.cs

@@ -21,13 +21,8 @@ public async ValueTask<Result<List<ExamDto>>> Handle(GetExamsQuery query, Cancel
             var isAdmin = userService.IsCurrentUserAdmin();
             IReadOnlyList<Guid> myIds = isAdmin ? [] : await userService.GetCurrentUserSchoolUserIdsAsync(cancellationToken);
 
-            IQueryable<Domain.Exam> dbQuery = dbContext.Exams.AsNoTracking().Include(e => e.Class);
-
-            if (!isAdmin)
-                dbQuery = dbQuery.Where(e => e.Class!.Students.Any(su => myIds.Contains(su.Id)));
-
-            var exams = await dbQuery
-                .Include(e => e.Grades.Where(g => isAdmin || myIds.Contains(g.SchoolUserId)))
+            var exams = await dbContext.Exams
+                .ApplyVisibility(isAdmin, myIds)
                 .ToListAsync(cancellationToken);
 
             return Result<List<ExamDto>>.Success(exams.ToDto());